CodeCow/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2026-07-12 21:04:41 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity
cd0db08b14
zulip/frontend_tests/node_tests
History
Tim Abbott cc8021a742 message_list: Fix focus issues when editing last message. 
Previously, if you were in the process of editing the last message in
a narrow and a new message came in, we'd rerender that second-to-last
message, causing your editing widget to lose focus (and thus the next
few keys you typed to be interpreted as keyboard shortcuts, which
had a good chance of resulting in your navigating somewhere random).

This rerendering was essentially unnecessary; the only change to state
going into the rendering process was the next_is_same_sender CSS class
being toggled on the messagebox in the message.  So, at most, we
should have been just toggling that CSS class (and this commit makes
us do precisely that).

It seems like we could further improve this code by just removing the
next_is_same_sender CSS class entirely and removing this block, but
I'm leaving that for follow-up work.

Fixes #11656.
2019-02-25 10:03:49 -08:00
..
.eslintrc.json
activity.js tests: Fix accidental uses of assert() -> assert.equal(). 2019-02-20 10:41:42 -08:00
alert_words_ui.js
alert_words.js node tests: Consolidate some set_global() calls. 2018-08-02 08:02:12 -04:00
billing_helpers.js billing: Use underscore built in contains function. 2019-01-08 10:47:35 -08:00
billing.js billing: Add node test for billing.js. 2019-01-08 10:47:35 -08:00
bot_data.js lint: Fix comma spacing in node tests. 2018-12-07 13:14:28 -08:00
buddy_data.js refactor: Simplify logic for circles. 2019-02-18 14:22:37 -08:00
buddy_list.js buddy list: Add padding to progressive scrollings. 2018-08-02 16:59:27 -07:00
channel.js node tests: Consolidate some set_global() calls. 2018-08-02 08:02:12 -04:00
color_data.js stream_color: Make stream color assignment more efficient. 2018-11-29 13:00:25 -08:00
colorspace.js
common.js node tests: Consolidate some set_global() calls. 2018-08-02 08:02:12 -04:00
components.js eslint: Add key-spacing linter rule. 2018-12-18 10:41:06 -08:00
compose_actions.js quote/reply: Leave message intact for IE/Chrome. 2019-01-23 10:57:40 -08:00
compose_fade.js subject -> topic: Rename compose fields. 2018-12-09 21:28:45 -08:00
compose_pm_pill.js compose pill: Add has_unconverted_data() helper. 2018-10-12 11:20:30 -07:00
compose_ui.js compose_ui: Create the compose_ui.replace_syntax function. 2018-08-26 23:33:24 -07:00
compose.js edit: Add support for using video call link in message edit. 2019-02-02 11:03:31 -08:00
composebox_typeahead.js typeahead: Show only users in silent mentions typeahead. 2019-02-22 13:17:47 -08:00
copy_and_paste.js paste: More robust check to verify if clipboard data is an image. 2019-01-25 11:40:33 -08:00
dict.js
dispatch.js settings: Add support for uploading logo for night mode. 2019-02-18 15:15:57 -08:00
drafts.js drafts: Fix date-sensitive test. 2019-02-20 06:49:19 -08:00
emoji_picker.js
emoji.js emoji: Change fallback emojiset for text emojiset. 2018-09-21 18:34:12 -07:00
fetch_status.js message_fetch: Deduplicate logic for finish_newer_batch. 2018-12-13 08:43:56 -08:00
filter.js frontend: Use topic on message. 2019-01-07 19:20:56 -08:00
general.js frontend: Use topic on message. 2019-01-07 19:20:56 -08:00
hash_util.js frontend: Use topic on message. 2019-01-07 19:20:56 -08:00
hashchange.js settings: Streamline how we launch settings. 2018-12-07 11:40:56 -08:00
hotkey.js hotkeys: Map CTRL + . to narrow to compose box target. 2018-12-04 13:58:00 -08:00
i18n.js
input_pill.js input pills: Fix modal gets closed when user click on remove-pill-btn. 2018-11-28 16:33:08 -08:00
keydown_util.js keydown_util: Ignore alt-arrow and similar things. 2018-12-04 12:24:39 -08:00
lightbox.js thumbnails: Rename data-original to data-src-fullsize. 2018-07-30 13:00:23 -07:00
list_cursor.js node tests: Bring list_cursor to 100% coverage. 2018-08-24 10:00:04 -07:00
list_render.js
markdown.js tests: Fix accidental uses of assert() -> assert.equal(). 2019-02-20 10:41:42 -08:00
message_edit.js message_edit: Allow editing topics indefinitely. 2018-12-04 17:41:21 -08:00
message_events.js frontend: Use topic on message. 2019-01-07 19:20:56 -08:00
message_fetch.js Refactor: Split up add_messages api. 2019-01-07 17:17:55 -08:00
message_flags.js frontend: Create data structure for starred messages. 2018-08-21 13:42:23 -07:00
message_list_data.js frontend: Use topic on message. 2019-01-07 19:20:56 -08:00
message_list_view.js message_list: Fix focus issues when editing last message. 2019-02-25 10:03:49 -08:00
message_list.js frontend: Use topic on message. 2019-01-07 19:20:56 -08:00
message_store.js lint: Fix comma spacing in node tests. 2018-12-07 13:14:28 -08:00
muting.js page load: Fix two bugs related to muting/unreads. 2018-12-15 13:44:30 -08:00
narrow_activate.js frontend: Use topic on message. 2019-01-07 19:20:56 -08:00
narrow_local.js frontend: Use topic on message. 2019-01-07 19:20:56 -08:00
narrow_state.js filter: Eliminate a few "subject" references. 2018-12-29 11:38:39 -08:00
narrow_unread.js frontend: Use topic on message. 2019-01-07 19:20:56 -08:00
narrow.js search: Display stop words from query when no results. 2019-02-13 13:23:48 -08:00
notifications.js frontend: Use topic on message. 2019-01-07 19:20:56 -08:00
password.js
people_errors.js minor: Change error to warning for missing user ids. 2018-10-29 12:57:15 -07:00
people.js tests: Fix accidental uses of assert() -> assert.equal(). 2019-02-20 10:41:42 -08:00
pm_conversations.js
pm_list.js private messages: Add user circles to top left. 2019-02-18 14:22:37 -08:00
popovers.js refactor: Simplify logic for circles. 2019-02-18 14:22:37 -08:00
presence.js presence: Use people.is_my_user_id() for check. 2019-01-03 13:49:44 -08:00
reactions.js
recent_senders.js frontend: Use topic on message. 2019-01-07 19:20:56 -08:00
rtl.js rtl.js: Fix support for supplementary planes of unicode characters (>= U+10000). 2018-08-14 11:39:29 -07:00
schema.js lint: Fix comma spacing in node tests. 2018-12-07 13:14:28 -08:00
scroll_util.js
search_legacy.js Simplify narrow/search interactions. 2018-10-24 16:54:35 -07:00
search_pill.js tests: Fix accidental uses of assert() -> assert.equal(). 2019-02-20 10:41:42 -08:00
search_suggestion_legacy.js
search_suggestion.js
search.js Revert "search: Open typeahead on empty string only if lookup triggered by Tab." 2018-12-04 13:58:00 -08:00
server_events.js notification: Show wrong narrow notification for non locally echoed message. 2019-02-13 15:51:41 -08:00
settings_bots.js eslint: Add key-spacing linter rule. 2018-12-18 10:41:06 -08:00
settings_muting.js muting: Use stream_id in muting.get_muted_topics(). 2018-12-14 16:05:37 -08:00
settings_org.js settings: Add support for uploading logo for night mode. 2019-02-18 15:15:57 -08:00
settings_profile_fields.js custom profile field: Minor tweaks in field-table in admin settings. 2018-08-21 11:42:59 -07:00
settings_user_groups.js tests: Fix accidental uses of assert() -> assert.equal(). 2019-02-20 10:41:42 -08:00
stream_data.js left sidebar: Disable "gray-out" feature for new users. 2019-02-12 17:43:48 +00:00
stream_events.js Extract color_data.js. 2018-11-28 14:51:51 -08:00
stream_list.js Use stream_id for by_stream__uri(). 2018-12-14 16:05:40 -08:00
stream_search.js left sidebar: Fix closing stream search. 2019-02-25 09:47:44 -08:00
stream_sort.js
submessage.js
subs.js ui: Fix scrollbar regressions. 2019-01-09 09:15:45 -08:00
templates.js refactor: Simplify logic for circles. 2019-02-18 14:22:37 -08:00
timerender.js lint: Fix comma spacing in node tests. 2018-12-07 13:14:28 -08:00
top_left_corner.js top left: Simplify markup for main links. 2019-01-30 13:53:20 -08:00
topic_data.js frontend: Use topic on message. 2019-01-07 19:20:56 -08:00
topic_generator.js
topic_list.js subject -> topic: Fix hash_util.js. 2018-12-29 14:34:06 -08:00
transmit.js frontend: Use topic on message. 2019-01-07 19:20:56 -08:00
typeahead_helper.js frontend: Use topic on message. 2019-01-07 19:20:56 -08:00
typing_data.js
typing_status.js
ui_init.js top left: Simplify markup for main links. 2019-01-30 13:53:20 -08:00
ui.js hotkey: Update test for hotkey deprecation. 2018-09-21 10:59:55 -07:00
unread.js frontend: Use topic on message. 2019-01-07 19:20:56 -08:00
upgrade.js billing: Add node tests for upgrade.js. 2019-02-04 22:37:05 -08:00
upload.js upload: Use a placeholder when uploading. 2018-08-26 23:33:24 -07:00
user_events.js custom profile fields: Markdown rendering for custom profile field values. 2019-01-01 21:06:21 -08:00
user_groups.js tests: Fix accidental uses of assert() -> assert.equal(). 2019-02-20 10:41:42 -08:00
user_pill.js
user_status.js user status: Add ability to edit status text. 2019-01-29 10:27:49 -08:00
util.js tests: Fix accidental uses of assert() -> assert.equal(). 2019-02-20 10:41:42 -08:00
voting_widget.js poll-widget: Downgrade key error to warning. 2019-01-29 09:34:14 -08:00
widgetize.js poll-widget: Refactor comment to option. 2019-01-29 09:34:14 -08:00
zblueslip.js
zjquery.js