zulip/frontend_tests
Tim Abbott cc8021a742 message_list: Fix focus issues when editing last message.
Previously, if you were in the process of editing the last message in
a narrow and a new message came in, we'd rerender that second-to-last
message, causing your editing widget to lose focus (and thus the next
few keys you typed to be interpreted as keyboard shortcuts, which
had a good chance of resulting in your navigating somewhere random).

This rerendering was essentially unnecessary; the only change to state
going into the rendering process was the next_is_same_sender CSS class
being toggled on the messagebox in the message.  So, at most, we
should have been just toggling that CSS class (and this commit makes
us do precisely that).

It seems like we could further improve this code by just removing the
next_is_same_sender CSS class entirely and removing this block, but
I'm leaving that for follow-up work.

Fixes #11656.
2019-02-25 10:03:49 -08:00
..
casper_lib eslint: Add key-spacing linter rule. 2018-12-18 10:41:06 -08:00
casper_tests top left: Simplify markup for main links. 2019-01-30 13:53:20 -08:00
node_tests message_list: Fix focus issues when editing last message. 2019-02-25 10:03:49 -08:00
zjsunit lint: Enforce semicolon spacing in eslint. 2019-01-05 15:31:30 -08:00
.eslintrc.json lint: Check eslint indentation for casper tests. 2018-05-06 19:35:18 -07:00
run-casper tools: Remove pointless uses of shell=True. 2018-07-30 22:39:06 -07:00