Commit Graph

5387 Commits

Author SHA1 Message Date
Tim Abbott
477dbddbdf Hack to make populate_db still work during domain transition.
(imported from commit bd1500b49080c277edba5400c315c9824fcc4ac8)
2013-07-25 17:16:53 -04:00
Tim Abbott
a9b3b20ea6 Use stream Verona rather than Venice for unread count tests.
It's the only one all of test users are guaranteed to be subscribed
to.

(imported from commit 371315f4988cb5b0d6a8ef287575607a91d22d30)
2013-07-25 17:16:53 -04:00
Tim Abbott
fffd9d16d5 populate_db: Compute recipient_streams in a deterministic order.
The rename of humbughq.com to zulip.com had the side effect of making
users often not subscribed to stream Verona, which didn't work well
with our test suite.

(imported from commit 28ebd5b444a026e753935ae99b3baa203bb0f222)
2013-07-25 17:16:53 -04:00
Tim Abbott
f765f40911 We don't need to sync the API keys in the test data.
(imported from commit 7eb4aef657e94e02e3fc596b216de81dc71115ec)
2013-07-25 17:16:53 -04:00
Steve Howell
e8fbe96a62 Suggest streams more aggressively in search.
Before we'd autocomplete d to [stream:design, stream:devel].
Now we also autocomplete stream:d to [stream:design, stream:devel].

(imported from commit d7ecbd032a3414828bf649698d741f0d6a6e3af2)
2013-07-25 16:45:27 -04:00
Waseem Daher
2ed1a8be6a Don't allow content to overflow out of messageboxes.
This helps mitigate the damage caused by hilarious vertical
names like "Puerco (((((())))))" with the vertical parentheses.

(imported from commit e0071851d2dc7d99c9acd93a1fc6fa1ce0c3b70e)
2013-07-25 16:11:57 -04:00
Waseem Daher
4551210b32 "no subject" -> "no topic"
(imported from commit e326e2a19c770599f3f8ca4bec13f93e93d6a1f7)
2013-07-25 16:11:57 -04:00
Waseem Daher
7689fa5fd4 Set reply-to on interest forms.
I often click "reply" and clear out the text to reply to these, and
it's sort of a pain to have to change the address.

(imported from commit ed8aae858bbd1821623cf640956ffccbacfaa1af)
2013-07-25 16:11:56 -04:00
Steve Howell
c51056ff8e Turn off diff highlighting everywhere
(imported from commit b1ac105d35e6b4b544b708509b4ae67573b47da8)
2013-07-25 15:23:24 -04:00
Steve Howell
6ae9f95de3 Allow users to edit a bot's full name.
(imported from commit fba8ea888d7b76b1ad5c44393ffd8f420f9fe464)
2013-07-25 13:05:38 -04:00
Steve Howell
b13efe4ee3 Allow users to regenerate a bot's API key.
(imported from commit 6f91c6099e305d43730c022f0d7881eed5872fa8)
2013-07-25 13:01:06 -04:00
Steve Howell
df91b8c14e Lock down permissions for patching a bot, use do_change_full_name().
Sorry, there was some rebasing pain here.

(imported from commit 6f62a2882e5135e740d2f91fbc45cff81d20a5a5)
2013-07-25 13:00:11 -04:00
Steve Howell
a393de2122 Support /bots/[email]/api_key/regenerate
(imported from commit 740ce4813969e45a4673b5419ba9e622acfa401d)
2013-07-25 12:41:52 -04:00
Steve Howell
25a8d5fadd Create back end for patching bots.
(imported from commit 189444d79bb7832b26f3e9c1b65da260122255bd)
2013-07-25 12:41:52 -04:00
Steve Howell
036d0b1fbc tests: Add client_patch helper
(imported from commit 98486ed259a4290ca6386bdfbdf7d42080e5cc60)
2013-07-25 12:27:21 -04:00
Steve Howell
6a5cc006cd Extract random_api_key()
(imported from commit 4e038aa0aab068d29f0ec43c8cc8428b2adf2b13)
2013-07-25 12:27:21 -04:00
Steve Howell
c15c7d7633 Fix whitespace in CSS code
(imported from commit 4b323781a0ef9ef63cd57ada3df8d50985b3f71c)
2013-07-25 12:27:21 -04:00
Steve Howell
3430bc8ff3 Remove unused parameter in get_topic_suggestions()
(imported from commit d32cf560376d2b96b1b974a27158aba5ac6401d3)
2013-07-25 12:17:14 -04:00
Steve Howell
6e0b6dfc24 Organize navigation events in hotkey.js
(imported from commit 2bff0eb8bf7f8f310a5823bc4a569a7b298608c9)
2013-07-24 23:39:35 -04:00
Steve Howell
432f9794cb Extract go_to_row() helper in navigate.js
(imported from commit a2e991c4df4df36a3f1df311a0cc6829eb1c3db2)
2013-07-24 23:39:35 -04:00
Steve Howell
fad259d75d Move code from hotkey.js -> navigate.js.
Created up, down, page_up, page_down, to_home, and to_home pretty
mechanically from the old hotkey.code.

(imported from commit 5956b91c2e0122c6440f70db9b92f918c9b599aa)
2013-07-24 23:39:35 -04:00
Waseem Daher
c0c63d3506 Some /integrations language tweaks.
(imported from commit 3f647dd6d5f72301036da7e1f75756fd19b8b8cb)
2013-07-24 17:47:56 -04:00
Kevin Mehall
eb6bc91c22 New Relic integration
(imported from commit a108f4c6e90d857263453036f6d5f09279302b7e)
2013-07-24 17:19:36 -04:00
Waseem Daher
04ad610263 Restore old mix-protection mechanism.
This is the moral equivalent of reverting
25ac8c557978a3867eba90d93857d9bd728149e2

(imported from commit dc9ac79c2bed46b836bf666d3718f3bcac11099e)
2013-07-24 17:09:36 -04:00
Tim Abbott
4e1434b28d Use update_fields more consistently when modifying model objects.
(imported from commit a3f0c308b621b5ff85c55654f187e25749192b19)
2013-07-24 17:04:39 -04:00
Luke Faraone
f800e6cebb Document message and subject length requirements
LENGTH LIMIT RULES
    This limit is non-refundable unless issued at a fully refundable fare.
    Some fares may not allow changes. If allowed, any change to your
    itinerary may require payment of a change fee and increased fare.
    Failure to appear for any personal message without notice to Zulip will
    result in cancellation of your remaining reservation.

(imported from commit 75d5843677ce959d60d4015779efa9c2cf8f9a1c)
2013-07-24 16:38:17 -04:00
Leo Franchi
e8a56a22e6 Use new key for git.hhq.com in install-server, and typo fixes
(imported from commit 23b69d23be24f2d995b70e03e1e7e6e604407877)
2013-07-24 16:06:34 -04:00
Leo Franchi
bb2df13bfd Unset -e flag during humbug.pem login to preserve idempotency of install-server
(imported from commit d65b635a48ce33908b2888319a7c109d5d126b54)
2013-07-24 16:06:34 -04:00
Tim Abbott
b5eab2bde5 Fix UnreadCountTests to not be checking empty sets.
Because there's no guarantee that Hamlet has message IDs 1 and 2, and
the update_unread_counts function didn't return an error in the event
that you passed it a message that the user never received (it instead
silently succeeded), this test was mostly useless.

I just dumped the test_initial_counts function, because it didn't seem
to be doing anything useful.

(imported from commit 4d76104eb9f3b947727a1a030afc0b57054d0daf)
2013-07-24 15:43:44 -04:00
Tim Abbott
508332da0d tests: Return more than a radius of 1 in get_old_messages.
Otherwise everything breaks if we happen to have more than
approximately 2 messages.

(imported from commit 94c5bda1f69daac437c685e8f19c8a10dbd68e52)
2013-07-24 15:43:44 -04:00
Tim Abbott
afb952ae99 tests: Return the message object in send_message.
(imported from commit baa26b8b2ab16f5e533b8f1606ceff5e50f275f5)
2013-07-24 15:43:44 -04:00
Tim Abbott
270110d8a4 check-all: Fix output for jslint failures.
(imported from commit 1398eea533e4b8b273d3984d9872ef3706c1102e)
2013-07-24 15:43:44 -04:00
Waseem Daher
1303327e0c Fix settings dropdown on mobile devices.
Issue reported by user1@customer34.invalid

(imported from commit b3efa08ac7b4249652a6cd0376aa21217c0435fc)
2013-07-24 15:08:40 -04:00
Steve Howell
312452f174 Show 'subset' search suggestions last
(imported from commit 849e151cfeb56b288419e12621d122327e619023)
2013-07-24 13:39:21 -04:00
Steve Howell
782e2d43bf Reverse order of 'subset' search suggestions
(imported from commit 1e5f84e8ea3c5a1ec27eaeaada60db720ccd58cd)
2013-07-24 13:39:21 -04:00
Kevin Mehall
f88571f482 Comments documenting the ordering requirements of MessageList._render steps.
(imported from commit 16a493a957e166ee529b9dd8d630cc1717e93456)
2013-07-24 11:48:39 -04:00
Kevin Mehall
dfda1d3137 Fix collapse issue introduced by ca50035 while keeping the effect of its fix.
That commit intended to fix a bug where it jumps to the wrong scroll position
(offset by the difference in height from uncollapsed to collapsed) if you load
collapsed messages at the top, either by scrolling up or when it automatically
fetches more 10s after page load, because before, it updated the scroll
position before processing collapsing, which changes the height of messages.

Updating collapsing needs to happen before the viewport is adjusted, but also
needs to happen after the new messages get appended/prepended to the document
because they need to be attached to the document for getClientBoundingRect to
work.

(imported from commit 44d6a6135524e658084ffcf7d880ba898b577e6d)
2013-07-24 11:06:18 -04:00
Jessica McKellar
f647596cbb Add a CSS class to unfaded messages.
We already have one for faded messages (which this commit simplifies),
but we also need one on unfaded messages to facilitate styling
experiments.

(imported from commit 41a6e2ef136ce73ce8c24de1e35199244ce56d37)
2013-07-23 21:45:07 -04:00
Kevin Mehall
5f3dcfd104 Make the edit form keep the text in the same place as the normal message.
Trac #1540

    * Make edit content box the same width as normal content
    * Scroll to compensate for the added padding and "Topic" field.
    * Restore the scroll position when exiting edit

It's off by 1px on Firefox 22, but Firefox is simply wrong.

(imported from commit 49154f51b538c648934a41a4a7a217198186ede2)
2013-07-23 18:09:05 -04:00
Scott Feeney
c234190bc0 Make stack trace annotation work
The code now unminifies all calls in the stack, including those outside
of app.js.

This requires the Python package sourcemap, recently added as a
dependency.

(imported from commit 550c73ad5bfe78a2c7169c11da0c95cbaac238d7)
2013-07-23 16:34:26 -04:00
Scott Feeney
4b9c82fb97 Insert static_header.txt as a Closure input file
This way its presence doesn't throw off the generated source map.

(imported from commit 4d7cbb7cb3a9ce103a836ea9baa990c88fe5c804)
2013-07-23 16:18:00 -04:00
Scott Feeney
e539d6b2ac [manual] Add python-sourcemap dependency
(imported from commit 784cfa09ecea58f479adb0b17906a4d0ec10f618)
2013-07-23 15:57:07 -04:00
Scott Feeney
0a3d24826e Zulipify the review script
* CC to code-review@zulip.com
* If domains are omitted, assume @zulip.com
* Don't set email or site explicitly, instead relying on ~/.humbugrc

(imported from commit 9700a0e3d6aac97c8030dcbaba7790018173929a)
2013-07-23 14:53:34 -04:00
Scott Feeney
1e8881d21a Accept zulip.com emails in post-commit hook
(imported from commit 783aec2bf0613ef962afa48614d56d3f81d54e38)
2013-07-23 14:50:39 -04:00
Tim Abbott
9dbbdb1cdf Avoid get_updates failing to update following bugged update_person events.
(imported from commit 7785277ab967a67135e1bd4aa226a0d64adccaba)
2013-07-23 14:26:33 -04:00
Tim Abbott
9132baacc2 Update settings.py for our current app server hostnames.
(imported from commit a8f72faf2c0204c2e86d641da5eb81b57e935183)
2013-07-23 14:26:33 -04:00
Waseem Daher
32fd11c74c Restore "Font Awesome" inclusion in the portico.
(imported from commit 0e49205a995d4b52ab1170eaf96b49d4cab47515)
2013-07-23 13:38:20 -04:00
Steve Howell
ffa178cf7a Suggest "widening" searches in search autocomplete.
This will allow you to always get Home from the search box,
as well as easily backing out narrows.

(imported from commit 68bcfc83ce0428645f4e734ae46f9589cb562a86)
2013-07-23 13:18:33 -04:00
Jeff Arnold
4b69094ffd For <= 1 message selections, convert emoji into text
<= 1 message selections previously were not being handled
by copy_handler at all

(imported from commit 031ab4ce6db4b1aae4ea202611d09066c87f0faa)
2013-07-23 12:29:52 -04:00
Jeff Arnold
ee3806ef5b In the desktop app, paste emoji as text to work around webkit bug
See Trac #1060

(imported from commit 860f16c5a9db626a4fd2d55bcb0dd137e5196560)
2013-07-23 12:25:59 -04:00