CodeCow/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2026-07-15 21:03:26 +08:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity

tests: Access realm directly from ScheduledMessage object.

Browse Source 
There is no need to get realm for sender as ScheduledMessage
object also has realm field.

There is no direct benefit of this change but it is nice to
maintain the pattern which we want to follow in the code
in tests as well.
This commit is contained in:
Sahil Batra 2023-08-10 13:02:02 +05:30 committed by Tim Abbott
parent 58aecbe443
commit e9a6f69849
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
zerver/tests/test_scheduled_messages.py
View File

@ -276,7 +276,7 @@ class ScheduledMessageTest(ZulipTestCase):
# Verify that the user was sent a message informing them about
# the failed scheduled message.
realm = scheduled_message.sender.realm
realm = scheduled_message.realm
msg = most_recent_message(scheduled_message.sender)
self.assertEqual(msg.recipient.type, msg.recipient.PERSONAL)
self.assertEqual(msg.sender_id, self.notification_bot(realm).id)
@ -290,7 +290,7 @@ class ScheduledMessageTest(ZulipTestCase):
# Verify realm isn't deactivated and get user's most recent
# message.
self.assertFalse(scheduled_message.sender.realm.deactivated)
self.assertFalse(scheduled_message.realm.deactivated)
message_before_deactivation = most_recent_message(scheduled_message.sender)
more_than_scheduled_delivery_datetime = (
@ -306,7 +306,7 @@ class ScheduledMessageTest(ZulipTestCase):
)
# Verify that no failed scheduled message notification was sent.
self.assertTrue(scheduled_message.sender.realm.deactivated)
self.assertTrue(scheduled_message.realm.deactivated)
message_after_deactivation = most_recent_message(scheduled_message.sender)
self.assertEqual(message_after_deactivation.content, message_before_deactivation.content)
self.assertNotIn(expected_failure_message, message_after_deactivation.content)
@ -373,7 +373,7 @@ class ScheduledMessageTest(ZulipTestCase):
# Verify that the user was sent a message informing them about
# the failed scheduled message.
realm = scheduled_message.sender.realm
realm = scheduled_message.realm
msg = most_recent_message(scheduled_message.sender)
self.assertEqual(msg.recipient.type, msg.recipient.PERSONAL)
self.assertEqual(msg.sender_id, self.notification_bot(realm).id)