From e9a6f69849ed0cd91dac2b2cf3ff91c1da8b622e Mon Sep 17 00:00:00 2001 From: Sahil Batra Date: Thu, 10 Aug 2023 13:02:02 +0530 Subject: [PATCH] tests: Access realm directly from ScheduledMessage object. There is no need to get realm for sender as ScheduledMessage object also has realm field. There is no direct benefit of this change but it is nice to maintain the pattern which we want to follow in the code in tests as well. --- zerver/tests/test_scheduled_messages.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/zerver/tests/test_scheduled_messages.py b/zerver/tests/test_scheduled_messages.py index 0a9fa75473..3dbd2f4c4b 100644 --- a/zerver/tests/test_scheduled_messages.py +++ b/zerver/tests/test_scheduled_messages.py @@ -276,7 +276,7 @@ class ScheduledMessageTest(ZulipTestCase): # Verify that the user was sent a message informing them about # the failed scheduled message. - realm = scheduled_message.sender.realm + realm = scheduled_message.realm msg = most_recent_message(scheduled_message.sender) self.assertEqual(msg.recipient.type, msg.recipient.PERSONAL) self.assertEqual(msg.sender_id, self.notification_bot(realm).id) @@ -290,7 +290,7 @@ class ScheduledMessageTest(ZulipTestCase): # Verify realm isn't deactivated and get user's most recent # message. - self.assertFalse(scheduled_message.sender.realm.deactivated) + self.assertFalse(scheduled_message.realm.deactivated) message_before_deactivation = most_recent_message(scheduled_message.sender) more_than_scheduled_delivery_datetime = ( @@ -306,7 +306,7 @@ class ScheduledMessageTest(ZulipTestCase): ) # Verify that no failed scheduled message notification was sent. - self.assertTrue(scheduled_message.sender.realm.deactivated) + self.assertTrue(scheduled_message.realm.deactivated) message_after_deactivation = most_recent_message(scheduled_message.sender) self.assertEqual(message_after_deactivation.content, message_before_deactivation.content) self.assertNotIn(expected_failure_message, message_after_deactivation.content) @@ -373,7 +373,7 @@ class ScheduledMessageTest(ZulipTestCase): # Verify that the user was sent a message informing them about # the failed scheduled message. - realm = scheduled_message.sender.realm + realm = scheduled_message.realm msg = most_recent_message(scheduled_message.sender) self.assertEqual(msg.recipient.type, msg.recipient.PERSONAL) self.assertEqual(msg.sender_id, self.notification_bot(realm).id)