CodeCow/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2026-07-18 21:04:19 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

message_send: Refactor internal_send_*, internal_prep_* & _internal_prep_*.

Browse Source 
This commit makes all the parameters after 'content' in
'internal_send_*', 'internal_prep_*' and '_internal_prep_*'
a mandatory keyword argument to increase code readability.
This commit is contained in:
Prakhar Pratyush 2023-01-24 07:46:39 +05:30 committed by Tim Abbott
parent 4595b5d132
commit b40bbd6ca8
1 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
zerver/actions/message_send.py
View File

@ -1495,6 +1495,7 @@ def _internal_prep_message(
sender: UserProfile,
addressee: Addressee,
content: str,
*,
email_gateway: bool = False,
mention_backend: Optional[MentionBackend] = None,
limit_unread_user_ids: Optional[Set[int]] = None,
@ -1546,6 +1547,7 @@ def internal_prep_stream_message(
stream: Stream,
topic: str,
content: str,
*,
email_gateway: bool = False,
limit_unread_user_ids: Optional[Set[int]] = None,
) -> Optional[SendMessageRequest]:
@ -1589,6 +1591,7 @@ def internal_prep_private_message(
sender: UserProfile,
recipient_user: UserProfile,
content: str,
*,
mention_backend: Optional[MentionBackend] = None,
) -> Optional[SendMessageRequest]:
"""
@ -1624,12 +1627,18 @@ def internal_send_stream_message(
stream: Stream,
topic: str,
content: str,
*,
email_gateway: bool = False,
limit_unread_user_ids: Optional[Set[int]] = None,
) -> Optional[int]:
message = internal_prep_stream_message(
sender, stream, topic, content, email_gateway, limit_unread_user_ids=limit_unread_user_ids
sender,
stream,
topic,
content,
email_gateway=email_gateway,
limit_unread_user_ids=limit_unread_user_ids,
)
if message is None: