From b40bbd6ca8f996be6411908eb494dbd5f5ba9502 Mon Sep 17 00:00:00 2001 From: Prakhar Pratyush Date: Tue, 24 Jan 2023 07:46:39 +0530 Subject: [PATCH] message_send: Refactor internal_send_*, internal_prep_* & _internal_prep_*. This commit makes all the parameters after 'content' in 'internal_send_*', 'internal_prep_*' and '_internal_prep_*' a mandatory keyword argument to increase code readability. --- zerver/actions/message_send.py | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/zerver/actions/message_send.py b/zerver/actions/message_send.py index ff217df08c..7d4e896123 100644 --- a/zerver/actions/message_send.py +++ b/zerver/actions/message_send.py @@ -1495,6 +1495,7 @@ def _internal_prep_message( sender: UserProfile, addressee: Addressee, content: str, + *, email_gateway: bool = False, mention_backend: Optional[MentionBackend] = None, limit_unread_user_ids: Optional[Set[int]] = None, @@ -1546,6 +1547,7 @@ def internal_prep_stream_message( stream: Stream, topic: str, content: str, + *, email_gateway: bool = False, limit_unread_user_ids: Optional[Set[int]] = None, ) -> Optional[SendMessageRequest]: @@ -1589,6 +1591,7 @@ def internal_prep_private_message( sender: UserProfile, recipient_user: UserProfile, content: str, + *, mention_backend: Optional[MentionBackend] = None, ) -> Optional[SendMessageRequest]: """ @@ -1624,12 +1627,18 @@ def internal_send_stream_message( stream: Stream, topic: str, content: str, + *, email_gateway: bool = False, limit_unread_user_ids: Optional[Set[int]] = None, ) -> Optional[int]: message = internal_prep_stream_message( - sender, stream, topic, content, email_gateway, limit_unread_user_ids=limit_unread_user_ids + sender, + stream, + topic, + content, + email_gateway=email_gateway, + limit_unread_user_ids=limit_unread_user_ids, ) if message is None: