CodeCow/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2026-07-09 21:21:47 +08:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity

compose: Fix buggy recipient id code.

Browse Source 
`selected_recipient_id` is supposed to be an id,
not a stream name. This function is currently
only ever called for direct messages, so there's
no present user-facing bug.
This commit is contained in:
evykassirer 2023-05-25 17:37:22 -07:00 committed by Tim Abbott
parent 91d32d9f16
commit afd703fe77
1 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
web/src/compose_state.js
View File

@ -97,11 +97,9 @@ export function set_stream_name(stream_name) {
compose_recipient.set_selected_recipient_id(stream_id);
}
export function set_compose_recipient_id(value) {
let recipient_id = compose_recipient.DIRECT_MESSAGE_ID;
if (typeof value === "number") {
// value is stream name
recipient_id = sub_store.maybe_get_stream_name(value) || "";
export function set_compose_recipient_id(recipient_id) {
if (typeof recipient_id !== "number") {
recipient_id = compose_recipient.DIRECT_MESSAGE_ID;
}
compose_recipient.set_selected_recipient_id(recipient_id);
}