From afd703fe779a8ef6a1b87f1578040a59a2eca71e Mon Sep 17 00:00:00 2001 From: evykassirer Date: Thu, 25 May 2023 17:37:22 -0700 Subject: [PATCH] compose: Fix buggy recipient id code. `selected_recipient_id` is supposed to be an id, not a stream name. This function is currently only ever called for direct messages, so there's no present user-facing bug. --- web/src/compose_state.js | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/web/src/compose_state.js b/web/src/compose_state.js index 3826757560..b22befb1f1 100644 --- a/web/src/compose_state.js +++ b/web/src/compose_state.js @@ -97,11 +97,9 @@ export function set_stream_name(stream_name) { compose_recipient.set_selected_recipient_id(stream_id); } -export function set_compose_recipient_id(value) { - let recipient_id = compose_recipient.DIRECT_MESSAGE_ID; - if (typeof value === "number") { - // value is stream name - recipient_id = sub_store.maybe_get_stream_name(value) || ""; +export function set_compose_recipient_id(recipient_id) { + if (typeof recipient_id !== "number") { + recipient_id = compose_recipient.DIRECT_MESSAGE_ID; } compose_recipient.set_selected_recipient_id(recipient_id); }