CodeCow/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2026-06-30 21:11:04 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

topic_edit: Remove show/hide logic on edit button.

Browse Source 
This logic is superfluous, as action buttons are hidden unless
hovered, and when hovered, the `display: none` this sets is
overridden anyway.

Additionally, removing this avoids interference with the flexbox
presenting the action icons, which was causing elements in the
sender line (sender, as well as the timestamp) to visibly shift
out of place when editing the topic, only to see the layout
corrected upon hovering in the action-button area.
This commit is contained in:
Karl Stolley 2025-01-21 13:41:00 -06:00 committed by Tim Abbott
parent 9883e41436
commit aecd3dff7d
1 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
web/src/message_list.ts
View File

@ -540,7 +540,6 @@ export class MessageList {
show_edit_topic_on_recipient_row($recipient_row: JQuery, $form: JQuery): void {
$recipient_row.find(".topic_edit_form").append($form);
$recipient_row.find(".on_hover_topic_edit").hide();
$recipient_row.find(".edit_message_button").hide();
$recipient_row.find(".stream_topic").hide();
$recipient_row.find(".topic_edit").show();
$recipient_row.find(".always_visible_topic_edit").hide();
@ -551,7 +550,6 @@ export class MessageList {
hide_edit_topic_on_recipient_row($recipient_row: JQuery): void {
$recipient_row.find(".stream_topic").show();
$recipient_row.find(".on_hover_topic_edit").show();
$recipient_row.find(".edit_message_button").show();
$recipient_row.find(".topic_edit_form").empty();
$recipient_row.find(".topic_edit").hide();
$recipient_row.find(".always_visible_topic_edit").show();