From aecd3dff7db99fe7abb448d414c15e1db5e07c94 Mon Sep 17 00:00:00 2001
From: Karl Stolley <karl@zulip.com>
Date: Tue, 21 Jan 2025 13:41:00 -0600
Subject: [PATCH] topic_edit: Remove show/hide logic on edit button.

This logic is superfluous, as action buttons are hidden unless
hovered, and when hovered, the `display: none` this sets is
overridden anyway.

Additionally, removing this avoids interference with the flexbox
presenting the action icons, which was causing elements in the
sender line (sender, as well as the timestamp) to visibly shift
out of place when editing the topic, only to see the layout
corrected upon hovering in the action-button area.
---
 web/src/message_list.ts | 2 --
 1 file changed, 2 deletions(-)

diff --git a/web/src/message_list.ts b/web/src/message_list.ts
index 619c88840f..64d2a9ad87 100644
--- a/web/src/message_list.ts
+++ b/web/src/message_list.ts
@@ -540,7 +540,6 @@ export class MessageList {
     show_edit_topic_on_recipient_row($recipient_row: JQuery, $form: JQuery): void {
         $recipient_row.find(".topic_edit_form").append($form);
         $recipient_row.find(".on_hover_topic_edit").hide();
-        $recipient_row.find(".edit_message_button").hide();
         $recipient_row.find(".stream_topic").hide();
         $recipient_row.find(".topic_edit").show();
         $recipient_row.find(".always_visible_topic_edit").hide();
@@ -551,7 +550,6 @@ export class MessageList {
     hide_edit_topic_on_recipient_row($recipient_row: JQuery): void {
         $recipient_row.find(".stream_topic").show();
         $recipient_row.find(".on_hover_topic_edit").show();
-        $recipient_row.find(".edit_message_button").show();
         $recipient_row.find(".topic_edit_form").empty();
         $recipient_row.find(".topic_edit").hide();
         $recipient_row.find(".always_visible_topic_edit").show();