CodeCow/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2026-07-09 21:21:47 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

notifications: Extract notification key retrieval.

Browse Source 
This commit aims to extract all logic related to obtaining
notification key from the `process_notification` function into a
separate `get_notification_key` function.
This commit is contained in:
Daniil Fadeev 2023-07-26 19:25:15 +03:00 committed by Tim Abbott
parent fdac13ba24
commit 53ef273665
1 changed files with 14 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
web/src/notifications.js
View File

@ -245,11 +245,24 @@ function debug_notification_source_value(message) {
blueslip.debug("Desktop notification from source " + notification_source);
}
function get_notification_key(message) {
let key;
if (message.type === "private" || message.type === "test-notification") {
key = message.display_reply_to;
} else {
const stream_name = stream_data.get_stream_name_from_id(message.stream_id);
key = message.sender_full_name + " to " + stream_name + " > " + message.topic;
}
return key;
}
export function process_notification(notification) {
let notification_object;
let key;
const message = notification.message;
const content = get_notification_content(message);
const key = get_notification_key(message);
let other_recipients;
let title = message.sender_full_name;
let msg_count = 1;
@ -259,14 +272,10 @@ export function process_notification(notification) {
debug_notification_source_value(message);
if (message.type === "private" || message.type === "test-notification") {
key = message.display_reply_to;
// Remove the sender from the list of other recipients
other_recipients = `, ${message.display_reply_to}, `
.replace(`, ${message.sender_full_name}, `, ", ")
.slice(", ".length, -", ".length);
} else {
const stream_name = stream_data.get_stream_name_from_id(message.stream_id);
key = message.sender_full_name + " to " + stream_name + " > " + topic;
}
if (notice_memory.has(key)) {