CodeCow/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2026-07-09 21:21:47 +08:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity

notifications: Extract notification_source debugging logic.

Browse Source 
This commit aims to extract all logic related to debugging the value
of `notification_source` from the `process_notification` function into
 a separate `debug_notification_source_value` function.
This commit is contained in:
Daniil Fadeev 2023-07-26 19:19:56 +03:00 committed by Tim Abbott
parent a11dedd393
commit fdac13ba24
1 changed files with 18 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
web/src/notifications.js
View File

@ -229,6 +229,22 @@ function get_notification_content(message) {
return content;
}
function debug_notification_source_value(message) {
let notification_source;
if (message.type === "private" || message.type === "test-notification") {
notification_source = "pm";
} else if (message.mentioned) {
notification_source = "mention";
} else if (message.alerted) {
notification_source = "alert";
} else {
notification_source = "stream";
}
blueslip.debug("Desktop notification from source " + notification_source);
}
export function process_notification(notification) {
let notification_object;
let key;
@ -237,29 +253,21 @@ export function process_notification(notification) {
let other_recipients;
let title = message.sender_full_name;
let msg_count = 1;
let notification_source;
const topic = message.topic;
debug_notification_source_value(message);
if (message.type === "private" || message.type === "test-notification") {
key = message.display_reply_to;
// Remove the sender from the list of other recipients
other_recipients = `, ${message.display_reply_to}, `
.replace(`, ${message.sender_full_name}, `, ", ")
.slice(", ".length, -", ".length);
notification_source = "pm";
} else {
const stream_name = stream_data.get_stream_name_from_id(message.stream_id);
key = message.sender_full_name + " to " + stream_name + " > " + topic;
if (message.mentioned) {
notification_source = "mention";
} else if (message.alerted) {
notification_source = "alert";
} else {
notification_source = "stream";
}
}
blueslip.debug("Desktop notification from source " + notification_source);
if (notice_memory.has(key)) {
msg_count = notice_memory.get(key).msg_count + 1;