CodeCow/stack
1
0
Fork 0
mirror of https://github.com/stack-auth/stack.git synced 2026-06-04 21:04:37 +08:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

fix(saml): reject signInWithSaml when redirectMethod is "none"

Browse Source 
Previously the call would no-op the redirect and then await neverResolve(),
hanging the caller forever. Throw an explicit error instead so the misuse
surfaces immediately.
This commit is contained in:
Bilal Godil 2026-05-01 09:56:50 -07:00
parent be4560b416
commit fdfc400027
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
packages/template/src/lib/stack-app/apps/implementations/client-app-impl.ts
View File

@ -2866,6 +2866,9 @@ export class _StackClientAppImplIncomplete<HasTokenStore extends boolean, Projec
if (typeof window === "undefined") {
throw new Error("signInWithSaml can currently only be called in a browser environment");
}
if (this._redirectMethod === "none") {
throw new Error("signInWithSaml requires a redirectMethod that performs navigation; got 'none'");
}
this._ensurePersistentTokenStore();
const currentUrl = new URL(window.location.href);
const afterCallbackRedirectUrl = options.returnTo != null