CodeCow/stack
1
0
Fork 0
mirror of https://github.com/stack-auth/stack.git synced 2026-07-20 21:29:36 +08:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

Thread augmentation cache through borrow paths in fixChild

Browse Source 
The borrow-left and borrow-right branches in fixChild were rebuilding the
receiving node without a cache, re-extracting augmentations for unchanged
entries. Now combineCaches() merges the parent separator's cached
augmentation with the child node's cached augmentations, and passes the
combined map into make().

Co-Authored-By: Konstantin Wohlwend <[email protected]>
This commit is contained in:
Devin AI
2026-07-06 06:47:44 +00:00
co-authored by Konstantin Wohlwend
parent 9dac04e32e
commit 59617463d4
1 changed files with 24 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
apps/bulldozer-js/src/databases/piledriver/data-structures/augmented-tree-map.ts
+24 -4
View File
@@ -361,6 +361,22 @@ export class AugmentedTreeMultiMap<Key extends PiledriverObject, Value extends P
return cache;
}
// Combines a parent entry-aug cache (for the separator entry) with a child node's cache into a
// single map for make(). Used by borrow paths where the receiving node is built from a parent
// separator plus a child's entries.
private combineCaches(
parentCache: ReadonlyMap<object, Augmentation> | undefined,
separator: Entry<MultiKey<Key, EntryId>, StoredValue<Value>>,
childCache: ReadonlyMap<object, Augmentation> | undefined,
): ReadonlyMap<object, Augmentation> | undefined {
const sepAug = parentCache?.get(separator);
if (sepAug === undefined && !childCache) return undefined;
const combined = new Map<object, Augmentation>();
if (childCache) for (const [e, a] of childCache) combined.set(e, a);
if (sepAug !== undefined) combined.set(separator, sepAug);
return combined;
}
private arity() {
return Math.max(3, this.options.arity ?? defaultArity);
}
@@ -532,25 +548,29 @@ export class AugmentedTreeMultiMap<Key extends PiledriverObject, Value extends P
const left = children[index - 1];
if (left && left.entryCount > this.minEntries()) {
const leftNode = (await this.node(left.ref))!;
const childNode = child ? (await this.node(child.ref))! : { entries: [], children: [] };
const loadedChild = child ? (await this.node(child.ref))! : undefined;
const childNode = loadedChild ?? { entries: [] as Entry<MultiKey<Key, EntryId>, StoredValue<Value>>[], children: [] as Child<MultiKey<Key, EntryId>, Augmentation>[] };
const separator = entries[index - 1];
const borrowedEntry = leftNode.entries[leftNode.entries.length - 1];
const borrowedChild = leftNode.children.at(-1);
entries[index - 1] = borrowedEntry;
children[index - 1] = await this.make(leftNode.entries.slice(0, -1), leftNode.children.slice(0, -1), this.buildEntryAugCache(leftNode));
children[index] = await this.make([separator, ...childNode.entries], borrowedChild === undefined ? childNode.children : [borrowedChild, ...childNode.children]);
const borrowRecvCache = this.combineCaches(cachedEntryAugs, separator, loadedChild ? this.buildEntryAugCache(loadedChild) : undefined);
children[index] = await this.make([separator, ...childNode.entries], borrowedChild === undefined ? childNode.children : [borrowedChild, ...childNode.children], borrowRecvCache);
return await this.afterDelete(entries, children, isRoot, true, cachedEntryAugs);
}
const right = children[index + 1];
if (right && right.entryCount > this.minEntries()) {
const childNode = child ? (await this.node(child.ref))! : { entries: [], children: [] };
const loadedChild = child ? (await this.node(child.ref))! : undefined;
const childNode = loadedChild ?? { entries: [] as Entry<MultiKey<Key, EntryId>, StoredValue<Value>>[], children: [] as Child<MultiKey<Key, EntryId>, Augmentation>[] };
const rightNode = (await this.node(right.ref))!;
const separator = entries[index];
const borrowedEntry = rightNode.entries[0];
const borrowedChild = rightNode.children.at(0);
entries[index] = borrowedEntry;
children[index] = await this.make([...childNode.entries, separator], borrowedChild === undefined ? childNode.children : [...childNode.children, borrowedChild]);
const borrowRecvCache = this.combineCaches(cachedEntryAugs, separator, loadedChild ? this.buildEntryAugCache(loadedChild) : undefined);
children[index] = await this.make([...childNode.entries, separator], borrowedChild === undefined ? childNode.children : [...childNode.children, borrowedChild], borrowRecvCache);
children[index + 1] = await this.make(rightNode.entries.slice(1), rightNode.children.slice(1), this.buildEntryAugCache(rightNode));
return await this.afterDelete(entries, children, isRoot, true, cachedEntryAugs);
}