Commit Graph

21059 Commits

Author SHA1 Message Date
Nick Krantz
cae8799d11
[PM-33196] Web Vault Unit Tests (#19402)
* initial add of vault unit tests

* initial passing web vault test

* add unit tests for add/edit/clone ciphers
2026-03-10 09:35:24 -05:00
Daniel James Smith
bffc14b594
[PM-31198] Remove the hostname from serverCommunicationConfig as the cookieDomain can be used (#19445)
* Remove the hostname from serverCommunicationConfig as the cookieDomain can be used

* Fix types issue

---------

Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2026-03-10 09:12:01 -05:00
Thomas Rittson
7943da240c
[PM-28488] Move event logging code to DIRT folders (#19336)
* Add re-exports from old locations to maintain backward compatibility
2026-03-10 14:58:06 +01:00
Will Martin
2c5db121a6
[CL-854] fix: add readonly to web-header component properties (#19459) 2026-03-10 12:16:09 +01:00
Oscar Hinton
b373e9c1ff
[PM-28754] [PM-28755] Cleanup desktop ui milestone 1 & 2 (#19081)
Removes feature flags for milestone 1 and 2 for desktop ui migration.
2026-03-10 12:02:23 +01:00
Bernd Schoolmann
b8206503b5
[PM-31049] Enable unlock via SDK (#18907)
* Add unlock service

* Move methods

* Prettier

* Fix type errors

* Prettier

* Fix test

* Fix module order

* Attempt to fix tests

* Use unlock service for unlocking

* Featureflag logic

* Add support for setting client managed state

* Add support for biometric unlock

* Add biometric unlock via SDK

* Prettier

* Cleanup CODEOWNERS

* Fix init with client managed state

* Backport biometric unlock and legacy master-key logic

* Add tests for biometrics

* Prettier

* Add biometric unlock to abstract unlock service

* Fix build

* tmp

* Fix tests

* Fix types

* Fix build

* Prettier

* Cleanup

* Fix import order

* Fix tests

* Eslint

* Fix tests

* Prettier

* Load feature flags before crypto init

* Prettier

* Clean up SDK config

* Prettier

* Fix eslint

* Prettier

* Update libs/key-management-ui/src/lock/components/master-password-lock/master-password-lock.component.ts

Co-authored-by: Maciej Zieniuk <167752252+mzieniukbw@users.noreply.github.com>

---------

Co-authored-by: Maciej Zieniuk <167752252+mzieniukbw@users.noreply.github.com>
2026-03-10 11:47:04 +01:00
renovate[bot]
f3b4da0590
[deps] Platform: Update Rust crate sysinfo to v0.38.2 (#18882)
* [deps] Platform: Update Rust crate sysinfo to v0.38.2

* Add Wdk feature

* Use Wdk_System_SystemServices instead

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Daniel García <dani-garcia@users.noreply.github.com>
2026-03-10 11:43:17 +01:00
Bernd Schoolmann
a412a47be7
Fix left-over ts5.9/ts7 incompatibility (#19388) 2026-03-10 06:26:17 -04:00
Will Martin
cc9a3ff4e4
[CL-854] refactor: update web header to use bit-header component (#17663)
Some checks failed
Scan / Check PR run (push) Has been cancelled
Testing / Run typechecking (push) Has been cancelled
Testing / Run tests - ${{ matrix.test-group.name }} (map[artifact:jest-coverage-browser junit:junit-browser.xml name:Browser paths:apps/browser bitwarden_license/bit-browser]) (push) Has been cancelled
Testing / Run tests - ${{ matrix.test-group.name }} (map[artifact:jest-coverage-cli junit:junit-cli.xml name:CLI paths:apps/cli bitwarden_license/bit-cli]) (push) Has been cancelled
Testing / Run tests - ${{ matrix.test-group.name }} (map[artifact:jest-coverage-desktop junit:junit-desktop.xml name:Desktop paths:apps/desktop]) (push) Has been cancelled
Testing / Run tests - ${{ matrix.test-group.name }} (map[artifact:jest-coverage-libs junit:junit-libs.xml name:Libs paths:libs bitwarden_license/bit-common]) (push) Has been cancelled
Testing / Run tests - ${{ matrix.test-group.name }} (map[artifact:jest-coverage-web junit:junit-web.xml name:Web paths:apps/web bitwarden_license/bit-web]) (push) Has been cancelled
Testing / Run Rust tests on ${{ matrix.os }} (macos-14) (push) Has been cancelled
Testing / Run Rust tests on ${{ matrix.os }} (ubuntu-22.04) (push) Has been cancelled
Testing / Run Rust tests on ${{ matrix.os }} (windows-2022) (push) Has been cancelled
Testing / Rust Coverage (push) Has been cancelled
Scan / Checkmarx (push) Has been cancelled
Scan / Sonar (push) Has been cancelled
Testing / Upload to Codecov (push) Has been cancelled
Testing / Run tests (push) Has been cancelled
* feat: add bit-header component to component library

  Add new bit-header component to libs/components with:
  - Header component with left, center, and right content projection
  - Storybook stories for documentation
  - Export from component library index

* refactor: update web header to use bit-header component

  - Refactor web-header to use new bit-header component from libs/components
  - Extract account menu to separate component
  - Update header module to import HeaderComponent

* delete web-header stories

---------

Co-authored-by: Will Martin <wmartin@Wills-MBP.attlocal.net>
2026-03-09 18:12:26 -05:00
Jordan Aasen
fab31619d9
[PM-33201] - fix vault-filter with remove card type policy (#19404)
* fix vault-filter with remove card type policy

* add specs
2026-03-09 12:56:22 -07:00
Jordan Aasen
bc56d3a81e
truncate long item names to two lines (#19122) 2026-03-09 12:46:44 -07:00
Will Martin
5e90565a79
[CL-1063] add enforce-readonly-angular-properties ESLint rule (#19201)
* Add enforce-readonly-angular-properties ESLint rule
2026-03-09 10:26:42 -07:00
Stephon Brown
42d1ed1939
[PM-33061] Tax Id Should Show for Teams and Enterprise Plans When Upgrading (#19347)
* feat(billing): add taxId to upgrade organization request type

* feat(billing): implement tax ID validation for organization upgrades

* feat(billing): conditionally display tax ID field in upgrade form

* test(billing): add tax ID validation tests for organization upgrades

* fix(billing): PR feedback update

* fix(billing): remove tax id requirement for non-US billing

* test(billing): update tests for non-US billing address
2026-03-09 12:14:41 -05:00
Ben Brooks
c3c067865e
[pm-32250] fix: default to "No Folder" in cipher save prompt (#19342)
* [pm-32250] fix: default to "No Folder" in cipher save prompt
* [pm-32250] add tests for button-row.ts

---------

Signed-off-by: Ben Brooks <bbrooks@bitwarden.com>
2026-03-09 09:58:34 -07:00
Jordan Aasen
1cece8123d
[PM-31704] - fix tab focus with filled search input (#19355)
* fix focus issue with search input

* fix search input focus after clearing
2026-03-09 09:37:34 -07:00
neuronull
918dfd8ac3
[BEEEP] Desktop Native simpler napi errors (#18824) 2026-03-09 10:30:20 -06:00
Jared
d18d55a316
[PM-32820] suspended icon for suspended orgs is not showing up in sidebar (#19296)
* refactor: Adjust icon placement in org-switcher and nav-group components

* Move icons from 'end' to 'start' slot in org-switcher component for better alignment.
* Add conditional rendering for content in the 'start' slot of nav-group component.

* feat: Add warning icon support to navigation components

* Introduce `warningIcon` and `warningIconLabel` inputs in nav-base component for customizable warning icons.
* Update org-switcher and nav-group components to utilize the new warning icon functionality.
* Implement conditional rendering of warning icons in nav-item component for better user feedback.

* Enhance org-switcher component by replacing warning icon logic with a dedicated bit-icon element for better accessibility. Also, import IconModule to support the new icon usage.

* Refactor navigation components to remove deprecated warning icon properties and enhance structure. Updated org-switcher to utilize a dedicated bit-icon for accessibility improvements.

* Enhance org-switcher component by adding a margin utility class for improved layout consistency. Clean up nav-group component by removing deprecated slot logic for better maintainability.
2026-03-09 12:18:23 -04:00
Jared
ecbab67b8b
Enhance MasterPassword policy handling in tests and service (#19350)
* Add tests to verify behavior when organizations do not use policies and when users are exempt as owners.
* Update service logic to correctly handle policy retrieval based on user type and organization settings.
2026-03-09 11:52:23 -04:00
Oscar Hinton
08f6ab58ee
Remove LooseComponentsModule (#19144) 2026-03-09 16:37:14 +01:00
cyprain-okeke
2a2bce7c82
[PM-31229][Desktop app] Upgrade to Premium card issues (#19337)
* Fix the bug month

* Resolve teh pr comment
2026-03-09 16:07:31 +01:00
Bernd Schoolmann
abfa23c879
Fix left-over ts5.9/ts7 incompatibility (#19387) 2026-03-09 10:46:01 -04:00
Will Martin
9241b0a79e
[CL-822] Disable popover Chromatic snapshots (#19446)
Re-adds chromatic disableSnapshot flag removed in #18755. Popover positioning is still flaky.
2026-03-09 14:29:57 +00:00
blackwood
da3b31121a
Removes cache clearing that creates a race condition. (#18859) 2026-03-09 10:01:48 -04:00
renovate[bot]
10eb361830
[deps] Autofill: Update tabbable to v6.4.0 (#18431)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2026-03-09 09:52:53 -04:00
Will Martin
7205a157e5
[CL-1028] create popover anchor directive and spotlight mode (#18755)
* create popover anchor directive; update popover trigger directive to use it
* refactor Kitchen Sink stories
2026-03-09 09:45:48 -04:00
Daniel James Smith
d4c5f85bd7
[PM-29149] Add ServerCommunicationConfigService (#18837)
* Add state- and key-definitions for persisting serverCommunicationConfig(s)

* Add implementation of the SDK-defined ServerCommunicationConfigRepository

* Add ServerCommunicationConfigService

* Add state- and key-definitions for persisting serverCommunicationConfig(s)

* Add implementation of the SDK-defined ServerCommunicationConfigRepository

* Add ServerCommunicationConfigService

* Fix instantiation of ServerCommunicationConfigClient due to additional dependency on ServerCommunicationConfigPlatformApi

* Fix broken tests

* Fix ts-strict error

* Call setCommunicationType when ConfigService.serverCommunicationConfig$ emits (#19218)

Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>

* Move service instantiation to desktop's service.module

* Deleted unused tests

---------

Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2026-03-09 14:06:05 +01:00
bitwarden-devops-bot
bd05a8370b
Bumped client version(s)
Some checks failed
Scan / Check PR run (push) Has been cancelled
Testing / Run typechecking (push) Has been cancelled
Testing / Run tests - ${{ matrix.test-group.name }} (map[artifact:jest-coverage-browser junit:junit-browser.xml name:Browser paths:apps/browser bitwarden_license/bit-browser]) (push) Has been cancelled
Testing / Run tests - ${{ matrix.test-group.name }} (map[artifact:jest-coverage-cli junit:junit-cli.xml name:CLI paths:apps/cli bitwarden_license/bit-cli]) (push) Has been cancelled
Testing / Run tests - ${{ matrix.test-group.name }} (map[artifact:jest-coverage-desktop junit:junit-desktop.xml name:Desktop paths:apps/desktop]) (push) Has been cancelled
Testing / Run tests - ${{ matrix.test-group.name }} (map[artifact:jest-coverage-libs junit:junit-libs.xml name:Libs paths:libs bitwarden_license/bit-common]) (push) Has been cancelled
Testing / Run tests - ${{ matrix.test-group.name }} (map[artifact:jest-coverage-web junit:junit-web.xml name:Web paths:apps/web bitwarden_license/bit-web]) (push) Has been cancelled
Testing / Run Rust tests on ${{ matrix.os }} (macos-14) (push) Has been cancelled
Testing / Run Rust tests on ${{ matrix.os }} (ubuntu-22.04) (push) Has been cancelled
Testing / Run Rust tests on ${{ matrix.os }} (windows-2022) (push) Has been cancelled
Testing / Rust Coverage (push) Has been cancelled
Scan / Checkmarx (push) Has been cancelled
Scan / Sonar (push) Has been cancelled
Testing / Upload to Codecov (push) Has been cancelled
Testing / Run tests (push) Has been cancelled
2026-03-09 10:53:10 +00:00
Daniel James Smith
fb01459bcb
Add registration and execution of request middlewares (#19421)
Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2026-03-09 11:36:06 +01:00
bw-ghapp[bot]
d066a06caf
Autosync the updated translations (#19442)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2026-03-09 02:21:05 -05:00
bw-ghapp[bot]
c35922f99e
Autosync the updated translations (#19444)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2026-03-09 02:20:44 -05:00
bw-ghapp[bot]
c5e8f7fb44
Autosync the updated translations (#19443)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2026-03-09 02:20:30 -05:00
Bernd Schoolmann
8186eb6b9a
[PM-31406] Migrate cryptofunction service and remove old crypto (#19222)
* Migrate cryptofunction service and remove old crypto

* Fix tests and linting

* Update libs/node/src/services/node-crypto-function.service.ts

Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>

* Update libs/node/src/services/node-crypto-function.service.ts

Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>

* Remove non-null assertion

* Fix build

* Prettier

* Update libs/node/src/services/node-crypto-function.service.ts

Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>

---------

Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>
2026-03-07 13:15:04 +01:00
blackwood
f9dff532a6
Improve/optimize autofill collection for SPAs and nested shadow DOM (#18051)
Some checks failed
Scan / Check PR run (push) Has been cancelled
Testing / Run typechecking (push) Has been cancelled
Testing / Run tests - ${{ matrix.test-group.name }} (map[artifact:jest-coverage-browser junit:junit-browser.xml name:Browser paths:apps/browser bitwarden_license/bit-browser]) (push) Has been cancelled
Testing / Run tests - ${{ matrix.test-group.name }} (map[artifact:jest-coverage-cli junit:junit-cli.xml name:CLI paths:apps/cli bitwarden_license/bit-cli]) (push) Has been cancelled
Testing / Run tests - ${{ matrix.test-group.name }} (map[artifact:jest-coverage-desktop junit:junit-desktop.xml name:Desktop paths:apps/desktop]) (push) Has been cancelled
Testing / Run tests - ${{ matrix.test-group.name }} (map[artifact:jest-coverage-libs junit:junit-libs.xml name:Libs paths:libs bitwarden_license/bit-common]) (push) Has been cancelled
Testing / Run tests - ${{ matrix.test-group.name }} (map[artifact:jest-coverage-web junit:junit-web.xml name:Web paths:apps/web bitwarden_license/bit-web]) (push) Has been cancelled
Testing / Run Rust tests on ${{ matrix.os }} (macos-14) (push) Has been cancelled
Testing / Run Rust tests on ${{ matrix.os }} (ubuntu-22.04) (push) Has been cancelled
Testing / Run Rust tests on ${{ matrix.os }} (windows-2022) (push) Has been cancelled
Testing / Rust Coverage (push) Has been cancelled
Scan / Checkmarx (push) Has been cancelled
Scan / Sonar (push) Has been cancelled
Testing / Upload to Codecov (push) Has been cancelled
Testing / Run tests (push) Has been cancelled
2026-03-06 12:03:23 -05:00
Thomas Avery
bb5ed04470
[PM-31630] Fix native messaging state management (#18987)
* Fix native messaging state management

* Add unit tests
2026-03-06 09:59:41 -06:00
Patrick-Pimentel-Bitwarden
173a5499a3
fix(sso): [PM-33190] SSO Fails on Callback from Successful IdP Login (#19398)
* fix(sso): [PM-33190] SSO Fails on Callback from Successful IdP Login - Initial change to try and fix issue.

* fix(sso): [PM-33190] SSO Fails on Callback from Successful IdP Login - Added back in change that broke it.

* fix(sso): [PM-33190] SSO Fails on Callback from Successful IdP Login - Fixed.

* fix(sso): [PM-33190] SSO Fails on Callback from Successful IdP Login - Added tests and updated comment.

* docs(sso): [PM-33190] SSO Fails on Callback from Successful IdP Login - Moved comment.

* test(sso): [PM-33190] SSO Fails on Callback from Successful IdP Login - Accepted feedback.
2026-03-06 09:48:49 -06:00
Jonathan Prusik
364e9b3054
add credentialless attribute to injected iframes (#19286) 2026-03-06 10:14:56 -05:00
Vijay Oommen
056a76edb4
Dirt/pm 26487/member access reports icon colors (#19363) 2026-03-06 09:05:26 -06:00
Maciej Zieniuk
d08d8743be
[PM-20372] Clear master password unlock state on Key Connector migration (#18485)
* clear master password unlock state on Key Connector migration

* missing dependency

* missing dependency

* types fix
2026-03-06 15:38:14 +01:00
bw-ghapp[bot]
3d6dec816c
Autosync the updated translations (#19410)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2026-03-06 08:31:44 +00:00
bw-ghapp[bot]
a04f19b788
Autosync the updated translations (#19411)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2026-03-06 08:31:18 +00:00
Oscar Hinton
a697417f08
Remove most JslibModule usages from desktop (#19384) 2026-03-06 09:22:29 +01:00
bw-ghapp[bot]
8ad7eb853a
Autosync the updated translations (#19409)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2026-03-06 09:14:41 +01:00
Nik Gilmore
6695083574
[PM-30304] Migrate Cipher Get Operations to use SDK (#18332)
* Migrate create and edit operations to use SDK for ciphers

* WIP: Adds admin call to edit ciphers with SDK

* Add client version to SDK intialization settings

* Remove console.log statements

* Adds originalCipherId and collectionIds to updateCipher

* Update tests for new cipehrService interfaces

* Rename SdkCipherOperations feature flag

* Add call to Admin edit SDK if flag is passed

* Add tests for SDK path

* Revert changes to .npmrc

* Remove outdated comments

* Fix feature flag name

* Fix UUID format in cipher.service.spec.ts

* Update calls to cipherService.updateWithServer and .createWithServer to new interface

* Update CLI and Desktop to use new cipherSErvice interfaces

* Fix tests for new cipherService interface change

* Bump sdk-internal and commercial-sdk-internal versions to 0.2.0-main.439

* Fix linting errors

* Fix typescript errors impacted by this chnage

* Fix caching issue on browser extension when using SDK cipher ops.

* Remove commented code

* Implement deleteWithServer and deleteManyWithSErver using SDK

* Implement restoreWithServer and restoreManyWithServer using SDK

* Add softDeleteWithServer and softDeleteManyWithServer impl using SDK

* Wrap SDK functions in firstValueFrom

* Fix bug causing race condition due to not consuming / awaiting observable.

* Add orgId to interface for admin deleteMany calls

* Use cipherService to deleteManyWithServer as admin, instead of API directly

* Bump SDK version to main.460

* Add tests for delete ops

* Remove unsetting archive date on delete, which was introduced by mistake

* Move getAllFromApiForOrganization to use SDK

* Implement getAllDecrypted and getAllFromApiForOrganization for SDK

* Fix broken CipherView conversion functions

* Fix CipherView type conversions from SDK

* Add missing 'await' to decrypt call

* Clean up unnecessary else statements and fix function naming

* Add comments for this.clearCache

* Add tests for SDK CipherView conversion functions

* Replace sdkservice with cipher-sdk.service

* Fix import issues in browser

* Fix import issues in cli

* Fix type issues

* Fix type issues

* Fix type issues

* Move delete/restore functions to cipher-sdk.service.ts when using SDK flag

* Move getCipher functions to cipher-sdk.service.ts when using SDK flag

* Address PR feedback

* Fix test that fails sporadically due to timing issue

* Simplifications from PR feedback

* UPdate tests

* Remove unnecessary type logic to use returned enum

* Revert changes to cipher.view.ts converting CipherListView to CipherView

* updated changes to match SDK changes

* Updated sdk package

---------

Co-authored-by: gbubemismith <gsmithwalter@gmail.com>
Co-authored-by: SmithThe4th <gsmith@bitwarden.com>
2026-03-05 19:03:48 +00:00
Vicki League
294d2c991c
[CL-1074] Fix conditional workflow run for push events (#19393) 2026-03-05 12:41:48 -05:00
Daniel James Smith
f7a5dd85ad
Remove unused templates from desktop's app.component (#19391)
* Remove unused templates from desktops app.component

* Remove all unused services from ctor

---------

Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2026-03-05 16:41:44 +01:00
Jason Ng
0e4f9ee65b
[PM-33155] add spec for at-risk-password-callout component in browser (#19381) 2026-03-05 10:01:25 -05:00
Github Actions
9672c576dc Bumped Desktop client to 2026.3.0 2026-03-05 14:02:20 +00:00
Daniel James Smith
b932ae04fd
Remove unused ColorPasswordCountPipe and ColorPasswordPipe (#19345)
With the replacement of the vault cipher view and add-edit views on the desktop client, we no longer require the ColorPasswordCountPipe or the ColorPasswordPipe, as these are now handled by the ColorPasswordComponent from the Bitwarden component library

Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2026-03-05 08:56:31 +01:00
Bernd Schoolmann
944b3ffdc2
[PM-31406] fix: TypeScript 5.9 type compatibility fixes for auth-owned code (#19187)
* fix: add TypeScript 5.9 type compatibility fixes for auth-owned code

Add explicit `as BufferSource` casts and `Uint8Array` wrapping to satisfy
stricter type checking in TypeScript 5.9. Non-functional changes.

* Fix type errors

* Fix test

* Fix tests

* Fix typing in auth tests

* Also change unlock service to uint8array<arraybuffer>

* Fix types

* Prettier

* Apply fixes for jest spy type
2026-03-04 19:12:44 -07:00
Nik Gilmore
6cce91d899
[PM-31825] Add fido2 support to SDK create/update methods (#18800)
* Add fido2 support to SDK create/update methods

* Refactor FIDO2 handling when using the SDK for CipherView conversions

* Remove unneeded comments

* Update tests for FIDO2 functionality

* Reorder imports

* Fixed merge conflicts

---------

Co-authored-by: gbubemismith <gsmithwalter@gmail.com>
Co-authored-by: SmithThe4th <gsmith@bitwarden.com>
2026-03-04 16:27:11 -05:00