Commit Graph

21026 Commits

Author SHA1 Message Date
Thomas Avery
bb5ed04470
[PM-31630] Fix native messaging state management (#18987)
* Fix native messaging state management

* Add unit tests
2026-03-06 09:59:41 -06:00
Patrick-Pimentel-Bitwarden
173a5499a3
fix(sso): [PM-33190] SSO Fails on Callback from Successful IdP Login (#19398)
* fix(sso): [PM-33190] SSO Fails on Callback from Successful IdP Login - Initial change to try and fix issue.

* fix(sso): [PM-33190] SSO Fails on Callback from Successful IdP Login - Added back in change that broke it.

* fix(sso): [PM-33190] SSO Fails on Callback from Successful IdP Login - Fixed.

* fix(sso): [PM-33190] SSO Fails on Callback from Successful IdP Login - Added tests and updated comment.

* docs(sso): [PM-33190] SSO Fails on Callback from Successful IdP Login - Moved comment.

* test(sso): [PM-33190] SSO Fails on Callback from Successful IdP Login - Accepted feedback.
2026-03-06 09:48:49 -06:00
Jonathan Prusik
364e9b3054
add credentialless attribute to injected iframes (#19286) 2026-03-06 10:14:56 -05:00
Vijay Oommen
056a76edb4
Dirt/pm 26487/member access reports icon colors (#19363) 2026-03-06 09:05:26 -06:00
Maciej Zieniuk
d08d8743be
[PM-20372] Clear master password unlock state on Key Connector migration (#18485)
* clear master password unlock state on Key Connector migration

* missing dependency

* missing dependency

* types fix
2026-03-06 15:38:14 +01:00
bw-ghapp[bot]
3d6dec816c
Autosync the updated translations (#19410)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2026-03-06 08:31:44 +00:00
bw-ghapp[bot]
a04f19b788
Autosync the updated translations (#19411)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2026-03-06 08:31:18 +00:00
Oscar Hinton
a697417f08
Remove most JslibModule usages from desktop (#19384) 2026-03-06 09:22:29 +01:00
bw-ghapp[bot]
8ad7eb853a
Autosync the updated translations (#19409)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2026-03-06 09:14:41 +01:00
Nik Gilmore
6695083574
[PM-30304] Migrate Cipher Get Operations to use SDK (#18332)
* Migrate create and edit operations to use SDK for ciphers

* WIP: Adds admin call to edit ciphers with SDK

* Add client version to SDK intialization settings

* Remove console.log statements

* Adds originalCipherId and collectionIds to updateCipher

* Update tests for new cipehrService interfaces

* Rename SdkCipherOperations feature flag

* Add call to Admin edit SDK if flag is passed

* Add tests for SDK path

* Revert changes to .npmrc

* Remove outdated comments

* Fix feature flag name

* Fix UUID format in cipher.service.spec.ts

* Update calls to cipherService.updateWithServer and .createWithServer to new interface

* Update CLI and Desktop to use new cipherSErvice interfaces

* Fix tests for new cipherService interface change

* Bump sdk-internal and commercial-sdk-internal versions to 0.2.0-main.439

* Fix linting errors

* Fix typescript errors impacted by this chnage

* Fix caching issue on browser extension when using SDK cipher ops.

* Remove commented code

* Implement deleteWithServer and deleteManyWithSErver using SDK

* Implement restoreWithServer and restoreManyWithServer using SDK

* Add softDeleteWithServer and softDeleteManyWithServer impl using SDK

* Wrap SDK functions in firstValueFrom

* Fix bug causing race condition due to not consuming / awaiting observable.

* Add orgId to interface for admin deleteMany calls

* Use cipherService to deleteManyWithServer as admin, instead of API directly

* Bump SDK version to main.460

* Add tests for delete ops

* Remove unsetting archive date on delete, which was introduced by mistake

* Move getAllFromApiForOrganization to use SDK

* Implement getAllDecrypted and getAllFromApiForOrganization for SDK

* Fix broken CipherView conversion functions

* Fix CipherView type conversions from SDK

* Add missing 'await' to decrypt call

* Clean up unnecessary else statements and fix function naming

* Add comments for this.clearCache

* Add tests for SDK CipherView conversion functions

* Replace sdkservice with cipher-sdk.service

* Fix import issues in browser

* Fix import issues in cli

* Fix type issues

* Fix type issues

* Fix type issues

* Move delete/restore functions to cipher-sdk.service.ts when using SDK flag

* Move getCipher functions to cipher-sdk.service.ts when using SDK flag

* Address PR feedback

* Fix test that fails sporadically due to timing issue

* Simplifications from PR feedback

* UPdate tests

* Remove unnecessary type logic to use returned enum

* Revert changes to cipher.view.ts converting CipherListView to CipherView

* updated changes to match SDK changes

* Updated sdk package

---------

Co-authored-by: gbubemismith <gsmithwalter@gmail.com>
Co-authored-by: SmithThe4th <gsmith@bitwarden.com>
2026-03-05 19:03:48 +00:00
Vicki League
294d2c991c
[CL-1074] Fix conditional workflow run for push events (#19393) 2026-03-05 12:41:48 -05:00
Daniel James Smith
f7a5dd85ad
Remove unused templates from desktop's app.component (#19391)
* Remove unused templates from desktops app.component

* Remove all unused services from ctor

---------

Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2026-03-05 16:41:44 +01:00
Jason Ng
0e4f9ee65b
[PM-33155] add spec for at-risk-password-callout component in browser (#19381) 2026-03-05 10:01:25 -05:00
Github Actions
9672c576dc Bumped Desktop client to 2026.3.0 2026-03-05 14:02:20 +00:00
Daniel James Smith
b932ae04fd
Remove unused ColorPasswordCountPipe and ColorPasswordPipe (#19345)
With the replacement of the vault cipher view and add-edit views on the desktop client, we no longer require the ColorPasswordCountPipe or the ColorPasswordPipe, as these are now handled by the ColorPasswordComponent from the Bitwarden component library

Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2026-03-05 08:56:31 +01:00
Bernd Schoolmann
944b3ffdc2
[PM-31406] fix: TypeScript 5.9 type compatibility fixes for auth-owned code (#19187)
* fix: add TypeScript 5.9 type compatibility fixes for auth-owned code

Add explicit `as BufferSource` casts and `Uint8Array` wrapping to satisfy
stricter type checking in TypeScript 5.9. Non-functional changes.

* Fix type errors

* Fix test

* Fix tests

* Fix typing in auth tests

* Also change unlock service to uint8array<arraybuffer>

* Fix types

* Prettier

* Apply fixes for jest spy type
2026-03-04 19:12:44 -07:00
Nik Gilmore
6cce91d899
[PM-31825] Add fido2 support to SDK create/update methods (#18800)
* Add fido2 support to SDK create/update methods

* Refactor FIDO2 handling when using the SDK for CipherView conversions

* Remove unneeded comments

* Update tests for FIDO2 functionality

* Reorder imports

* Fixed merge conflicts

---------

Co-authored-by: gbubemismith <gsmithwalter@gmail.com>
Co-authored-by: SmithThe4th <gsmith@bitwarden.com>
2026-03-04 16:27:11 -05:00
Andy Pixley
e1078a00fa
[BRE-1530] Updating certificate name from 8bit to Bitwarden (#19380) 2026-03-04 16:16:12 -05:00
Nick Krantz
caa6b85f0e
[PM-33060][PM-33078] Autofill Notification Cleanup (#19349)
* only shown autofill notification when there are autofill ciphers present

* refactor to use @if syntax

* add unit tests

* make autofill icon larger

* formatting

* remove multiple subscriptions on showEmptyAutofillTip$
2026-03-04 15:09:14 -06:00
renovate[bot]
ea0f623300
[deps] Tools: Update dotnet monorepo to v8.0.17 (#17555)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Alex Dragovich <46065570+itsadrago@users.noreply.github.com>
2026-03-04 12:49:40 -08:00
Vicki League
475a1d6882
[CL-1074] Update chromatic workflow to run on all internal PRs (#19373) 2026-03-04 14:58:11 -05:00
Mick Letofsky
4a3ed19fd6
Disabling Claude Code attribution settings (#19374) 2026-03-04 14:28:53 -05:00
vlad-trofimov
4d4183e121
skip org import warning dialog for My Items (#19334)
Co-authored-by: vlad-trofimov <vlad@Vlads-MacBook-Pro.local>
Co-authored-by: John Harrington <84741727+harr1424@users.noreply.github.com>
2026-03-04 11:05:13 -07:00
renovate[bot]
8125954c04
[deps]: Update Rust crate serial_test to v3.4.0 (#19315)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: neuronull <9162534+neuronull@users.noreply.github.com>
2026-03-04 10:25:03 -07:00
Daniel James Smith
9ed87a4166
Remove gitter chat badges from READMEs (#19368)
Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2026-03-04 16:33:27 +00:00
neuronull
23da514cce
Desktop Native: Add missing docs lint for _some_ modules in core (#18983)
Adds the clippy lint for docs warning to core to align with our contributing docs guidelines.
2026-03-04 09:21:02 -07:00
vlad-trofimov
f0dbf65dd6
[PM-32765] [PM-32744] Default import destination to My Items when org data owner (#19242)
* [PM-32744] Default import destination to My Items when org data ownership policy is enforced

* remove feature flag gating, simplify collection selector logic

* additional code comments to explain import form behavior

---------

Co-authored-by: vlad-trofimov <vlad@Vlads-MacBook-Pro.local>
Co-authored-by: John Harrington <84741727+harr1424@users.noreply.github.com>
2026-03-04 08:28:58 -07:00
Will Martin
5d8adc08b3
chore(dev): enable Tailwind IntelliSense for tw- class strings in TypeScript (#19353) 2026-03-04 10:17:14 -05:00
Vicki League
9b474c5690
[CL-695] Combine display of CL and autofill storybooks (#18404) 2026-03-04 09:45:53 -05:00
Brandon Treston
5ae9a2048b
[PM-33077] Add missing myItems key (#19348)
* add missing myItems key

* fix capitalization
2026-03-04 09:38:57 -05:00
Isaiah Inuwa
d0ca8f7b0a
Split NAPI modules [PM-31598] (#19113)
NAPI modules are all in one file. We use nested modules to define types within TypeScript namespaces, and NAPI requires nested modules to be inline due to rust proc-macro limitations.

However, we can still split these into multiple files and repeat the nested module name for the namespace.

This will improve the ability to set code ownership and navigate the data.

This PR splits the NAPI module files without further modification and assigns code ownership to @bitwarden/team-autofill-desktop-dev for the autofill, autotype and sshagent modules. I verified locally that the generated index.d.ts file does not change at all with this PR; all types are generated exactly the same.
2026-03-04 07:27:39 -06:00
Bernd Schoolmann
f28bea4ca4
[PM-31406] Migrate duckduckgo to purpose-built dangerous-crypto-compat function (#19223)
* Introduce dangerous-compat crypto implementations

* Migrate duckduckgo to purpose-built dangerous-crypto-compat function

* Update typescript version
2026-03-04 10:58:01 +01:00
Bernd Schoolmann
71fa320557
[PM-31406] Migrate lastpass importer to special-purpose dangerous-crypto-compat (#19221)
* Introduce dangerous-compat crypto implementations

* Migrate lastpass importer to purpose-built dangerous-crypto-compat function

* Add missing export

* Prettier
2026-03-04 10:57:47 +01:00
renovate[bot]
6255ea5ac0
[deps] Tools: Update oidc-client-ts to v2.5.0 (#18432)
Some checks failed
Chromatic / Check PR run (push) Has been cancelled
Scan / Check PR run (push) Has been cancelled
Testing / Run typechecking (push) Has been cancelled
Testing / Run tests - ${{ matrix.test-group.name }} (map[artifact:jest-coverage-browser junit:junit-browser.xml name:Browser paths:apps/browser bitwarden_license/bit-browser]) (push) Has been cancelled
Testing / Run tests - ${{ matrix.test-group.name }} (map[artifact:jest-coverage-cli junit:junit-cli.xml name:CLI paths:apps/cli bitwarden_license/bit-cli]) (push) Has been cancelled
Testing / Run tests - ${{ matrix.test-group.name }} (map[artifact:jest-coverage-desktop junit:junit-desktop.xml name:Desktop paths:apps/desktop]) (push) Has been cancelled
Testing / Run tests - ${{ matrix.test-group.name }} (map[artifact:jest-coverage-libs junit:junit-libs.xml name:Libs paths:libs bitwarden_license/bit-common]) (push) Has been cancelled
Testing / Run tests - ${{ matrix.test-group.name }} (map[artifact:jest-coverage-web junit:junit-web.xml name:Web paths:apps/web bitwarden_license/bit-web]) (push) Has been cancelled
Testing / Run Rust tests on ${{ matrix.os }} (macos-14) (push) Has been cancelled
Testing / Run Rust tests on ${{ matrix.os }} (ubuntu-22.04) (push) Has been cancelled
Testing / Run Rust tests on ${{ matrix.os }} (windows-2022) (push) Has been cancelled
Testing / Rust Coverage (push) Has been cancelled
Chromatic / Chromatic (push) Has been cancelled
Scan / Checkmarx (push) Has been cancelled
Scan / Sonar (push) Has been cancelled
Testing / Upload to Codecov (push) Has been cancelled
Testing / Run tests (push) Has been cancelled
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Alex Dragovich <46065570+itsadrago@users.noreply.github.com>
2026-03-03 19:04:43 -08:00
renovate[bot]
f053611771
[deps] Tools: Update @types/papaparse to v5.5.2 (#17840)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2026-03-03 18:45:51 -08:00
renovate[bot]
5b35973944
[deps]: Update Rust crate rusqlite to v0.38.0 (#18202)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Alex Dragovich <46065570+itsadrago@users.noreply.github.com>
2026-03-03 17:12:10 -08:00
Daniel James Smith
8c7c7ebfb8
Make TwoFactorIconComponent standalone (#19305)
Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2026-03-03 18:43:13 -05:00
Jared
ce47bbc113
[PM-32664] Update dialog for organization ownership policy (#19262)
* feat: implement individual items transfer option in data ownership policy

Added a new checkbox for enabling individual items transfer in the organization data ownership policy. When enabled, users will be prompted to move their individual vault items to the organization. Updated the form control logic to handle the new feature and added relevant translations in the messages.json file.

* feat: enhance data loading for individual items transfer in policy edit

Implemented a new loadData method to initialize the form with the enableIndividualItemsTransfer value from the policy response. This ensures the form reflects the current state of the data ownership policy when editing.

* Add unit test for if data is sent as a null attribute

* Rid of extra modal since checkbox replaces it

* Update buildRequestData method to include enableIndividualItemsTransfer property in OrganizationDataOwnershipPolicyData
2026-03-03 16:23:13 -05:00
Daniel James Smith
bc988b4312
Remove dependency on JslibModule for export components (#19346)
Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2026-03-03 20:06:39 +00:00
Oscar Hinton
7bd41be299
[CL-10739 Removing SharedModule from CL (#19150)
* Removing the now unnecessary SharedModule from CL

* fmt
2026-03-03 17:53:45 +01:00
Bernd Schoolmann
6b91ff3867
[PM-24102] Remove encstring decrypt function (#17108)
* Remove orgid in vault decryption code

* Remove deprecated encstring usage from dirt code

* tmp

* Remove folder usage without provided key

* Fix folder test

* Fix build

* Fix build

* Fix build

* Fix tests

* Update error message

* Update spec to not use EncString decrypt

* Remove decrypt from encstring

* Make key required

* Remove unused tests

* Mark old encstring properties as deprecated

* Remove unused test code

* Update function signature

* Undo breaking change (throw on decrypt

* Defensively protect against non-error errors

* Fix types

* Fix prettier formatting

* Fix tests
2026-03-03 14:57:05 +01:00
Oscar Hinton
b7ee23022a
[PM-28926] Add bulk operations to repository (#19321)
Adds the new bulk operations to the client managed state. Also adds a test.
2026-03-03 12:06:43 +01:00
bw-ghapp[bot]
c07a2c48a3
Autosync the updated translations (#19271)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2026-03-03 11:01:10 +01:00
Oscar Hinton
2d3c517a7f
[PM-33006] Convert JslibModule declares to standalone (#19316)
* Convert JslibModule declares to standalone

* Make not premium non standalone since it's handled by a different PR.

* Fix tests
2026-03-03 10:41:17 +01:00
bw-ghapp[bot]
99725a43f2
Autosync the updated translations (#19270)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2026-03-03 09:44:19 +01:00
bw-ghapp[bot]
51a878ab8b
Autosync the updated translations (#19269)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2026-03-03 09:42:52 +01:00
Vicki League
39062a6c97
Bump angular to 20.3.17 (#19295) 2026-03-02 14:01:27 -05:00
Maciej Zieniuk
502a0bde42
update sdk-internal and fix issues (#19333) 2026-03-02 19:06:14 +01:00
Stephon Brown
2facb7e04f
[PM-29823] New Organization Upgrade Path (#19080)
* refactor(billing): Modernize organization plans template with block syntax

* Refactor: Update `@for` loop tracking with `$index`

* Feat: Migrate component properties to Angular signals

* Refactor: Adapt component logic for signal consumption and improve structure

* feat(admin-console): Bind OrganizationPlansComponent inputs directly in template

* refactor(admin-console): Remove ViewChild for OrganizationPlansComponent configuration

* refactor(billing): Switch productTier and plan to input signals

* refactor(billing): Update productTier and plan access to use form controls

* refactor(billing): Rename 'isCreatingNewOrganization' getter

* refactor(billing): Access enterPaymentMethodComponent as a signal

* feat(billing): use createOrganization property for organization creation flow

* refactor(billing): migrate organization plans tests to signals and reactive forms

* refactor(billing): introduce setupMockUpgradeOrganization helper in tests

* refactor(billing): update getters to computed signals

* refactor(billing): update template to use new computed signals

* tests(billing): update tests with computed signals

* feat(billing): update display of specific forms when user is upgrading from premium

* tests(billing): add premium upgrade tests

* fix(billing): update type issues for organization plans

* tests(billing): update failing test

* refactor(billing): rename plan/productTier inputs to initial* for clarity

* refactor(billing): update templates to use renamed initial* inputs

* test(billing): update tests to use renamed initial* inputs

* feat(billing): feature flag upgrade from premium changes

* test(billing): update tests for featureflag

* refactor(ui): Improve HTML templating for organization plans

* refactor(component): Safely derive 'hasPremiumPersonally' signal

* refactor(component): Streamline 'createCloudHosted' method and key handling

* feat(billing): Enable organization key submission for premium upgrades

* test(billing): Enhance and adjust organization plan submission tests

* refactor: remove unused imports and types

* refactor(billing): introduce DTO for organization upgrade request

* feat(billing): implement organization key and collection encryption

* refactor(billing): integrate DTO and encryption logic in upgrade service

* test(billing): update specs and components for organization upgrade DTO

* refactor(billing): relocate FamiliesForEnterpriseSetupComponent to billing module

* refactor(admin-console): revert families-for-enterprise component

* refactor: rename wrappedPrivateKey to encryptedPrivateKey

* refactor(billing): rename encrypted private key variable

* feat(billing): add tier ids and types

* refactor(billing): remove unused imports and sync service

* fix(billing): correct tier passing in upgrade function

* feat(billing): add conversion function from product tier to subscription tier id

* refactor(billing): enhance organization encryption data generation

* fix(billing): enable response for account upgrade

* fix(billing): pass plan tier instead of plan details

* refactor(test): remove unnecessary organization service mock

* test: update upgrade service tests

* tests(billing): update tests

* refactor(billing): import account type
feat(billing): add organization creation message

* refactor(billing): remove unused imports and constants

* refactor(billing): remove unused viewchild

* fix(billing): remove selectedfile variable

* feat(billing): update organization upgrade logic

* refactor(billing): remove unused upgrade functions

* test: remove unnecessary setupMockEncryptionKeys calls

* refactor: remove unused mockAccountBillingClient

* feat: introduce PremiumOrgUpgradeService

* refactor: simplify form value access and remove accountbilling

* fix(billing): handle type validation

* test(billing): add initial plan and product tier input tests

* feat(billing): set initial plan and product tier values

* refactor(billing): ensure selected plan exists before accessing type
2026-03-02 12:16:29 -05:00
Jackson Engstrom
52c551c0fe
[PM-24439] Updates download qr code and buttons to fixed size/width (#18690)
* updates download qr code and buttons to fixed size/width

* updates qr code width to 110px

* adds line break between download description and link
2026-03-02 09:14:35 -08:00