Commit Graph

1116 Commits

Author SHA1 Message Date
Bernd Schoolmann
7574d3859b
[BEEEP] [PM-37492] Make jest tests faster 2026-06-01 14:34:04 -05:00
Mick Letofsky
58a9ac5814
PM-36952 - Improve code review workflow with added triggers (#20702) 2026-05-29 17:54:46 +02:00
neuronull
342aeb9604
Desktop Native: Clean up SSH Agent v1 deps (#20733) 2026-05-26 07:47:04 -06:00
neuronull
9bf6da6a3b
Temporarily increase shared ownership of desktop SSH Agent owned files (#20806) 2026-05-22 13:13:50 -06:00
Andy Pixley
f163a194fa
[BRE-1938] Cleanup build web logic (#20794) 2026-05-21 15:29:33 -04:00
aj-bw
9b1f9a8056
bust cache on root package-lock.json changes (#20791) 2026-05-21 14:01:21 -04:00
Vince Grassia
ebaf990839
Simplify and optimize workflow (#20778) 2026-05-21 11:02:48 -04:00
Vince Grassia
72eeec6255
Update Build Web workflow to only run on published Web releases. Removed migrated Staged Rollout Desktop workflow. (#20761) 2026-05-21 09:05:07 -05:00
gitclonebrian
2baf657ebd
fixed perms in cherry-pick workflow (#20758) 2026-05-20 14:41:14 -05:00
Will Martin
69c937e592
[CL-954] Upgrade to Angular 21 (#19725)
* prune desktop packages

* Fix @napi-rs/cli version mismatch in desktop napi workspace

Aligns package.json declaration with the locked version (3.2.0) to
resolve npm workspace inconsistency that was blocking ng update.

* update Storybook to v10

* update Angular to v21

* override jest in ng builder

* Add jest-environment-jsdom as explicit dependency

Previously installed as a side effect of a jest@29 override; removing
that override caused it to disappear from node_modules.

* Add .claude/worktrees/ to .gitignore

* Restore @napi-rs/cli to 3.5.1 to match main

* Pin jest-environment-jsdom to 29.7.0 and add to renovate config

* Override jest-environment-jsdom to 29.7.0 in build-angular context

* Add isolatedModules to libs/subscription tsconfig.spec.json to fix Angular 21 module resolution

* Change moduleResolution to bundler for Angular 21 subpath export compatibility

* Add isolatedModules to Angular libs with old spec tsconfig pattern

* Disable emitDecoratorMetadata in spec tsconfigs with isolatedModules

* Fix HostListener event parameter types for Angular 21 compiler strictness

* Revert accidental change to access-selector spec

* Remove accidentally generated desktop package-lock.json

* Fix type-only imports/exports caught by Rolldown in Storybook v10/Vite v8

* fix vault-wrapper type error from Angular 21 stricter generic inference

ngComponentOutlet accepts Type<unknown>; annotate computed() explicitly
since VaultComponent is generic and VaultOrigComponent is not, preventing
TypeScript from inferring a compatible union constructor type.

* Fix kitchen-sink interaction tests for Storybook v10

Replace fire-and-forget navigateTo + synchronous getByRole with
navigateAndWaitFor<T>, which sets the hash and retries the ready
callback via waitFor. Storybook v10 starts play functions before
Angular's initial router navigation completes, so synchronous DOM
queries after navigation were failing intermittently.

* Provide ZoneJS change detection scheduler for Storybook stories

Angular 21 no longer sets up the ZoneJS change detection scheduler by
default in bootstrapApplication. Storybook's Angular renderer uses
bootstrapApplication internally and does not add provideZoneChangeDetection
automatically, so Default CD components relying on zone.js to trigger
re-renders after async operations were not updating before Chromatic
snapshots.

* Wait for dialog/side nav to render before Chromatic snapshot

After userEvent.click the dialog and side nav open asynchronously.
Without an explicit waitFor, Chromatic captures the snapshot before the
resulting UI state is present.

* Fix kitchen-sink waitFor: re-query side nav button, use querySelector for dialog

- openSideNav: re-query the toggle button inside waitFor to avoid reading
  a stale DOM reference after Angular re-renders the element post-click
- SimpleDialogOpen / VirtualScrollBlockingDialog: replace getByRole("dialog")
  with querySelector("cdk-dialog-container") to avoid testing-library's
  visibility check failing on a momentarily inaccessible overlay element

* Revert kitchen-sink stories to main

* Bump Angular, Storybook, and ng-select to latest patch versions

* Trigger pre-commit hooks on merge

* Regenerate package-lock.json with --force to fix npm ci sync
2026-05-18 10:55:47 -05:00
renovate[bot]
e0c70519c5
[deps]: Update actions/github-script action to v9 (#20391)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2026-05-13 12:36:02 -04:00
github-actions[bot]
6dae1f4a2a
Bump client version(s) (#20626)
* Bumped client version(s)

* minor change to trigger workflows

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Amy Galles <9685081+AmyLGalles@users.noreply.github.com>
2026-05-13 12:09:10 +02:00
Amy Galles
6dfc24a4ab
Remove BW-GHAPP tokens and GPG from repository-management workflow (#20624)
- Remove all Azure Key Vault and BW-GHAPP token generation
- Remove GPG signing steps
- Use github.token instead of app token
- Use github-actions[bot] email instead of bitwarden-devops-bot
- Create PR with version bump instead of pushing directly to main
- Update permissions (remove id-token, add pull-requests)
2026-05-12 21:09:19 +00:00
Jonathan Prusik
e863ca5b0d
move rust deps to autofill-desktop-dev ownership (#20597) 2026-05-11 08:58:18 -06:00
John Harrington
b3b981ca37
PM-26250 Explore options to enable direct importer for mac app store build (#17479)
* initial sandbox implementation for mac app store builds

* chromium importer working in sandbox

* add import-chrome-component.ts to working tree

* move sandbox code into macos.rs

* add/improve comments and logging

* added docs and removed debug output

* remove additional debug output and revert popup-modal-style to match main

* add dep to desktop_native cargo.toml

* cargo fmt

* avoid unwrap

* pass args directly in objc/build.rs

* cargo clippy

* fix another clippy warning

* remove unused dep

* fix more clippy lints not caught locally

* re-run cargo fmt after fixing clippy lints

* replace swift logic with objc

* rename files to avoid uppercase letters

* rename references

* use progress spinner for imports

* improved error display

* respond to review comments:

• replace usage of compile time flag with boolean for conditinal logic
• moved sandbox specific logic to contained module inside macos.rs
• remove redundant browser array from objc code and pass the target browser path as arg

* pass new bool value on other platforms

* remove sandbox feature flag and refactor to use bool

* fix cargo fmt

* fix clippy error

* fix unused variable outside of macos build

* fix lints on linux build

* eval Claude's comments and address legitimate findings

* clippy lints

* remove callout and revert to previous error display

* adapt chromium_importer to match conventions established  by autofill:
• eliminate extern c and unsafe rust from chromium_importer logic (still called in prior napi/lib.rs)
• use CommandInput / CommandResult JSON pattern to call objc methods
• remove usage of libc to cleanup memory and remove this dependency

* clippy & fmt

* remove ability for user to select dir different to browser

* use new function name introduced in merge

* disable clippy warning on conditionally compiled code block

* fix breaking changes caused by PM-27081

* fix more lints

* rework error handling & presentation

* use bit-spinner instead of bwi-spin

* remove comment related to sandbox flag (outdated)

* address review comments

* revert breaking changes from review suggestions

* fix syntax error

* cargo fmt

* safe changes related to review feedback (checkpoint)

* address remaining review comments

* address review comments

* address review comments

* resolve conflict with main branch

* restore mas_build arg after napi split

* resolve conflicts and ai review

* use sandboxed dir for path resolution

* remove empty clean file

* refactor per ai review

* use i18n for NSOpenPanel dialog
2026-05-07 14:24:41 -07:00
Vince Grassia
acc9811324
Remove release/publish/deploy workflows (#20518) 2026-05-06 16:16:15 -04:00
Todd Martin
2f72b6d61d
chore(deps): [PM-36609] Add regex manager for updating electronVersion on electron updates 2026-05-06 10:15:38 -04:00
neuronull
1ef448b9d7
Desktop Native: Run integration tests in CI (#20424) 2026-05-05 09:07:06 -06:00
renovate[bot]
80c3861bc3
[deps]: Update ruby to v4 (#18203)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Bernd Schoolmann <mail@quexten.com>
2026-05-05 12:30:40 +02:00
Colton Hurst
58ed7dbb3c
Add tech-leads group as owners of the CODEOWNERS file (#20435) 2026-05-04 17:03:05 -04:00
Vince Grassia
1c078bc856
[BRE-1851] Remove GPG signing (#20497) 2026-05-04 18:16:08 +00:00
Andy Pixley
4a63e92fbe
[BRE-1845] Triggering web deploy (#20466) 2026-05-01 16:14:26 -04:00
aj-bw
bfb6c9b5fc
Switch BIT trigger from repository_dispatch to workflow_dispatch (#20469) 2026-05-01 11:38:01 -04:00
Vince Grassia
dff3011473
Update to use official Crowdin action latest version (#20464) 2026-04-30 17:34:25 -05:00
aj-bw
aaead85124
remove 3rd party action, replace with gh api call (#20458) 2026-04-30 16:06:13 -04:00
Vince Grassia
f03514a092
Update Crowdin API token (#20456) 2026-04-30 14:49:38 -04:00
Colton Hurst
6050033d4c
[PM-36072] Change shared ownership to be more precise (#20440) 2026-04-30 08:31:05 -04:00
Mick Letofsky
c7a5f8cf0d
PM-35200 - Create contributing guide for Claude tooling (#20430) 2026-04-30 10:44:58 +02:00
brandonbiete
55ca0f84c5
BRE-1854: Add actions:write permission to build-web-target workflow (#20428)
Fixes startup failures caused by missing actions:write permission.
The trigger-web-vault-deploy job in build-web.yml requires this
permission to dispatch workflows using GITHUB_TOKEN (added in BRE-1670).
2026-04-29 09:40:19 -04:00
Andy Pixley
af278fdebc
[BRE-1845] Removing unused code for Apple signing (#20412) 2026-04-28 13:52:00 -04:00
Andy Pixley
c9005d6c47
[BRE-1845] Setting the id in the keyvault for easier rotation (#20414) 2026-04-28 10:04:07 -07:00
Addison Beck
7d5564e869
chore(deps): group electron in Renovate config (#20405)
* chore(deps): group electron in Renovate config

* add comment
2026-04-28 12:22:57 -04:00
Brandon Treston
6d42bbfbe5
[PM-34775] Generate Invite Link Lib and API Service (#20301)
* Scaffold generate invite link lib, api service WIP

* add missing properties

* refresh lock file

* revert lockfile

* lock file

* clean up lock file (used wrong node version)

* fix lock file

* clean up

* more lockfile issues
2026-04-28 11:54:20 -04:00
Vince Grassia
e7a6eb7dca
Fix Slack webhook (#20416) 2026-04-28 10:52:03 -04:00
gitclonebrian
24457b7bca
[FIX] Replaced hard coded auth key name with variable from AKV (#20406) 2026-04-28 11:26:48 +02:00
Vince Grassia
ed88e51efc
Remove legacy failure check job (#20408) 2026-04-28 09:50:11 +02:00
Vince Grassia
2e835e463e
Update Publish CLI Workflow with fixes for installing the latest NPM (#20354) 2026-04-27 18:24:16 -04:00
Vince Grassia
c2c7d328eb
Change Choco API Key secret name (#20396) 2026-04-27 17:15:13 -04:00
Vince Grassia
3371c834dd
Move truncate logic to right before the image_tag is output (#20335) 2026-04-22 17:09:23 +00:00
renovate[bot]
118057e2a1
[deps]: Update nrwl/nx-set-shas action to v5 (#19856)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2026-04-21 20:23:21 +02:00
Todd Martin
85aa612fa2
chore(deps): Move Jest dependency ownership to Platform 2026-04-21 09:42:06 -04:00
Daniel García
dc888f9acc
[PM-33315] Create @bitwarden/logging (#20197)
* [PM-33315] Create @bitwarden/logging

* Reorder tsconfig, fix tests
2026-04-21 11:48:03 +02:00
neuronull
4feacb5982
SSH Agent v2: add Unix socket listener (#20046) 2026-04-20 08:09:06 -06:00
Vince Grassia
e021979718
Add dev tag to GHCR (#20234) 2026-04-17 14:35:47 +00:00
aikido-autofix[bot]
83202444e1
fix(security): autofix Template Injection in GitHub Workflows Action (#20114)
Co-authored-by: aikido-autofix[bot] <119856028+aikido-autofix[bot]@users.noreply.github.com>
2026-04-16 12:02:49 -07:00
cd-bitwarden
a5ef32620c
enable jest/no-alias-methods (#20187)
* enable jest/no-alias-methods

Added eslint-plugin-jest with jest/no-alias-methods rule to enforce canonical Jest assertion method names (e.g., toHaveBeenCalled instead of toBeCalled).

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>

* enable jest/no-alias-methods

Added eslint-plugin-jest with jest/no-alias-methods rule to enforce canonical Jest assertion method names (e.g., toHaveBeenCalled instead of toBeCalled).

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>

* lint fixes

* lint fixes

* removing claude file

---------

Co-authored-by: Claude Haiku 4.5 <noreply@anthropic.com>
2026-04-16 18:07:49 +02:00
Isaiah Inuwa
becc7ed4e1
Add Skunkworks as co-owners of native passkeys (#20184) 2026-04-16 05:34:55 -05:00
Colton Hurst
2af76c98a5
DN Team Codeowners Rename (#19595)
* codeowners update, rename for the dn team

* Address missed spots

* Move DN lines down
2026-04-15 08:54:32 -04:00
renovate[bot]
afe3242db8
[deps]: Update dtolnay/rust-toolchain digest to 29eef33 (#19841)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2026-04-15 10:07:16 +00:00
Vince Grassia
b8230772b4
Fix GHCR logic (#20163) 2026-04-15 11:56:29 +02:00