Commit Graph

21931 Commits

Author SHA1 Message Date
Bernd Schoolmann
d3212ad1fe
Fix flatpak auto-start (#21039)
Some checks failed
Scan / Check PR run (push) Has been cancelled
Testing / Run typechecking (push) Has been cancelled
Testing / Run tests - ${{ matrix.test-group.name }} (map[artifact:jest-coverage-browser junit:junit-browser.xml name:Browser paths:apps/browser bitwarden_license/bit-browser]) (push) Has been cancelled
Testing / Run tests - ${{ matrix.test-group.name }} (map[artifact:jest-coverage-cli junit:junit-cli.xml name:CLI paths:apps/cli bitwarden_license/bit-cli]) (push) Has been cancelled
Testing / Run tests - ${{ matrix.test-group.name }} (map[artifact:jest-coverage-desktop junit:junit-desktop.xml name:Desktop paths:apps/desktop]) (push) Has been cancelled
Testing / Run tests - ${{ matrix.test-group.name }} (map[artifact:jest-coverage-libs junit:junit-libs.xml name:Libs paths:libs bitwarden_license/bit-common]) (push) Has been cancelled
Testing / Run tests - ${{ matrix.test-group.name }} (map[artifact:jest-coverage-web junit:junit-web.xml name:Web paths:apps/web bitwarden_license/bit-web]) (push) Has been cancelled
Testing / Run Rust tests on ${{ matrix.os }} (macos-14) (push) Has been cancelled
Testing / Run Rust tests on ${{ matrix.os }} (ubuntu-22.04) (push) Has been cancelled
Testing / Run Rust tests on ${{ matrix.os }} (windows-2022) (push) Has been cancelled
Testing / Rust Coverage (push) Has been cancelled
Scan / Checkmarx (push) Has been cancelled
Scan / Sonar (push) Has been cancelled
Testing / Upload to Codecov (push) Has been cancelled
Testing / Run tests (push) Has been cancelled
2026-06-04 21:18:52 +09:00
Bernd Schoolmann
4ee78be61d
[PM-38547] Fix missing Flatpak desktop icon (#21040)
* Add app icon to flatpak manifest

* Remove 1024x1024 icon

* Fix startup wm class
2026-06-04 14:13:35 +02:00
Bernd Schoolmann
b4cfabbcc6
Add rust desktop debugger support (#21036) 2026-06-04 11:38:44 +02:00
Nik Gilmore
20a3d48e6a
[PM-33933] Update autofill dialog for 'never' match setting (#20189)
* [PM-33933] Update autofill dialog for 'never' match setting

* Fix bug where the matching URI isn't the 'never' URI
2026-06-03 17:51:52 -04:00
Jackson Engstrom
39021a4225
Updates attachment file write to use path.basename (#20790) 2026-06-03 13:46:25 -07:00
Leslie Tilton
d390114812
[PM-38522] Fix styling of new admin welcome dialog text (#21025)
* Fix styling of new admin welcome dialog text

* Prefer removing bitTypography instead of ! on styles
2026-06-03 15:27:55 -05:00
Daniel Riera
06f7747a82
[PM-36277]Save login notification not appearing on Facebook (#20814)
* WIP parking changes, currently created a small helper for notifications which checks if we should defer notifications due to passkey UI

* remove isCredentialRequestInProgress, update tests, early return on null activeRequest in shouldDeferVaultNotification

* preserve isCredentialRequestInProgress
2026-06-03 14:10:31 +00:00
Bernd Schoolmann
32507c1e0b
[BEEEP] [PM-38497] Dev-ex: Add attach VSCode debugger to desktop, web configs (#21016)
* Add attach debugger configs for vscode

* Fix desktop not starting
2026-06-03 19:33:05 +09:00
Bernd Schoolmann
d802b5af0b
[PM-38405] Fix SDK ref leaking out of scope and add eslint rule (#20999)
* Fix SDK ref leaking out of scope and add eslint rule

* Prettier
2026-06-03 17:51:57 +09:00
renovate[bot]
2924ebc80f
[deps] Platform: Update Rust crate serde_with to v3.20.0 (#18712)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Derek Nance <dnance@bitwarden.com>
2026-06-02 15:41:55 -05:00
github-actions[bot]
74d2c61dc3
Bumped client version(s) (#20940)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Addison Beck <github@addisonbeck.com>
2026-06-02 20:15:58 +00:00
neuronull
034a8de76f
Remove cargo-deny check from the pre-commit hooks (#21005) 2026-06-02 13:23:16 -06:00
Jordan Aasen
0ef50abdf6
[PM-34615] - add ability to toggle interstitial prompts (#20293)
* add flag to disable all interstitial prompts

* remove changes to search service

* fix type error

* check for auto confirm and enforce data ownership

* fix type error

* create ServerSettingsResponse
2026-06-02 11:30:59 -07:00
Jordan Aasen
8b48304c99
[PM-31084] - migrate badge to chip-action in vault components (#20606)
* migrate badge to chip

* add type="button"

* fix test

* add missing type attrs

* remove file
2026-06-02 11:30:08 -07:00
adudek-bw
f9c569379c
Add new SendApiServer that uses the SDK (#20170)
* Add new SendApiServer that uses the SDK
2026-06-02 14:19:45 -04:00
blackwood
f0bc8d0c46
[PM-35196] Mutation memory management (#20871)
* pass addedElements to checkForNewShadowRoots

* Fix checkForNewShadowRoots latch and nested-shadow traversal

Two bugs in checkForNewShadowRoots, addressed together because they share
the function and the test surface:

1. pageContainsShadowDom resolved at init() and never re-evaluated. On
   sites that attach shadow DOM after init (e.g., hbomax.com — SPAs that
   boot their custom-element renderers post-LOAD), the short-circuit
   blocked all detection for the rest of the session.

2. The narrow scan used el.querySelectorAll("*"), which does not pierce
   shadow boundaries. A shadow host nested inside another shadow root was
   invisible to the scan even when the latch was on.

Changes:

- Narrow the latch short-circuit: fires only when both
  pageContainsShadowDom is false AND addedElements is empty.
- markShadowDomPresent: a named, one-way sticky-ratchet transition that
  flips the latch when the narrow scan finds a root post-init.
- scanForNewShadowRootInSubtree: a depth-bounded recursive helper that
  pierces nested shadow boundaries (MAX_DEEP_QUERY_RECURSION_DEPTH = 4).
- pendingMutationAddedElements: now Set<Element>; isConnected filter at
  the debounced flush skips dead trees.

* Ancestor suppression and set management.

* Swap MutationRecord[][] for el->set<attr>; swap-on-drain, clear maps, clear shadow-root candidate on overflow and expose stats.

* Short-circuit checkMutationsInShadowRoots when pageContainsShadowDom is false

* Narrow requirePageDetailsUpdate to flag-only; schedule in debounce wrapper

* Collapse observedShadowRoots WeakSet into knownShadowRoots Set

* Gate new-shadow-root detection on addedNodes.length > 0

* Reap detached shadow roots from knownShadowRoots in the drain

* Instrument observer hot paths with stopwatch and fieldsReaped counter

* Remove autofill observer instrumentation.

* Reap unconditionally since shadow hosts may obscure mutated nodes.

* De-abbreviate; reap->purge; explanatory comment on cap.

* Revert "Reap unconditionally since shadow hosts may obscure mutated nodes."

This reverts commit 6637bfd65c.

* Unconditionally purge in processMutations.

---------

Co-authored-by: addisonbeck <github@addisonbeck.com>
2026-06-02 14:17:43 -04:00
adudek-bw
5b04116e78
[PM-38400] Fix avoid ambiguous character bug (#20953)
* Fix avoid ambiguous character bug

* fix tests
2026-06-02 13:46:37 -04:00
Jonathan Prusik
9c7c9ab75b
let the browser client assemble the targeting rules manifest.json URI (#21001) 2026-06-02 13:20:51 -04:00
neuronull
f512157768
Add cargo deny ignore RUSTSEC-2026-0153 (#21003) 2026-06-02 16:10:43 +00:00
Konrad
13a1ed21e8
Remove unused strings (#20608)
Co-authored-by: Daniel James Smith <2670567+djsmith85@users.noreply.github.com>
2026-06-02 15:12:10 +00:00
Addison Beck
a7e85fbc82
refactor(platform): migrate Region enum to const object per ADR-0025 (#20887) 2026-06-02 11:09:23 -04:00
✨ Audrey ✨
1154946ac3
[PM-38243] introduce point-in-time performance metrics (#20888) 2026-06-02 10:46:18 -04:00
Nick Krantz
e926d5c749
[PM-38185] Safari numeric values translations (#20964)
* fix safari bug for numeric values in translation placeholders

* replace strict types - accidental removal
2026-06-02 09:08:51 -05:00
Brandon Treston
29d2eef4ec
[PM-36406] Edit member dialog (#20868)
* add edit member dialog, refactored to be ts-strict from member-dialog component

* clean up

* fix dialog selector pattern

* remove feature flag logic

* clean up, fix type error

* fix circular dependency, fix dialog directive

* fix remove user

* refactor nested-checkbox, add story

* update member-access-report to use new member edit component
2026-06-02 09:51:28 -04:00
Bryan Cunningham
48c32fffe7
[PM-37948] Add back missing desktop shortcuts (#20942) 2026-06-02 09:45:39 -04:00
Oscar Hinton
6f4b7c2c36
[PM-23585] Migrate desktop settings dialog to CL (#20230)
Migrates the desktop settings dialog to use the modern dialog system with tabs. It also migrates all inputs to use proper design system components.
2026-06-02 13:15:22 +00:00
Bernd Schoolmann
d4acb9e67e
[PM-37875] Split out crypto verification UI (#20856)
* Extract user crypto dialog to ui module

* Fix build

* Prettier

* Fix DI injection
2026-06-02 08:13:39 -05:00
Addison Beck
9bcfa83d1d
chore(platform): add FedRampGovRegion to client feature flag enum (#20880)
Declares FeatureFlag.FedRampGovRegion = "fedramp-gov-region" in the Platform
section of the feature flag enum and sets its default to false in
DefaultFeatureFlagValue. Aligns with the server-side FeatureFlagKeys.FedRampGovRegion
constant added in the companion server task.

Without this constant, the client has no typed reference to the flag key and
cannot read its value from the GET /config response.
2026-06-02 08:25:03 -04:00
Eli Grubb
db88f20f6e
[PM-30146] Support key rotation for TDE users (#20938) 2026-06-01 21:38:33 -06:00
Jordan Aasen
7ed5638c29
fix onboarding (#20921) 2026-06-01 17:03:42 -07:00
Jared Snider
82246bea68
PM-38423 - FIx unsavedSendEditsGuard not handling null component emission on logout while component is active. (#20967) 2026-06-01 20:03:11 -04:00
github-actions[bot]
157134f500
Bumped client version(s) (#20950)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Todd Martin <106564991+trmartin4@users.noreply.github.com>
2026-06-01 16:57:55 -04:00
bw-ghapp[bot]
8108f172e4
Autosync the updated translations (#20692)
Co-authored-by: bw-ghapp[bot] <178206702+bw-ghapp[bot]@users.noreply.github.com>
2026-06-01 22:34:50 +02:00
bw-ghapp[bot]
b7a1047a62
Autosync the updated translations (#20905)
Co-authored-by: bw-ghapp[bot] <178206702+bw-ghapp[bot]@users.noreply.github.com>
2026-06-01 21:51:26 +02:00
Bernd Schoolmann
7574d3859b
[BEEEP] [PM-37492] Make jest tests faster 2026-06-01 14:34:04 -05:00
Ian Hildebrand
d24baa04b5
[PM-31854] fix: simplify switching unlock methods (#18826)
* fix: simplify switching unlock methods

* switching is now unified across PIN/master-password/biometrics, and only
biometrics is “swap + trigger” by design

* Removed redundant local state update in the child PIN swap click handler

* Address unlock method review feedback

* Format master password lock component

* bad merge

* bad merge - merged the other way around

* fix tests after merge

---------

Co-authored-by: Maciej Zieniuk <167752252+mzieniukbw@users.noreply.github.com>
Co-authored-by: Maciej Zieniuk <mzieniuk@bitwarden.com>
2026-06-01 11:54:02 -06:00
Oscar Hinton
60547fd34e
Desktop UI Cleanup milestone 3 & 4 (#20266)
* Desktop UI Cleanup milestone 3 & 4

* Remove archive badge from item-details-v2

* Fix test
2026-06-01 10:53:41 -07:00
Jordan Aasen
2fb6d447d8
[PM-36534] - fixes to coachmarks (#20533)
* fixes to spotlight and coachmarks

* remove viewportMargin

* revert change to IN lang

* remove spotlightTargetSelector
2026-06-01 10:28:00 -07:00
Nick Krantz
b16d99dafc
[PM-37798] Fix bank account section label to show "Bank account details" (#20779) 2026-06-01 11:13:51 -05:00
bw-ghapp[bot]
873d421607
Autosync the updated translations (#20691)
Co-authored-by: bw-ghapp[bot] <178206702+bw-ghapp[bot]@users.noreply.github.com>
2026-06-01 17:02:51 +02:00
Isaac Ivins
b1d4f6c4d8
[CL-965] update spinner component (#19017)
* split component - adjusted inputs

* wip - contrast variant not working

* added minimal tests and docs

* updated <bit-spinner /> usage in comp lib

* improving documentation to make sense

* added contrast soft color, updated variant

* addressing QA feedback

* fixed formatting issue and small -> sm

* split component - adjusted inputs

* wip - contrast variant not working

* added minimal tests and docs

* updated <bit-spinner /> usage in comp lib

* improving documentation to make sense

* added contrast soft color, updated variant

* addressing QA feedback

* fixed formatting issue and small -> sm

* pulled main - fixed conflicts

* updated docs, fixed conflicts, PR feedback

* fixed stories - removed unused computed val

* added missing display declaration to host elmt

* unify secondary text, documentation updates

* addressing Tech Debt bot feedback

* simplify generics

* export spinner lockup

* fix spinner misalignment

* fix slot documentation

* simplify css and update docs

---------

Co-authored-by: Bryan Cunningham <bryan.cunningham@me.com>
2026-06-01 10:18:46 -04:00
Bernd Schoolmann
1ad0d902b2
[Shared Unlock] [PM-35083] Add shared unlock typescript drivers and services (#20589)
* Add shared unlock TS services

* Add newline

* Small cleanup

* Fix type error

* Fix type issue

* Eslint and prettier fixes

* Cleanup

* Prevent eslint error

* Prettier

* Add tests

* Cleanup

* Fix type issue

* Cleanup

* Implement basic version of flagged biometrics ipc over sdk ipc

* Move code

* Noop ipc service

* Clean up unlock service

* Undo change to spec ts

* Rename unlock decrypted key

* Remove unused var

* Remove unused import

* Prettier

* Fix eslint

* Ensure connected

* Undo changes to electron key service

* Newline

* Newline

* Remove biometrics.ts

* Fix

* Use unlock service for unlocking on shared unlock

* Cleanup comment

* Cleanup

* Prettier and eslint cleanup

* Prettier

* Fix test

* Eslint

* Fix types

* Remove log

* Remove service

* Remove unused file

* Cleanup

* Fix DI

* Set unlock service on biometric service

* Address feedback

* Await floating promise

* Prettier

* Convert driver to class

* Relative imports

* Relative imports

* Remove unused code

* Non null assertion
2026-06-01 09:26:21 -04:00
bw-ghapp[bot]
59e169053d
Update sdk-internal to 0.2.0-main.798 (#20937)
Some checks failed
Scan / Check PR run (push) Has been cancelled
Testing / Run typechecking (push) Has been cancelled
Testing / Run tests - ${{ matrix.test-group.name }} (map[artifact:jest-coverage-browser junit:junit-browser.xml name:Browser paths:apps/browser bitwarden_license/bit-browser]) (push) Has been cancelled
Testing / Run tests - ${{ matrix.test-group.name }} (map[artifact:jest-coverage-cli junit:junit-cli.xml name:CLI paths:apps/cli bitwarden_license/bit-cli]) (push) Has been cancelled
Testing / Run tests - ${{ matrix.test-group.name }} (map[artifact:jest-coverage-desktop junit:junit-desktop.xml name:Desktop paths:apps/desktop]) (push) Has been cancelled
Testing / Run tests - ${{ matrix.test-group.name }} (map[artifact:jest-coverage-libs junit:junit-libs.xml name:Libs paths:libs bitwarden_license/bit-common]) (push) Has been cancelled
Testing / Run tests - ${{ matrix.test-group.name }} (map[artifact:jest-coverage-web junit:junit-web.xml name:Web paths:apps/web bitwarden_license/bit-web]) (push) Has been cancelled
Testing / Run Rust tests on ${{ matrix.os }} (macos-14) (push) Has been cancelled
Testing / Run Rust tests on ${{ matrix.os }} (ubuntu-22.04) (push) Has been cancelled
Testing / Run Rust tests on ${{ matrix.os }} (windows-2022) (push) Has been cancelled
Testing / Rust Coverage (push) Has been cancelled
Scan / Checkmarx (push) Has been cancelled
Scan / Sonar (push) Has been cancelled
Testing / Upload to Codecov (push) Has been cancelled
Testing / Run tests (push) Has been cancelled
Co-authored-by: bw-ghapp[bot] <178206702+bw-ghapp[bot]@users.noreply.github.com>
2026-06-01 17:10:56 +09:00
Bernd Schoolmann
ceb7cd4a5f
[Shared Unlock] [PM-35083] Implement biometrics over sdk IPC (#20689)
* Implement basic version of flagged biometrics ipc over sdk ipc

* Move code

* Noop ipc service

* Clean up unlock service

* Undo change to spec ts

* Rename unlock decrypted key

* Remove unused var

* Remove unused import

* Prettier

* Fix eslint

* Ensure connected

* Undo changes to electron key service

* Newline

* Newline

* Cleanup

* Prettier and eslint cleanup

* Prettier

* Fix test

* Eslint

* Fix types

* Remove log

* Remove service

* Remove unused file

* Cleanup

* Fix DI

* Set unlock service on biometric service

* Address feedback

* Await floating promise

* Prettier

* Make biometrics driver a class

* Add error log
2026-06-01 09:00:19 +02:00
Leslie Tilton
d07a6acf62
[PM-37079] Fix applicationName empty save and fetch in Access Intelligence (#20886)
* Fix applicationName empty save and fetch in access intelligence

* Trim fallback uri in getTrimmedCipherUris. Added test cases
2026-05-29 21:00:20 -05:00
Jackson Engstrom
75caebfb95
[PM-38113] In AC, when item filter is selected and user add new item, it does not default the creation form to selected item type (#20901)
* Adds fallback for when a cipher type isn't passed

* adds tests
2026-05-29 13:01:16 -07:00
Todd Martin
5e09251cee
feat(install-tab): Managed install check for displaying getting started tab
* Propose new managed install check.

* Refactors.

* Inverted the logic to be positive.

* Added Development to allowList, with override.
2026-05-29 15:52:56 -04:00
Jackson Engstrom
7b47aeb974
[PM-23564] Item view shows removed attachment/does not show added attachment temporarily (#20884)
* adds cipher refresh to cancel

* adds tests for new code path
2026-05-29 11:38:07 -07:00
Jackson Engstrom
568faee0ea
[PM-27679] Remove flagged logic from clients and clients feature flag (#20609) 2026-05-29 11:35:17 -07:00
Mike Amirault
eec6bc1a31
[PM-37175] Preserve individual vault export folders when importing to My Items (#20883) 2026-05-29 13:54:58 -04:00