mirror of
https://github.com/zulip/zulip.git
synced 2026-07-06 21:18:58 +08:00
dcbb2a78ca
JsonableError has two major benefits over json_error: * It can be raised from anywhere in the codebase, rather than being a return value, which is much more convenient for refactoring, as one doesn't potentially need to change error handling style when extracting a bit of view code to a function. * It is guaranteed to contain the `code` property, which is helpful for API consistency. Various stragglers are not updated because JsonableError requires subclassing in order to specify custom data or HTTP status codes.
64 lines
2.1 KiB
Python
64 lines
2.1 KiB
Python
import orjson
|
|
from django.core.exceptions import ValidationError
|
|
from django.db import transaction
|
|
from django.http import HttpRequest, HttpResponse
|
|
from django.utils.translation import gettext as _
|
|
|
|
from zerver.decorator import REQ, has_request_variables
|
|
from zerver.lib.actions import do_add_submessage, verify_submessage_sender
|
|
from zerver.lib.exceptions import JsonableError
|
|
from zerver.lib.message import access_message
|
|
from zerver.lib.response import json_success
|
|
from zerver.lib.validator import check_int, validate_poll_data, validate_todo_data
|
|
from zerver.lib.widget import get_widget_type
|
|
from zerver.models import UserProfile
|
|
|
|
|
|
# transaction.atomic is required since we use FOR UPDATE queries in access_message.
|
|
@transaction.atomic
|
|
@has_request_variables
|
|
def process_submessage(
|
|
request: HttpRequest,
|
|
user_profile: UserProfile,
|
|
message_id: int = REQ(json_validator=check_int),
|
|
msg_type: str = REQ(),
|
|
content: str = REQ(),
|
|
) -> HttpResponse:
|
|
message, user_message = access_message(user_profile, message_id, lock_message=True)
|
|
|
|
verify_submessage_sender(
|
|
message_id=message.id,
|
|
message_sender_id=message.sender_id,
|
|
submessage_sender_id=user_profile.id,
|
|
)
|
|
|
|
try:
|
|
widget_data = orjson.loads(content)
|
|
except orjson.JSONDecodeError:
|
|
raise JsonableError(_("Invalid json for submessage"))
|
|
|
|
widget_type = get_widget_type(message_id=message.id)
|
|
|
|
is_widget_author = message.sender_id == user_profile.id
|
|
|
|
if widget_type == "poll":
|
|
try:
|
|
validate_poll_data(poll_data=widget_data, is_widget_author=is_widget_author)
|
|
except ValidationError as error:
|
|
raise JsonableError(error.message)
|
|
|
|
if widget_type == "todo":
|
|
try:
|
|
validate_todo_data(todo_data=widget_data)
|
|
except ValidationError as error:
|
|
raise JsonableError(error.message)
|
|
|
|
do_add_submessage(
|
|
realm=user_profile.realm,
|
|
sender_id=user_profile.id,
|
|
message_id=message.id,
|
|
msg_type=msg_type,
|
|
content=content,
|
|
)
|
|
return json_success()
|