zulip/tools/lib
Priyank Patel e834439d82 provision: Do service <service-name> start instead of restart.
Doing service memcached start instead of restart fixed an issue on
focal build in GitHub actions, where it exits with code 1 when it
is done twice.It is done first in Install Dependencies step and then
again in last step where we call tools/ci/setup-backend again which
runs provision.

Furthermore, I don't belive there is a technical reason we use
restart over start; rather I think it was just a random choice with
the intend to just start the services in CI. I traced the code back
to commit 1f2f497cab if it helps.
Looking at the source code of memcached, the step that's failing is:
  start-stop-daemon --stop --quiet --oknodo --pidfile $PIDFILE
which is equivilent to: service memcached stop, we can rule out the
service memcache start since it works. Ideally, we do figure out and
solve the issue of why memcached fails when executing service
memcached stop but I am not equipped with debugging it. And this
workaround seems reasonable rather than a "hacky" solution.

For the relevant code in memcached see:
https://github.com/memcached/memcached/blob/master/scripts/memcached-init.

Finally, the change to the rest of services is for consistency.
2020-07-06 18:09:15 -07:00
..
__init__.py Extract tools/lib/template_parser.py. 2016-08-01 16:27:50 -07:00
capitalization.py i18n: Mark notification bot message in notify_new_user for translation. 2020-06-26 14:57:16 -07:00
git-tools.bash tools: Give require_clean_work_tree our nice UI touches. 2020-04-06 17:52:10 -07:00
gitlint-rules.py python: Sort imports with isort. 2020-06-11 16:45:32 -07:00
html_branches.py html_branches: Fix strict_optional errors. 2020-07-06 11:25:48 -07:00
pretty_print.py python: Manually convert more percent-formatting to f-strings. 2020-06-14 23:27:22 -07:00
provision_inner.py provision: Don't run migrations on zulip db in CircleCI. 2020-06-16 15:37:32 +05:30
provision.py provision: Do service <service-name> start instead of restart. 2020-07-06 18:09:15 -07:00
sanity_check.py python: Sort imports with isort. 2020-06-11 16:45:32 -07:00
template_parser.py python: Convert more percent formatting to Python 3.6 f-strings. 2020-06-14 23:27:22 -07:00
test_script.py python: Sort imports with isort. 2020-06-11 16:45:32 -07:00
test_server.py test_server: Double the timeout amount to avoid flakes. 2020-06-22 12:30:32 -07:00