mirror of
https://github.com/zulip/zulip.git
synced 2026-07-18 21:04:19 +08:00
98a4e87e1d
Various pieces of our thumbor-based thumbnailing system were already merged; this adds the remaining pieces required for it to work: * a THUMBOR_URL Django setting that controls whether thumbor is enabled on the Zulip server (and if so, where thumbor is hosted). * Replaces the overly complicated prototype cryptography logic * Adds a /thumbnail endpoint (supported both on web and mobile) for accessing thumbnails in messages, designed to support hosting both external URLs as well as uploaded files (and applying Zulip's security model for access to thumbnails of uploaded files). * Modifies bugdown to, when THUMBOR_URL is set, render images with the `src` attribute pointing /thumbnail (to provide a small thumbnail for the image), along with adding a "data-original" attribute that can be used to access the "original/full" size version of the image. There are a few things that don't work quite yet: * The S3 backend support is incomplete and doesn't work yet. * The error pages for unauthorized access are ugly. * We might want to rename data-original and /thumbnail?size=original to use some other name, like "full", that better reflects the fact that we're potentially not serving the original image URL.
70 lines
2.2 KiB
Python
70 lines
2.2 KiB
Python
# -*- coding: utf-8 -*-
|
|
import base64
|
|
import os
|
|
import sys
|
|
import urllib
|
|
from django.conf import settings
|
|
from libthumbor import CryptoURL
|
|
|
|
ZULIP_PATH = os.path.dirname(os.path.dirname(os.path.dirname(os.path.abspath('__file__'))))
|
|
sys.path.append(ZULIP_PATH)
|
|
|
|
from zthumbor.loaders.helpers import (
|
|
THUMBOR_S3_TYPE, THUMBOR_LOCAL_FILE_TYPE, THUMBOR_EXTERNAL_TYPE
|
|
)
|
|
from zerver.lib.camo import get_camo_url
|
|
|
|
def is_thumbor_enabled() -> bool:
|
|
return settings.THUMBOR_URL != ''
|
|
|
|
def get_source_type(url: str) -> str:
|
|
if not url.startswith('/user_uploads/'):
|
|
return THUMBOR_EXTERNAL_TYPE
|
|
|
|
local_uploads_dir = settings.LOCAL_UPLOADS_DIR
|
|
if local_uploads_dir:
|
|
return THUMBOR_LOCAL_FILE_TYPE
|
|
return THUMBOR_S3_TYPE
|
|
|
|
def generate_thumbnail_url(path: str, size: str='0x0') -> str:
|
|
if not (path.startswith('https://') or path.startswith('http://')):
|
|
path = '/' + path
|
|
|
|
if not is_thumbor_enabled():
|
|
if path.startswith('http://'):
|
|
return get_camo_url(path)
|
|
return path
|
|
|
|
# Ignore thumbnailing for static resources.
|
|
if path.startswith('/static/'):
|
|
return path
|
|
|
|
source_type = get_source_type(path)
|
|
if source_type == THUMBOR_EXTERNAL_TYPE:
|
|
url = path
|
|
else:
|
|
url = path[len('/user_uploads/'):]
|
|
|
|
safe_url = base64.urlsafe_b64encode(url.encode()).decode('utf-8')
|
|
image_url = '%s/source_type/%s' % (safe_url, source_type)
|
|
width, height = map(int, size.split('x'))
|
|
crypto = CryptoURL(key=settings.THUMBOR_KEY)
|
|
encrypted_url = crypto.generate(
|
|
width=width,
|
|
height=height,
|
|
smart=True,
|
|
filters=['no_upscale()'],
|
|
image_url=image_url
|
|
)
|
|
|
|
if settings.THUMBOR_URL == 'http://127.0.0.1:9995':
|
|
# If THUMBOR_URL is the default then thumbor is hosted on same machine
|
|
# as the Zulip server and we should serve a relative URL.
|
|
# We add a /thumbor in front of the relative url because we make
|
|
# use of a proxy pass to redirect request internally in Nginx to 9995
|
|
# port where thumbor is running.
|
|
thumbnail_url = '/thumbor' + encrypted_url
|
|
else:
|
|
thumbnail_url = urllib.parse.urljoin(settings.THUMBOR_URL, encrypted_url)
|
|
return thumbnail_url
|