mirror of
https://github.com/zulip/zulip.git
synced 2026-07-09 21:21:47 +08:00
1c8bf4f050
We should make `get_by_user_id` type-safe in the sense that it's caller should not expect undefined values and hence it's caller should not need to validate the user ids. To do this I extracted a method `maybe_get_user_by_id` which is type-unsafe version of this function which will allow undefined values and will behave exactly the same as the previous version. So the callers which expects the undefined values from this function should use this new function `maybe_get_user_by_id`. Probably about half of these callers are implicitly iterating through all users in the people.js data set and thus by construction should never fail, but it's simpler to just convert all existing callers than do that audit.
56 lines
1.5 KiB
JavaScript
56 lines
1.5 KiB
JavaScript
import {page_params} from "./page_params";
|
|
import * as people from "./people";
|
|
|
|
let user_id_set;
|
|
|
|
export function initialize_with_current_user() {
|
|
const current_user_id = page_params.user_id;
|
|
user_id_set = new Set();
|
|
user_id_set.add(current_user_id);
|
|
}
|
|
|
|
export function sorted_user_ids() {
|
|
const users = people.get_users_from_ids([...user_id_set]);
|
|
people.sort_but_pin_current_user_on_top(users);
|
|
return users.map((user) => user.user_id);
|
|
}
|
|
|
|
export function get_all_user_ids() {
|
|
const potential_subscribers = people.get_realm_users();
|
|
const user_ids = potential_subscribers.map((user) => user.user_id);
|
|
// sort for determinism
|
|
user_ids.sort((a, b) => a - b);
|
|
return user_ids;
|
|
}
|
|
|
|
export function get_principals() {
|
|
// Return list of user ids which were selected by user.
|
|
return [...user_id_set];
|
|
}
|
|
|
|
export function get_potential_subscribers() {
|
|
const potential_subscribers = people.get_realm_users();
|
|
return potential_subscribers.filter((user) => !user_id_set.has(user.user_id));
|
|
}
|
|
|
|
export function must_be_subscribed(user_id) {
|
|
return !page_params.is_admin && user_id === page_params.user_id;
|
|
}
|
|
|
|
export function add_user_ids(user_ids) {
|
|
for (const user_id of user_ids) {
|
|
if (!user_id_set.has(user_id)) {
|
|
const user = people.maybe_get_user_by_id(user_id);
|
|
if (user) {
|
|
user_id_set.add(user_id);
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
export function remove_user_ids(user_ids) {
|
|
for (const user_id of user_ids) {
|
|
user_id_set.delete(user_id);
|
|
}
|
|
}
|