mirror of
https://github.com/zulip/zulip.git
synced 2026-07-12 21:04:41 +08:00
64023fc563
The code in maybe_send_to_registration incorrectly used the `get_realm_from_request` function to fetch the subdomain. This usage was incorrect in a way that should have been irrelevant, because that function only differs if there's a logged-in user, and in this code path, a user is never logged in (it's the code path for logged-out users trying to sign up). This this bug could confuse unit tests that might run with a logged-in client session. This made it possible for several of our GitHub auth tests to have a totally invalid subdomain value (the root domain). Fixing that bug in the tests, in turn, let us delete a code path in the GitHub auth backend logic in `backends.py` that is impossible in production, and had just been left around for these broken tests. |
||
|---|---|---|
| .. | ||
| jinja2 | ||
| __init__.py | ||
| backends.py | ||
| dev_settings.py | ||
| dev_urls.py | ||
| email_backends.py | ||
| legacy_urls.py | ||
| prod_settings_template.py | ||
| settings.py | ||
| slack_importer_test_settings.py | ||
| terms.md.template | ||
| test_settings.py | ||
| urls.py | ||
| wsgi.py | ||