zulip/zerver
Tim Abbott c88163eea8 auth: Make "Continue to registration" actually register you.
The main change here is to send a proper confirmation link to the
frontend in the `confirm_continue_registration` code path even if the
user didn't request signup, so that we don't need to re-authenticate
the user's control over their email address in that flow.

This also lets us delete some now-unnecessary code: The
`invalid_email` case is now handled by HomepageForm.is_valid(), which
has nice error handling, so we no longer need logic in the context
computation or template for `confirm_continue_registration` for the
corner case where the user somehow has an invalid email address
authenticated.

We split one GitHub auth backend test to now cover both corner cases
(invalid email for realm, and valid email for realm), and rewrite the
Google auth test for this code path as well.

Fixes #5895.
2018-04-22 19:55:05 -07:00
..
lib populate_db: Add new user of "guest" type. 2018-04-20 16:20:00 -07:00
management import: Fix ordering of subdomain availability check. 2018-04-20 10:39:30 -07:00
migrations guest: Add a model field for guest users. 2018-04-20 16:08:29 -07:00
templatetags mypy: Migrate templatetags/minified_js.py to python3.5 annotations. 2018-03-12 11:23:30 -07:00
tests auth: Make "Continue to registration" actually register you. 2018-04-22 19:55:05 -07:00
tornado websockets: Fix race condition in CSRF token initialization. 2018-03-31 09:29:56 -07:00
views auth: Make "Continue to registration" actually register you. 2018-04-22 19:55:05 -07:00
webhooks gitlab: Document the local network security setting. 2018-04-20 08:34:38 -07:00
worker mypy: Remove need for cast by using ConcreteQueueWorker TypeVar. 2018-03-11 15:34:11 -07:00
__init__.py caching: Add configuration class for post-migration cache flushing. 2016-10-27 23:26:34 -07:00
apps.py zerver: Use Python 3 syntax for typing. 2017-11-28 16:49:36 -08:00
context_processors.py cleanup: Remove the legacy Dropbox file upload integration. 2018-04-11 11:39:48 -07:00
decorator.py analytics: Make stats of all realms accessible to server admins. 2018-04-18 11:06:50 -07:00
filters.py zerver: Use Python 3 syntax for typing. 2017-11-28 16:49:36 -08:00
forms.py forms: Fix missing translation tag for disposable emails. 2018-03-15 14:43:40 -07:00
logging_handlers.py test_logging_handlers: Mock out git describe because can be slow. 2018-03-23 18:24:51 -07:00
middleware.py mypy: Rewrite some middleware annotations to use ViewFuncT. 2018-03-17 23:25:05 +00:00
models.py guest: Add a model field for guest users. 2018-04-20 16:08:29 -07:00
signals.py emails: Fix notify_new_login emails have unserializable context. 2017-12-22 16:34:18 -05:00
static_header.txt Update static_header.txt with new license information. 2016-08-13 00:37:21 -07:00
storage.py mypy: Improve typing for ManifestStaticFilesStorage monkeypatch. 2017-12-08 19:00:18 -08:00