CodeCow/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2026-06-24 21:08:25 +08:00
Code Issues Actions 6 Packages Projects Releases Wiki Activity
be21f831a0
zulip/static/js
History
Steve Howell 8530ed0b5e org settings: Make button-clicking code more clear. 
On the "Organization settings" page, we had two Save buttons
for admins that had identical markup.  This was confusing for
people reading the code.  Now the two buttons have different
markup and individual, targeted click handlers (albeit still
calling the same function to do most of the work).

The context of this fix is that I was debugging a
Casper flake where our Casper tests were essentially clicking
on the same button twice.  Depending on the timing,
the second button click could cause a "No changes saved!"
behavior that confused the Casper test.  It is unclear whether
Casper was clicking both buttons here (in which case this fix
is necessary) or the same button twice (in which case this fix
just removes a nasty red herring for debugging).

The code still has the flaw that both buttons basically submit
the same data to the server, despite the appearance on the page
that there are two forms.  The best fix for that is probably
just to move the Language/Notifications stuff to another
panel.  I wanted to avoid touching this code altogether, but
the minor modifications here were necessary to improve the
Capser testing situation.
2018-01-16 13:25:19 -05:00
..
portico /team: Fetch zulip-js repository data. 2018-01-16 12:23:19 -05:00
stats stats: Add per-graph loading indicator 2017-12-13 14:44:28 -06:00
.eslintrc.json Change name of eslintrc file to .eslintrc.json 2016-11-29 08:58:39 -08:00
activity.js right-sidebar: Make Search people input collapsible with search icon. 2018-01-07 15:05:03 -05:00
admin_sections.js org settings: Add framework for User groups page. 2018-01-06 11:50:52 -05:00
admin.js settings: Limit the creation of generic bots. 2018-01-02 18:12:22 -05:00
alert_words_ui.js urls: Change the method for adding alert words from PUT to POST. 2017-09-26 14:00:51 -07:00
alert_words.js Highlight alert words in mentions you send to yourself. 2017-10-12 14:03:36 -07:00
attachments_ui.js user settings: Clean settings.css and fix bug 2017-12-18 10:12:33 -05:00
avatar.js Add size limit for uploading user avatars and realm icons. 2017-03-07 22:13:01 -08:00
blueslip.js docs: Update links from codebase to point to ReadTheDocs. 2017-11-16 10:53:49 -08:00
bot_data.js bots: Add UI to view bot types of existing bots in "Your bots". 2017-06-15 10:08:31 -07:00
channel.js middleware: Use a proper error code on CSRF failure. 2017-07-25 14:02:12 -07:00
click_handlers.js left sidebar: Remove plus icon from the stream bar. 2018-01-09 09:05:23 -05:00
colorspace.js Migrate JS modules to CommonJS style. 2016-12-07 16:11:52 -08:00
common.js passwords: Express the quality threshold as guesses required. 2017-10-08 15:48:44 -07:00
components.js tab-switcher: Switch tabs with left/right arrows. 2017-11-08 18:13:57 -08:00
compose_actions.js compose: Warn users when posting to the #announce stream. 2017-12-20 07:36:50 -05:00
compose_fade.js people.js: Rename realm_get -> get_active_user_for_email. 2017-10-26 09:52:42 -07:00
compose_state.js refactor: new message content -> compose textarea. 2017-11-28 12:53:40 -08:00
compose_ui.js compose: Fix bug in undo operation 2017-12-10 04:10:18 -08:00
compose.js settings: Add "text" option to emoji_set model. 2018-01-02 14:55:01 -05:00
composebox_typeahead.js compose typeahead: Add newline and other terminal_symbols. 2017-12-01 07:17:30 -08:00
condense.js frontend: Simplify saving collapsed/uncollapsed flags. 2017-12-26 09:01:21 -05:00
copy_and_paste.js refactor: new message content -> compose textarea. 2017-11-28 12:53:40 -08:00
custom_markdown.js Remove deprecated jQuery "delegate" function. 2017-07-24 10:47:16 -07:00
debug.js webpack: Move app_debug.js to webpack bundle. 2017-06-13 12:45:40 -07:00
desktop_notifications_panel.js notification-banner: Check if mobile before displaying. 2017-10-20 13:07:40 -07:00
dict.js Add Dict.is_empty(). 2017-04-21 21:59:22 -07:00
drafts.js compose: Notify when drafts are saved. 2017-12-22 10:51:55 -05:00
dynamic_text.js js: Implement DynamicText class. 2017-05-11 17:23:53 -07:00
echo.js local echo: Bypass message.flags array. 2017-12-26 09:01:21 -05:00
emoji_picker.js Move insert_syntax_and_focus() to compose_ui.js. 2017-11-09 09:49:20 -08:00
emoji.js emoji: Allow users to change emoji set. 2017-10-28 10:38:33 -07:00
favicon.js lint: Ban two spaces after comma in JS code. 2017-10-18 10:22:18 -07:00
feature_flags.js Inline feature_flags.use_server_topic_history. 2017-09-26 13:58:54 -07:00
fenced_code.js bugdown: Fix handling of nested fenced math blocks. 2017-11-22 12:19:43 -08:00
filter.js left sidebar: Change Home to All messages. 2017-11-28 15:42:58 -08:00
floating_recipient_bar.js Fix outerHeight to OR with 0 to not produce NaN. 2017-07-27 14:16:57 -07:00
gear_menu.js gear_menu: Fix traceback accessing i18n before it is initialized. 2017-06-02 14:03:56 -07:00
hash_util.js lint: Ban two spaces after comma in JS code. 2017-10-18 10:22:18 -07:00
hashchange.js docs: Update links from codebase to point to ReadTheDocs. 2017-11-16 10:53:49 -08:00
hotkey.js Disable message menu for locally echoed messages. 2017-12-26 09:01:21 -05:00
hotspots.js hotspots.js: Fix timeout millisecond conversion. 2017-09-15 04:14:52 -07:00
input_pill.js input-pill: Wrap "values" in IIFE. 2017-12-20 08:53:27 -05:00
integration_bot_widget.js template context: Give better names to the URLs for the API. 2017-10-30 18:29:29 -07:00
invite.js invite: Update text of success message. 2017-12-19 17:46:36 -08:00
lightbox_canvas.js lightbox_canvas: Fix use of unsupported const. 2017-08-05 16:47:11 -07:00
lightbox.js Fix 'v' hotkey image searching behavior. 2017-12-13 15:14:18 -06:00
list_render.js list_render: Add sorting reversal. 2017-11-01 13:26:40 -07:00
list_util.js Extract list_util.js for navigating lists. 2017-04-05 11:53:52 -07:00
loading.js loading-spinner: Fix improper display in upload avatar setting. 2017-04-06 09:06:14 +05:30
localstorage.js localstorage: Allow regex based delete. 2017-04-26 09:11:44 -07:00
markdown.js markdown: Fix backend rendering regex. 2018-01-09 16:43:22 -05:00
message_edit.js compose: Enable mention syntax when editing messages. 2017-10-12 18:08:32 -07:00
message_events.js Avoid overwriting message.unread for message edits. 2017-12-26 09:01:21 -05:00
message_fetch.js refactor: Upstream calls to set_message_booleans. 2017-12-26 09:01:21 -05:00
message_flags.js Use throttle, not debounce, to "read" messages. 2017-12-26 09:01:21 -05:00
message_list_view.js settings: Add "text" option to emoji_set model. 2018-01-02 14:55:01 -05:00
message_list.js scrolling: Fix out-of-order bug in the message list. 2017-10-11 15:57:11 -07:00
message_live_update.js avatar live updates: Do full re-render. 2017-02-22 22:46:44 -08:00
message_store.js refactor: Delete deprecated message.flags attribute. 2017-12-26 09:01:21 -05:00
message_util.js sending messages: Extract sent_messages.js. 2017-08-01 08:58:56 -07:00
message_viewport.js lint: Ban two spaces after comma in JS code. 2017-10-18 10:22:18 -07:00
muting_ui.js Inline muting_ui.mute_topic and unmute_topic. 2017-10-17 17:41:21 -07:00
muting.js Revert "muting.js: Track muted streams using stream id." 2017-05-17 07:06:32 -07:00
narrow_state.js narrow_state: Make set_compose_defaults return opts. 2017-12-03 14:01:19 -08:00
narrow.js stream narrow: Set message if narrows to never-subscribed private stream. 2018-01-04 16:52:54 -05:00
navigate.js Have home key go to actual first message in the list. 2017-10-03 11:28:28 -07:00
night_mode.js night-mode: Add custom CSS through JS. 2017-11-29 23:06:11 -08:00
notifications.js settings: Remove autoscroll_forever setting. 2018-01-02 10:35:49 -05:00
overlays.js hotkeys: Modify draft toggle behavior. 2017-11-03 15:38:10 -07:00
people.js Calculate gravatar hashes on the webapp client. 2017-11-07 10:36:02 -08:00
pm_conversations.js typeahead: Add pm_conversations module. 2017-06-01 08:05:37 +00:00
pm_list.js js: Remove a few spurious arguments. 2017-08-22 09:37:17 -07:00
pointer.js left sidebar: Change Home to All messages. 2017-11-28 15:42:58 -08:00
popovers.js Disable message menu for locally echoed messages. 2017-12-26 09:01:21 -05:00
presence.js presence: Change "unknown" to "offline". 2017-10-12 10:42:06 -07:00
reactions.js settings: Add "text" option to emoji_set model. 2018-01-02 14:55:01 -05:00
realm_icon.js Add size limit for uploading user avatars and realm icons. 2017-03-07 22:13:01 -08:00
recent_senders.js recent_senders: Add sort by stream message recency. 2017-09-14 07:20:52 -07:00
reload.js docs: Update links from codebase to point to ReadTheDocs. 2017-11-16 10:53:49 -08:00
resize.js settings: Remove autoscroll_forever setting. 2018-01-02 10:35:49 -05:00
rows.js js: Remove a few spurious arguments. 2017-08-22 09:37:17 -07:00
rtl.js eslint: Add and enforce space-in-parens lint rule. 2017-10-06 12:36:59 -07:00
scroll_bar.js Rewrite scrollbar width check to not use jQuery. 2017-08-22 12:50:54 -07:00
search_suggestion.js left sidebar: Change Home to All messages. 2017-11-28 15:42:58 -08:00
search.js eslint: Add and enforce space-in-parens lint rule. 2017-10-06 12:36:59 -07:00
sent_messages.js urls: Move the report endpoints to be API-style routes. 2017-10-17 22:05:56 -07:00
server_events_dispatch.js org settings: Add user group creation functionality. 2018-01-06 11:50:52 -05:00
server_events.js local echo: Bypass message.flags array. 2017-12-26 09:01:21 -05:00
settings_account.js i18n: Translate strings in settings_account.js. 2017-11-07 09:52:20 -08:00
settings_bots.js embedded bots UI: Fix wrong _.each argument order. 2018-01-11 06:30:54 -05:00
settings_display.js settings_display: Change two "!" to one. 2018-01-03 13:29:49 -05:00
settings_emoji.js emoji: Merge the two semantically same tips on the Custom emoji page. 2017-07-21 13:29:27 -07:00
settings_filters.js Change from deprecated $.parseJSON to JSON.parse. 2017-07-27 14:16:57 -07:00
settings_invites.js settings: Show local time instead of UTC in invitations tab. 2017-12-20 07:08:46 -05:00
settings_lab.js settings: Remove autoscroll_forever setting. 2018-01-02 10:35:49 -05:00
settings_muting.js Extract settings_muting.js. 2017-04-06 11:28:36 -07:00
settings_notifications.js user settings: Make "Mobile push notifications always" a subsetting. 2017-09-29 17:58:41 -07:00
settings_org.js org settings: Make button-clicking code more clear. 2018-01-16 13:25:19 -05:00
settings_sections.js admin/settings: Lazy-load Organization sections. 2017-04-17 20:55:42 -07:00
settings_streams.js i18n: Translate deactivation errors in the webapp. 2017-11-07 09:52:20 -08:00
settings_user_groups.js org settings: Add typeahead to user group member inputs. 2018-01-06 11:50:52 -05:00
settings_users.js i18n: Translate deactivation errors in the webapp. 2017-11-07 09:52:20 -08:00
settings.js org settings: Add framework for User groups page. 2018-01-06 11:50:52 -05:00
setup.js Fix outerHeight to OR with 0 to not produce NaN. 2017-07-27 14:16:57 -07:00
socket.js local echo: Remove buggy restart-related code. 2017-07-18 12:03:16 -07:00
stream_color.js Fix various typos. 2017-11-09 16:26:38 +01:00
stream_create.js create stream: Disable announce stream label, not only checkbox. 2018-01-04 16:37:09 -05:00
stream_data.js stream membership: Display add-subscribers option only if user can add. 2018-01-04 16:52:54 -05:00
stream_edit.js stream settings: Restore original stream name in UI on error. 2018-01-04 16:52:54 -05:00
stream_events.js subs: Don't try to update stream settings UI when closed. 2017-10-23 22:44:27 -07:00
stream_list.js left-sidebar: Fix styling of Streams header to not use links. 2018-01-07 15:05:03 -05:00
stream_muting.js ui-refactor: Rename modals.js to overlays.js. 2017-05-29 11:24:46 -07:00
stream_popover.js stream_list: Use data-topic-name for topic names. 2017-08-16 18:03:44 -07:00
stream_sort.js Fix issues with left-sidebar stream search and multiple words. 2017-09-15 00:22:59 -07:00
subs.js stream settings: Update subscription-btn display instant. 2018-01-04 16:52:54 -05:00
tab_bar.js left sidebar: Change Home to All messages. 2017-11-28 15:42:58 -08:00
templates.js templates: Fix typo in error message. 2017-06-26 19:33:25 -04:00
timerender.js user settings: fix uploaded files UI 2017-12-18 10:12:33 -05:00
top_left_corner.js Extract top_left_corner.js. 2017-08-14 13:03:57 -07:00
topic_data.js Add topic_data.get_server_history(). 2017-08-08 17:07:09 -04:00
topic_generator.js hotkeys: Fix "n" key to work inside a muted stream. 2017-08-17 09:01:49 -07:00
topic_list.js left-sidebar: Remove topics help code. 2017-11-15 11:01:33 -08:00
translations.js Revert "i18n: Only load active language." 2017-10-20 10:08:17 -07:00
tutorial.js urls: Move the json/tutorial_status endpoint to be an API-style route. 2017-10-09 15:13:33 -07:00
typeahead_helper.js bot settings: Clear typeahead when renaming a bot 2017-12-13 14:39:53 -06:00
typing_data.js docs: Reorganize developer docs to improve navigation. 2017-11-16 09:45:08 -08:00
typing_events.js docs: Reorganize developer docs to improve navigation. 2017-11-16 09:45:08 -08:00
typing_status.js docs: Reorganize developer docs to improve navigation. 2017-11-16 09:45:08 -08:00
typing.js refactor: new message content -> compose textarea. 2017-11-28 12:53:40 -08:00
ui_init.js right-sidebar: Make Search people input collapsible with search icon. 2018-01-07 15:05:03 -05:00
ui_report.js stream settings: Fix all dead code related to #subscriptions-status. 2018-01-04 11:35:37 -05:00
ui_util.js Extract js/ui_util.js. 2017-03-19 11:05:45 -07:00
ui.js Simplify/unify starring messages from the frontend. 2017-12-26 09:01:21 -05:00
unread_ops.js Use throttle, not debounce, to "read" messages. 2017-12-26 09:01:21 -05:00
unread_ui.js bug: Show the count in the bankruptcy modal. 2017-08-17 23:30:41 -04:00
unread.js refactor: Stop using flags array for unread counts. 2017-12-26 09:01:21 -05:00
upload_widget.js settings ui: Restrict file type for image file pickers. 2017-10-27 10:21:36 -07:00
upload.js refactor: new message content -> compose textarea. 2017-11-28 12:53:40 -08:00
user_events.js user_events: Fix buggy-looking logging code. 2017-08-16 16:23:41 -07:00
user_groups.js org settings: Add user group deletion functionality. 2018-01-06 11:50:52 -05:00
util.js util: Remove execute_early. 2017-07-04 13:54:33 -07:00
zulip.js night-mode: Add custom CSS through JS. 2017-11-29 23:06:11 -08:00