mirror of
https://github.com/zulip/zulip.git
synced 2026-07-18 21:04:19 +08:00
d814a8476c
This commit has us piggy back the conditional for narrow_description off of the conditional for sub_count, the reason for this approach is that "narrow_description" needs to handle four unique cases: - The stream exists and has a description. - The stream exists and does not have a description. - The stream does not exist and we must render appropriate text. - We are not in a stream narrow and the span should not be rendered. By piggy backing off of sub count we can get the first and last case, with the inner conditional (on rendered_narrow_description) handling the second case and the tab_bar.js passing appropriate values to the template to handle the third case. This unfortunately makes the template more brittle such that breakage of the subcount can cause breakage (non rendering) of the description as well. |
||
|---|---|---|
| .. | ||
| assets | ||
| audio | ||
| generated | ||
| html | ||
| images | ||
| js | ||
| shared | ||
| styles | ||
| templates | ||
| third | ||
| .eslintrc.json | ||
| .gitignore | ||
| favicon.ico | ||