mirror of
https://github.com/zulip/zulip.git
synced 2026-06-24 21:08:25 +08:00
74c628b105
Previously, we didn't check the organization-level settings when rendering a message list; instead, we only checked it when putting messages into the message_store. That resulted in the state being stale in the event that the setting controlling whether one can edit messages was changed. We remove some node tests, because revidving the node test for their new home in message_list_view would be more work than we probably want to do with an upcoming release. We basically need to be better about exporting functions like populate_group_from_message_container and set_topic_edit_properties, so we can do fine grained testing. When we get around to the node tests, rather than exporting these functions, it might make sense to create a new module with a name like message_container.js, which would have all of these last-second type of data manipulations on message objects. This would be nice to split out of message_list_view.js. MLV is our biggest module, and it's mostly cohesive, but it's real job should be about assembling messages into a DOM list, which is probably 80% of the code now. The 20% that I'd want to consider splitting out is actually closer in spirit to message_store.js. Thanks to Steve Howell for helping with the node tests. |
||
|---|---|---|
| .. | ||
| assets | ||
| audio | ||
| generated | ||
| html | ||
| images | ||
| js | ||
| locale | ||
| styles | ||
| swagger | ||
| templates | ||
| third | ||
| ts | ||
| .gitignore | ||
| favicon.ico | ||
| node_modules | ||
| robots.txt | ||