Abhijeet Prasad Bodas 42aea49784 left sidebar: Add support to unstar all messages in topic. ... This adds support for unstarring all (starred) messages from a particular topic, from the topic popover. The earlier implementation of this in #16898 was reverted in bc55aa6a01 (#17429) because it had two problems- 1. The crash reported in bc55aa6a01 was due to message_store returning undefined. This happens when the message itself hasn't been fetched from the server yet, but we know that the message is starred from the ids in `page_params` in `starred_messages.js`. This commit handles this case explicitly. Note that, we simply ignore those messages which we haven't fetched, and because of this, it may happen that we don't unstar some messages from that topic. The correct implementation for this would be to ask the backend for starred IDs in a topic. 2. The earlier implementation actually unstarred **all** messages. This was because it grabbed the topic and stream_id from the topic popover `data` attributes, after the topic popover had been closed. This passed `undefined`, which the function then interpreted as an action to unstar all messages. With this commit, we use the confirm_dialog widget, which eliminates the need to store this data in the DOM.		2021-03-23 00:17:15 -07:00
..
settings	account_settings: Change the position of the custom-profile-fields-form.	2021-03-17 12:25:12 -07:00
widgets	widgets: Remove tictactoe example widget.	2020-11-03 14:46:39 -08:00
actions_popover_content.hbs	message view: Add hotkey hints.	2021-01-25 14:26:43 -08:00
admin_bot_form.hbs	overlay: Mitigate issue with dropdown list widget getting clipped.	2020-06-04 16:44:19 -04:00
admin_default_streams_list.hbs	default streams: Change remove api to use stream_id.	2020-03-25 17:11:25 -07:00
admin_emoji_list.hbs	docs: Fix more capitalization issues.	2020-10-23 11:46:55 -07:00
admin_export_list.hbs	data exports: Keep deleted export in UI table.	2020-04-30 13:00:59 -07:00
admin_human_form.hbs	users: Add docs link next to the label of dropdown for changing user's role.	2020-06-21 09:41:46 -07:00
admin_invites_list.hbs	invites: Display name of referrer instead of email in invites list.	2020-09-22 15:42:53 -07:00
admin_linkifier_list.hbs	refactor: Rename filter to linkifier in frontend code and docs.	2021-03-15 11:19:59 -07:00
admin_profile_field_list.hbs	templates: Use <hr> and <br> consistently.	2020-04-28 17:05:48 -07:00
admin_settings_modals.hbs	templates: Use upstream Handlebars partials syntax.	2019-07-12 21:11:14 -07:00
admin_tab.hbs	data export: Add UI to trigger data export.	2019-08-12 18:21:38 -07:00
admin_user_group_list.hbs	i18n: Fix quotes of help message in user group settings.	2020-09-30 13:22:56 -07:00
admin_user_list.hbs	popovers: Rename data-owner-id and data-bot-owner-id to data-user-id.	2020-09-22 15:42:53 -07:00
all_messages_sidebar_actions.hbs	popovers: Add keyboard support for All Messages popover in sidebar.	2020-08-31 22:55:28 -07:00
announce_stream_docs.hbs	templates: Rename *.handlebars ↦ *.hbs and - ↦ _.	2019-07-12 21:11:03 -07:00
archive_message_group.hbs	templates: Use upstream Handlebars partials syntax.	2019-07-12 21:11:14 -07:00
archive_recipient_row.hbs	templates: Rename *.handlebars ↦ *.hbs and - ↦ _.	2019-07-12 21:11:03 -07:00
blueslip_stacktrace.hbs	blueslip: Make stack trace more readable.	2019-10-31 13:47:54 -07:00
bookend.hbs	templates: Rename *.handlebars ↦ *.hbs and - ↦ _.	2019-07-12 21:11:03 -07:00
bot_avatar_row.hbs	settings: Change username to bot email in bot settings HTML.	2019-09-23 15:55:25 -07:00
buddy_list_tooltip_content.hbs	templates: Use <hr> and <br> consistently.	2020-04-28 17:05:48 -07:00
buddy_list_tooltip.hbs	user status: Add JS tooltips for Buddy List and PM List.	2019-11-20 12:49:37 -08:00
compose_all_everyone.hbs	templates: Use <hr> and <br> consistently.	2020-04-28 17:05:48 -07:00
compose_announce.hbs	templates: Use <hr> and <br> consistently.	2020-04-28 17:05:48 -07:00
compose_invite_users.hbs	compose: Add data-stream-id field in compose_invite_users.	2020-07-06 15:30:01 -07:00
compose_not_subscribed.hbs	templates: Rename *.handlebars ↦ *.hbs and - ↦ _.	2019-07-12 21:11:03 -07:00
compose_notification.hbs	lint: Replace local variables named 'msgid' with 'message_id'.	2019-08-28 15:19:30 -07:00
compose_private_stream_alert.hbs	templates: Rename *.handlebars ↦ *.hbs and - ↦ _.	2019-07-12 21:11:03 -07:00
confirm_delete_user_avatar.hbs	avatar: Add confirmation dialog before deleting profile picture.	2021-03-11 19:58:38 -08:00
confirm_delete_user.hbs	templates: Rename *.handlebars ↦ *.hbs and - ↦ _.	2019-07-12 21:11:03 -07:00
confirm_dialog.hbs	confirm_dialog: Make it usable outside settings.	2021-03-23 00:17:15 -07:00
confirm_unstar_all_messages_in_topic.hbs	left sidebar: Add support to unstar all messages in topic.	2021-03-23 00:17:15 -07:00
confirm_unstar_all_messages.hbs	refactor: Use confirm_dialog for unstar-all-messages.	2021-03-23 00:17:15 -07:00
copy_code_button.hbs	templates: Extract and tweak copy_to_clipboard_svg from both buttons.	2020-10-08 17:13:50 -07:00
copy_invite_link.hbs	invite: Add Copy-to-Clipboard button for multiuse links.	2020-11-02 15:34:50 -08:00
copy_message_button.hbs	templates: Extract and tweak copy_to_clipboard_svg from both buttons.	2020-10-08 17:13:50 -07:00
copy_to_clipboard_svg.hbs	templates: Extract and tweak copy_to_clipboard_svg from both buttons.	2020-10-08 17:13:50 -07:00
default_language_modal.hbs	templates: Rename *.handlebars ↦ *.hbs and - ↦ _.	2019-07-12 21:11:03 -07:00
delete_topic_modal.hbs	templates: Make sure users know deletion is for everyone.	2020-10-29 17:25:40 -07:00
draft_table_body.hbs	templates: Use upstream Handlebars partials syntax.	2019-07-12 21:11:14 -07:00
draft.hbs	CVE-2020-9444: Prevent reverse tabnabbing attacks.	2020-04-01 14:01:45 -07:00
edit_bot.hbs	Revert "frontend: Fixed broken label tag and removed label expression."	2021-03-03 23:58:50 +05:30
edit_content_button.hbs	message feed: Make message controls more accessible.	2020-07-30 16:53:00 -07:00
edited_notice.hbs	message_edit: Add message edit local echo.	2019-11-20 17:40:19 -08:00
embedded_bot_config_item.hbs	templates: Rename *.handlebars ↦ *.hbs and - ↦ _.	2019-07-12 21:11:03 -07:00
emoji_popover_content.hbs	emoji_picker: Fix search input length.	2020-09-23 11:33:27 -07:00
emoji_popover_emoji.hbs	templates: Fix missing quoting of attributes in HTML templates.	2020-06-16 23:35:39 -07:00
emoji_popover_search_results.hbs	templates: Use upstream Handlebars partials syntax.	2019-07-12 21:11:14 -07:00
emoji_popover.hbs	templates: Rename *.handlebars ↦ *.hbs and - ↦ _.	2019-07-12 21:11:03 -07:00
emoji_showcase.hbs	templates: Rename *.handlebars ↦ *.hbs and - ↦ _.	2019-07-12 21:11:03 -07:00
favicon.svg.hbs	dependencies: Upgrade Source Sans Pro font to Source Sans 3.	2021-02-23 14:55:33 -08:00
feedback_container.hbs	templates: Rename *.handlebars ↦ *.hbs and - ↦ _.	2019-07-12 21:11:03 -07:00
help_link_widget.hbs	CVE-2020-14194: Use noopener/noreferrer for external links.	2020-06-16 23:35:39 -07:00
hotspot_icon.hbs	hotspots: Generate properly escaped HTML.	2021-02-05 09:26:47 -08:00
hotspot_overlay.hbs	templates: Rename *.handlebars ↦ *.hbs and - ↦ _.	2019-07-12 21:11:03 -07:00
input_pill.hbs	templates: Fix missing quoting of attributes in HTML templates.	2020-06-16 23:35:39 -07:00
intro_reply_hotspot.hbs	templates: Rename *.handlebars ↦ *.hbs and - ↦ _.	2019-07-12 21:11:03 -07:00
invitation_failed_error.hbs	invitations: Improve experience around reactivating users.	2020-01-13 18:30:51 -08:00
invite_subscription.hbs	invite: Fix compose box focus on clicking (Un)check All in invite window.	2020-09-04 12:58:11 -07:00
loader.hbs	templates: Rename *.handlebars ↦ *.hbs and - ↦ _.	2019-07-12 21:11:03 -07:00
markdown_help.hbs	info_overlay: Render Markdown help with frontend Markdown library.	2021-03-11 21:24:39 -08:00
markdown_timestamp.hbs	markdown: Add fa-clock icon before markdown timestamps.	2021-03-14 22:57:01 -07:00
me_message.hbs	messagebox: Add title-text for user profile on sender name and avatar.	2020-05-14 14:07:41 -07:00
message_avatar.hbs	templates: Rename *.handlebars ↦ *.hbs and - ↦ _.	2019-07-12 21:11:03 -07:00
message_body.hbs	messagebox: Add title-text for user profile on sender name and avatar.	2020-05-14 14:07:41 -07:00
message_controls.hbs	message view: Show message source button until message successfully sent.	2021-03-18 14:49:09 -07:00
message_edit_form.hbs	templates: Extract and tweak copy_message_button from message_edit_form.	2020-10-08 17:13:50 -07:00
message_edit_history.hbs	templates: Use <hr> and <br> consistently.	2020-04-28 17:05:48 -07:00
message_group.hbs	templates: Use upstream Handlebars partials syntax.	2019-07-12 21:11:14 -07:00
message_reaction.hbs	templates: Fix missing quoting of attributes in HTML templates.	2020-06-16 23:35:39 -07:00
message_reactions.hbs	message_view: Add a js tooltip hover for reaction button.	2019-07-19 12:45:44 -07:00
message_view_header.hbs	navbar: Rename tab_bar to message_view_header.	2020-07-30 16:23:13 -07:00
mobile_message_buttons_popover_content.hbs	templates: Rename *.handlebars ↦ *.hbs and - ↦ _.	2019-07-12 21:11:03 -07:00
mobile_message_buttons_popover.hbs	templates: Rename *.handlebars ↦ *.hbs and - ↦ _.	2019-07-12 21:11:03 -07:00
more_topics_spinner.hbs	topic list: Split out spinner template.	2020-01-30 12:15:40 -08:00
more_topics.hbs	topic list: Split out spinner template.	2020-01-30 12:15:40 -08:00
move_topic_to_stream.hbs	ui: Add loading spinner for Move Topic popover.	2020-08-31 16:51:49 -07:00
muted_topic_ui_row.hbs	templates: Fix missing quoting of attributes in HTML templates.	2020-06-16 23:35:39 -07:00
navbar_icon_and_title.hbs	navbar: Improve click area around stream name.	2020-06-16 17:26:55 -07:00
new_stream_users.hbs	templates: Use <hr> and <br> consistently.	2020-04-28 17:05:48 -07:00
no_arrow_popover.hbs	templates: Rename *.handlebars ↦ *.hbs and - ↦ _.	2019-07-12 21:11:03 -07:00
non_editable_user_group.hbs	templates: Rename *.handlebars ↦ *.hbs and - ↦ _.	2019-07-12 21:11:03 -07:00
playground_links_popover_content.hbs	popover: Add UI model to view code in playground(s).	2020-09-28 16:04:54 -07:00
pm_list_item.hbs	pm_list: Simplify redraws for Private Messages.	2020-01-30 13:11:32 -08:00
recent_topic_row.hbs	recent typos: Fix incorrect aria-label of mute (should be unmute).	2021-03-18 10:13:25 -07:00
recent_topics_filters.hbs	recent_topic: Add role and area properties according to MDN docs.	2021-03-16 14:54:22 -07:00
recent_topics_table.hbs	recent_topics: Stop last_msg_time_header::after from overflowing.	2021-02-25 17:33:01 -08:00
recipient_row.hbs	message_header: Fix overlap on mobile with flex.	2020-07-09 13:13:38 -07:00
remind_me_popover_content.hbs	templates: Rename *.handlebars ↦ *.hbs and - ↦ _.	2019-07-12 21:11:03 -07:00
settings_tab.hbs	templates: Use upstream Handlebars partials syntax.	2019-07-12 21:11:14 -07:00
single_message.hbs	templates: Use upstream Handlebars partials syntax.	2019-07-12 21:11:14 -07:00
starred_messages_sidebar_actions.hbs	left sidebar: Don't show unstar-all button when redundant.	2021-03-18 15:52:06 -07:00
stream_creation_form.hbs	stream_creation_form: Remove optional from stream description input.	2020-08-14 10:30:56 -07:00
stream_member_list_entry.hbs	subscriber list: Fix display of email addresses in subscribers list.	2020-03-08 12:42:08 -07:00
stream_privacy.hbs	templates: Extract subscription_privacy partial template.	2020-04-01 14:40:41 -07:00
stream_settings_checkbox.hbs	i18n: Fix quotes in mute setting help message.	2020-10-02 15:01:48 -07:00
stream_sidebar_actions.hbs	popovers: Add keyboard support for stream popovers in left sidebar.	2020-08-31 22:52:28 -07:00
stream_sidebar_row.hbs	stream_sidebar_row: Show full stream name on hover.	2021-01-04 18:19:48 -08:00
stream_subscription_info.hbs	popover: Show normal popover for the stream_subscription_info users.	2020-10-12 17:42:52 -07:00
stream_types.hbs	streams: Show error when trying to make a default stream private.	2020-10-29 15:47:34 -07:00
subscription_count.hbs	streams: Format subscriber count according to browser locale.	2020-07-06 11:27:43 -07:00
subscription_invites_warning_modal.hbs	templates: Rename *.handlebars ↦ *.hbs and - ↦ _.	2019-07-12 21:11:03 -07:00
subscription_members.hbs	subscription_members: Make the help text more clear.	2021-02-06 08:51:36 +05:30
subscription_privacy.hbs	templates: Extract subscription_privacy partial template.	2020-04-01 14:40:41 -07:00
subscription_setting_icon.hbs	templates: Rename *.handlebars ↦ *.hbs and - ↦ _.	2019-07-12 21:11:03 -07:00
subscription_settings.hbs	subscription_settings: Show eye icon for view stream button.	2020-11-03 16:48:23 -08:00
subscription_stream_privacy_modal.hbs	templates: Use upstream Handlebars partials syntax.	2019-07-12 21:11:14 -07:00
subscription_table_body.hbs	CVE-2020-14194: Use noopener/noreferrer for external links.	2020-06-16 23:35:39 -07:00
subscription_type.hbs	streams: Show message retention policy details in subscription_type text.	2020-06-18 17:13:04 -07:00
subscription.hbs	stream settings: Fix UI feedback on clicking checkbox to subscribe.	2020-04-18 22:00:02 -07:00
subscriptions.hbs	templates: Use upstream Handlebars partials syntax.	2019-07-12 21:11:14 -07:00
topic_edit_form.hbs	message_edit: Show error message if error edit fails.	2020-04-22 16:25:37 -07:00
topic_list_item.hbs	sidebars: Replace chevron with ellipsis-v icon from the sidebars.	2020-06-14 20:57:43 -07:00
topic_muted.hbs	templates: Rename *.handlebars ↦ *.hbs and - ↦ _.	2019-07-12 21:11:03 -07:00
topic_sidebar_actions.hbs	left sidebar: Add support to unstar all messages in topic.	2021-03-23 00:17:15 -07:00
typeahead_list_item.hbs	css: Add separate class for typeahead items with no presence circle.	2021-03-12 02:10:21 -08:00
typing_notification.hbs	i18n: Add missing translation tags to typing notifications.	2020-02-12 10:54:34 -08:00
typing_notifications.hbs	docs: Fix more capitalization issues.	2020-10-23 11:46:55 -07:00
uploaded_files_list.hbs	CVE-2020-14194: Use noopener/noreferrer for external links.	2020-06-16 23:35:39 -07:00
user_group_info_popover_content.hbs	templates: Rename *.handlebars ↦ *.hbs and - ↦ _.	2019-07-12 21:11:03 -07:00
user_group_info_popover.hbs	templates: Rename *.handlebars ↦ *.hbs and - ↦ _.	2019-07-12 21:11:03 -07:00
user_groups_admin.hbs	CVE-2020-14194: Use noopener/noreferrer for external links.	2020-06-16 23:35:39 -07:00
user_info_popover_content.hbs	popovers: Make a single click handler for opening bot owner popover.	2020-09-22 15:42:53 -07:00
user_info_popover_title.hbs	templates: Rename *.handlebars ↦ *.hbs and - ↦ _.	2019-07-12 21:11:03 -07:00
user_presence_row.hbs	sidebars: Replace chevron with ellipsis-v icon from the sidebars.	2020-06-14 20:57:43 -07:00
user_presence_rows.hbs	docs: Fix more capitalization issues.	2020-10-23 11:46:55 -07:00
user_profile_modal.hbs	CVE-2020-14194: Use noopener/noreferrer for external links.	2020-06-16 23:35:39 -07:00
view_code_in_playground.hbs	rendered_markdown: Display 'view code in playground' option in code blocks.	2020-09-28 16:04:54 -07:00