mirror of
https://github.com/zulip/zulip.git
synced 2026-07-06 21:18:58 +08:00
We had a bunch of places where we
were calling `resize.resize_bottom_whitespace`
with no arguments, which has been a no-op
since the below commit that removed support
for our `autoscroll_forever` option:
fa44d2ea69
With the `autoscroll_forever` options things
like opening/closing the compose box could
alter how much bottom whitespace you'd want,
but we stopped supporting that feature in
2017.
Since then bottom_whitespace has just always
been 40% of the viewport size. So we only need
to change it on actual resize events.
It's worth noting that we still call
`resize_bottom_whitespace` indirectly in many
places, via `resize_page_components`, and
the latter actually causes
`resize_bottom_whitespace` to do real work,
but that work is redundant for most of those
codepaths, since they're not triggered by
changes to the viewport. So there are other
opportunities for cleanup.
400 lines
9.1 KiB
JavaScript
400 lines
9.1 KiB
JavaScript
set_global('$', global.make_zjquery());
|
|
set_global('document', 'document-stub');
|
|
|
|
zrequire('message_fetch');
|
|
|
|
const noop = () => {};
|
|
|
|
set_global('MessageListView', function () { return {}; });
|
|
|
|
zrequire('FetchStatus', 'js/fetch_status');
|
|
zrequire('Filter', 'js/filter');
|
|
zrequire('MessageListData', 'js/message_list_data');
|
|
zrequire('message_list');
|
|
zrequire('recent_topics');
|
|
zrequire('people');
|
|
|
|
set_global('page_params', {
|
|
have_initial_messages: true,
|
|
pointer: 444,
|
|
});
|
|
set_global('ui_report', {
|
|
hide_error: noop,
|
|
});
|
|
set_global('activity', {});
|
|
set_global('channel', {});
|
|
set_global('document', 'document-stub');
|
|
set_global('message_scroll', {
|
|
show_loading_newer: noop,
|
|
hide_loading_newer: noop,
|
|
});
|
|
set_global('message_util', {});
|
|
set_global('message_store', {});
|
|
set_global('narrow_state', {});
|
|
set_global('notifications', {
|
|
hide_or_show_history_limit_message: () => {},
|
|
});
|
|
set_global('pm_list', {});
|
|
set_global('server_events', {});
|
|
set_global('stream_list', {
|
|
maybe_scroll_narrow_into_view: () => {},
|
|
});
|
|
|
|
const alice = {
|
|
email: '[email protected]',
|
|
user_id: 7,
|
|
full_name: 'Alice',
|
|
};
|
|
people.add_active_user(alice);
|
|
|
|
server_events.home_view_loaded = noop;
|
|
|
|
function stub_message_view(list) {
|
|
list.view.append = noop;
|
|
list.view.maybe_rerender = noop;
|
|
list.view.prepend = noop;
|
|
}
|
|
|
|
function make_home_msg_list() {
|
|
const table_name = 'whatever';
|
|
const filter = new Filter();
|
|
|
|
const list = new message_list.MessageList({
|
|
table_name: table_name,
|
|
filter: filter,
|
|
});
|
|
return list;
|
|
}
|
|
|
|
function make_all_list() {
|
|
return new message_list.MessageList({});
|
|
}
|
|
|
|
function reset_lists() {
|
|
set_global('home_msg_list', make_home_msg_list());
|
|
set_global('current_msg_list', home_msg_list);
|
|
message_list.all = make_all_list();
|
|
stub_message_view(home_msg_list);
|
|
stub_message_view(message_list.all);
|
|
}
|
|
|
|
function config_fake_channel(conf) {
|
|
const self = {};
|
|
let called;
|
|
|
|
channel.get = function (opts) {
|
|
if (called) {
|
|
throw "only use this for one call";
|
|
}
|
|
assert(self.success === undefined);
|
|
assert.equal(opts.url, '/json/messages');
|
|
assert.deepEqual(opts.data, conf.expected_opts_data);
|
|
self.success = opts.success;
|
|
called = true;
|
|
};
|
|
|
|
return self;
|
|
}
|
|
|
|
function config_process_results(messages) {
|
|
const self = {};
|
|
|
|
const messages_processed_for_bools = [];
|
|
|
|
message_store.set_message_booleans = function (message) {
|
|
messages_processed_for_bools.push(message);
|
|
};
|
|
|
|
message_store.add_message_metadata = message => message;
|
|
|
|
message_util.do_unread_count_updates = function (arg) {
|
|
assert.deepEqual(arg, messages);
|
|
};
|
|
|
|
message_util.add_old_messages = function (new_messages, msg_list) {
|
|
assert.deepEqual(new_messages, messages);
|
|
msg_list.add_messages(new_messages);
|
|
};
|
|
|
|
activity.process_loaded_messages = function (arg) {
|
|
assert.deepEqual(arg, messages);
|
|
};
|
|
|
|
stream_list.update_streams_sidebar = noop;
|
|
|
|
pm_list.update_private_messages = noop;
|
|
|
|
self.verify = function () {
|
|
assert.deepEqual(messages_processed_for_bools, messages);
|
|
};
|
|
|
|
return self;
|
|
}
|
|
|
|
function message_range(start, end) {
|
|
return _.range(start, end).map(idx => ({
|
|
id: idx,
|
|
}));
|
|
}
|
|
|
|
const initialize_data = {
|
|
initial_fetch: {
|
|
req: {
|
|
anchor: 444,
|
|
num_before: 200,
|
|
num_after: 200,
|
|
client_gravatar: true,
|
|
},
|
|
resp: {
|
|
messages: message_range(201, 801),
|
|
found_newest: false,
|
|
},
|
|
},
|
|
|
|
forward_fill: {
|
|
req: {
|
|
anchor: '800',
|
|
num_before: 0,
|
|
num_after: 1000,
|
|
client_gravatar: true,
|
|
},
|
|
resp: {
|
|
messages: message_range(800, 1000),
|
|
found_newest: true,
|
|
},
|
|
},
|
|
|
|
back_fill: {
|
|
req: {
|
|
anchor: '201',
|
|
num_before: 1000,
|
|
num_after: 0,
|
|
client_gravatar: true,
|
|
},
|
|
resp: {
|
|
messages: message_range(100, 200),
|
|
found_oldest: true,
|
|
},
|
|
},
|
|
};
|
|
|
|
function test_fetch_success(opts) {
|
|
const response = opts.response;
|
|
const messages = response.messages;
|
|
|
|
const process_results = config_process_results(messages);
|
|
opts.fetch.success(response);
|
|
process_results.verify();
|
|
}
|
|
|
|
function initial_fetch_step() {
|
|
const self = {};
|
|
|
|
let fetch;
|
|
const response = initialize_data.initial_fetch.resp;
|
|
|
|
self.prep = function () {
|
|
fetch = config_fake_channel({
|
|
expected_opts_data: initialize_data.initial_fetch.req,
|
|
});
|
|
|
|
message_fetch.initialize();
|
|
};
|
|
|
|
self.finish = function () {
|
|
test_fetch_success({
|
|
fetch: fetch,
|
|
response: response,
|
|
});
|
|
};
|
|
|
|
return self;
|
|
}
|
|
|
|
function forward_fill_step() {
|
|
const self = {};
|
|
|
|
let fetch;
|
|
|
|
self.prep = function () {
|
|
fetch = config_fake_channel({
|
|
expected_opts_data: initialize_data.forward_fill.req,
|
|
});
|
|
};
|
|
|
|
self.finish = function () {
|
|
const response = initialize_data.forward_fill.resp;
|
|
|
|
let idle_config;
|
|
$('document-stub').idle = function (config) {
|
|
idle_config = config;
|
|
};
|
|
|
|
test_fetch_success({
|
|
fetch: fetch,
|
|
response: response,
|
|
});
|
|
|
|
assert.equal(idle_config.idle, 10000);
|
|
|
|
return idle_config;
|
|
};
|
|
|
|
return self;
|
|
}
|
|
|
|
function test_backfill_idle(idle_config) {
|
|
const fetch = config_fake_channel({
|
|
expected_opts_data: initialize_data.back_fill.req,
|
|
});
|
|
|
|
const response = initialize_data.back_fill.resp;
|
|
|
|
idle_config.onIdle();
|
|
|
|
test_fetch_success({
|
|
fetch: fetch,
|
|
response: response,
|
|
});
|
|
}
|
|
|
|
run_test('initialize', () => {
|
|
reset_lists();
|
|
|
|
const step1 = initial_fetch_step();
|
|
|
|
step1.prep();
|
|
|
|
const step2 = forward_fill_step();
|
|
|
|
step2.prep();
|
|
step1.finish();
|
|
|
|
const idle_config = step2.finish();
|
|
|
|
test_backfill_idle(idle_config);
|
|
});
|
|
|
|
function simulate_narrow() {
|
|
const filter = {
|
|
predicate: () => () => false,
|
|
};
|
|
|
|
narrow_state.active = function () { return true; };
|
|
narrow_state.public_operators = function () {
|
|
return [{ operator: 'pm-with', operand: alice.email }];
|
|
};
|
|
|
|
const msg_list = new message_list.MessageList({
|
|
table_name: 'zfilt',
|
|
filter: filter,
|
|
});
|
|
set_global('current_msg_list', msg_list);
|
|
|
|
return msg_list;
|
|
}
|
|
|
|
run_test('loading_newer', () => {
|
|
function test_dup_new_fetch(msg_list) {
|
|
assert.equal(msg_list.fetch_status.can_load_newer_messages(), false);
|
|
message_fetch.maybe_load_newer_messages({
|
|
msg_list: msg_list,
|
|
});
|
|
}
|
|
|
|
function test_happy_path(opts) {
|
|
const msg_list = opts.msg_list;
|
|
const data = opts.data;
|
|
|
|
const fetch = config_fake_channel({
|
|
expected_opts_data: data.req,
|
|
});
|
|
|
|
message_fetch.maybe_load_newer_messages({
|
|
msg_list: msg_list,
|
|
show_loading: noop,
|
|
hide_loading: noop,
|
|
});
|
|
|
|
test_dup_new_fetch(msg_list);
|
|
|
|
test_fetch_success({
|
|
fetch: fetch,
|
|
response: data.resp,
|
|
});
|
|
}
|
|
|
|
(function test_narrow() {
|
|
const msg_list = simulate_narrow();
|
|
|
|
const data = {
|
|
req: {
|
|
anchor: '444',
|
|
num_before: 0,
|
|
num_after: 100,
|
|
narrow: `[{"operator":"pm-with","operand":[${alice.user_id}]}]`,
|
|
client_gravatar: true,
|
|
},
|
|
resp: {
|
|
messages: message_range(500, 600),
|
|
found_newest: false,
|
|
},
|
|
};
|
|
|
|
test_happy_path({
|
|
msg_list: msg_list,
|
|
data: data,
|
|
});
|
|
|
|
assert.equal(msg_list.fetch_status.can_load_newer_messages(), true);
|
|
}());
|
|
|
|
(function test_home() {
|
|
reset_lists();
|
|
const msg_list = home_msg_list;
|
|
|
|
const data = [
|
|
{
|
|
req: {
|
|
anchor: '444',
|
|
num_before: 0,
|
|
num_after: 100,
|
|
client_gravatar: true,
|
|
},
|
|
resp: {
|
|
messages: message_range(500, 600),
|
|
found_newest: false,
|
|
},
|
|
},
|
|
{
|
|
req: {
|
|
anchor: '599',
|
|
num_before: 0,
|
|
num_after: 100,
|
|
client_gravatar: true,
|
|
},
|
|
resp: {
|
|
messages: message_range(700, 800),
|
|
found_newest: true,
|
|
},
|
|
},
|
|
];
|
|
|
|
test_happy_path({
|
|
msg_list: msg_list,
|
|
data: data[0],
|
|
});
|
|
|
|
assert.equal(msg_list.fetch_status.can_load_newer_messages(), true);
|
|
|
|
test_happy_path({
|
|
msg_list: msg_list,
|
|
data: data[1],
|
|
});
|
|
|
|
assert.equal(msg_list.fetch_status.can_load_newer_messages(), false);
|
|
|
|
}());
|
|
|
|
});
|