CodeCow/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2026-06-30 21:11:04 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity
2becb41931
zulip/web/tests
History
Prakhar Pratyush 909a2efb43 channel: Don't show "You subscribed to" bookend on channel creation. 
Three events i.e. 'stream create', 'subscription add', and
'message' event are received by client on channel creation.

Earlier, we were narrowing to channel while processing the
'stream create' event. This was resulting in fetching messages
for that narrow even before adding subscription. This resulted
in a bug where "You subscribed to" bookend was visible in the
message feed after the "channel events" message.

This commit updates the logic to narrow ONLY after adding
subscription i.e. while processing "subscription add" event.

Note: A channel creator who is not going to subscribe to the
channel themselves is NOT narrowed to the channel view.

This fixes the incorrect behavior.
2024-07-11 09:51:55 -07:00
..
lib search: Use pills in the search bar. 2024-07-09 17:08:45 -07:00
templates popovers: Add hotkey hints support via a new handlebar template. 2024-04-11 15:57:24 -07:00
activity.test.js presence: Sync presence indicators across the frontend. 2024-07-10 11:01:44 -07:00
alert_words_ui.test.js node tests: Use noop helper function pattern in test files. 2023-12-14 14:51:33 -08:00
alert_words.test.js alert_words: Highlight overlapping alert words more accurately. 2024-03-19 11:20:16 -07:00
blueslip_stacktrace.test.js upload: Convert module to TypeScript. 2024-05-15 10:53:09 -07:00
bot_data.test.js models: Extract zerver.models.users. 2023-12-16 22:08:44 -08:00
browser_history.test.js settings: Rename default_view and escape_navigates_to_default_view. 2023-10-26 11:00:12 -07:00
buddy_data.test.js settings: Use page_params.is_spectator field for spectator checks. 2024-06-14 17:11:23 -07:00
buddy_list.test.js typos: Fix typos caught by mwic. 2024-05-20 13:55:00 -07:00
channel.test.js channel: Use base_page_params. 2024-02-27 21:18:00 -05:00
color_data.test.js
common.test.js search: Remove is:dm suggestion from get_operator_suggestions. 2024-06-17 16:30:40 -07:00
components.test.js toggle: Add register_event_handlers to toggle prototype. 2024-06-17 17:16:21 -07:00
compose_actions.test.js settings: Add two realm settings to restrict direct messages. 2024-07-08 19:34:17 -07:00
compose_closed_ui.test.js message_list: Only update selected id and banner for current list. 2024-05-03 12:42:22 -07:00
compose_fade.test.js compose fade users: Remove fade logic in favor of buddy list split. 2024-02-22 16:05:27 -08:00
compose_pm_pill.test.js users: Add "(guest)" to names for guest users. 2023-10-12 12:06:10 -07:00
compose_state.test.js stream picker: Remove stream colorblock. 2024-03-15 11:11:04 -07:00
compose_ui.test.js refactor: Make compose size related variables & functions more specific. 2024-06-26 16:36:52 -07:00
compose_validate.test.js settings: Add two realm settings to restrict direct messages. 2024-07-08 19:34:17 -07:00
compose_video.test.js compose_call_ui: Convert module to TypeScript. 2024-06-02 21:49:49 -07:00
compose.test.js settings: Add two realm settings to restrict direct messages. 2024-07-08 19:34:17 -07:00
composebox_typeahead.test.js typeahead: Fix typeahead items wrapping to next line. 2024-07-09 09:42:10 -07:00
copy_and_paste.test.js turndown: Enable turndown in production. 2024-03-28 13:07:34 -07:00
deprecated_feature_notice.test.js
dispatch_subs.test.js tests: Replace unneeded override_rewire uses by whole-module mocks. 2024-03-15 17:29:47 -04:00
dispatch.test.js settings: Add two realm settings to restrict direct messages. 2024-07-08 19:34:17 -07:00
drafts.test.js drafts: Show saved time in UTC format in a tooltip. 2024-07-01 15:13:21 -07:00
echo.test.js messages: Rename convert_raw_message_to_message_with_booleans. 2024-06-03 15:42:41 -07:00
emoji_picker.test.js emoji: Fallback to Google Modern for unsupported new Twitter emoji. 2023-11-28 23:46:49 -08:00
emoji.test.js ts: Convert emoji.js to TypeScript. 2023-04-05 10:29:01 -07:00
example1.test.js docs: Add missing spaces around code spans. 2023-12-14 00:05:44 -08:00
example2.test.js message_helper: Be more explicit about converting subject to topic. 2024-05-29 16:45:36 -07:00
example3.test.js narrow_state: Use message_lists.current to return current filter. 2024-02-24 08:31:18 -08:00
example4.test.js presence: Frontend implementation of the last_update_id API. 2024-06-07 13:57:40 -07:00
example5.test.js rename: Rename "huddle_data.ts" to "direct_message_group_data.ts". 2024-06-14 18:07:07 -07:00
example6.test.js node tests: Use noop helper function pattern in test files. 2023-12-14 14:51:33 -08:00
example7.test.js message_list: Don't always cache "Combined feed" view. 2024-04-25 09:20:43 -07:00
example8.test.js narrow_state: Use message_lists.current to return current filter. 2024-02-24 08:31:18 -08:00
fenced_code.test.js
fetch_status.test.js refactor: Extract message_feed_loading module from message_scroll. 2023-05-14 11:24:31 -07:00
filter.test.js filter: Remove unused parts of is_valid_search_term. 2024-07-09 17:08:45 -07:00
fold_dict.test.js eslint: Fix unicorn/prefer-spread. 2023-03-02 12:16:56 -08:00
gear_menu_util.test.js page_params: Split out state data for realm. 2024-02-15 10:22:52 -08:00
hash_util.test.js test_fixtures: Add 'message_link_test_cases' test fixture. 2024-06-17 10:42:32 -07:00
hashchange.test.js settings: Unite user settings into a single panel. 2024-06-17 17:16:21 -07:00
hotkey.test.js narrow: Rename to message_view. 2024-06-05 12:03:59 -07:00
i18n.test.js popovers: Rename actions_popover.hbs. 2024-05-20 09:10:36 -07:00
input_pill.test.js search pills: Direct message group pill support. 2024-07-09 17:08:45 -07:00
internal_url.test.js
keydown_util.test.js
lazy_set.test.js lazy set: Increase code coverage. 2023-10-31 16:06:07 -07:00
left_sidebar_navigation_area.test.js filter: Remove incorrect check for All messages view. 2024-01-15 12:26:24 -08:00
linkifiers.test.js Revert "linkifiers: Match JS implementation to server implementation." 2023-11-16 14:59:48 -08:00
list_cursor.test.js node tests: Use noop helper function pattern in test files. 2023-12-14 14:51:33 -08:00
list_widget.test.js list_widget: Reduce TypeScript wreckage. 2024-06-07 11:54:37 -07:00
markdown_parse.test.js markdown: Remove wrapper around get_topic_links. 2024-02-01 12:12:06 -08:00
markdown.test.js push_notifications: Compress blockquotes when replying to a message. 2024-06-14 17:26:22 -07:00
message_edit.test.js page_params: Split out state data for realm. 2024-02-15 10:22:52 -08:00
message_events.test.js message_helper: Convert module to typescript. 2024-05-29 16:45:36 -07:00
message_flags.test.js web-narrow: Update operators to use channel and channels. 2024-04-24 17:03:36 -07:00
message_list_data.test.js user_topics: Always store stream name in UserTopic. 2024-03-30 16:25:34 -07:00
message_list_view.test.js docs: Update CZO links from stream to channel in docs and comments. 2024-06-11 10:44:31 -07:00
message_list.test.js message_list: Rename narrowed property. 2024-05-30 11:41:13 -07:00
message_store.test.js message_events: Remove message from message_store on deletion. 2024-06-27 14:59:45 -07:00
message_view.test.js mentions view: Rename stream -> channel in empty view placeholder. 2024-07-09 16:18:17 -07:00
muted_users.test.js i18n: Localize date and time displays across the app. 2023-02-26 17:43:47 -08:00
narrow_activate.test.js narrow: Rename to message_view. 2024-06-05 12:03:59 -07:00
narrow_local.test.js narrow: Rename to message_view. 2024-06-05 12:03:59 -07:00
narrow_state.test.js narrow_state: Remove narrowed_to_topic function. 2024-05-24 10:24:16 -07:00
narrow_unread.test.js narrow_state: Use message_lists.current to return current filter. 2024-02-24 08:31:18 -08:00
navbar_alerts.test.js page_params: Split out state data for realm. 2024-02-15 10:22:52 -08:00
notifications.test.js ui_util: Fix HTML injection bug in replace_emoji_with_text. 2024-04-03 13:11:47 -07:00
password.test.js password_quality: Convert .data("minLength") et al. to .attr. 2024-05-03 12:45:46 -07:00
peer_data.test.js page_params: Split out state data for current user. 2024-02-15 10:22:52 -08:00
people_errors.test.js people: Remove string type for user_id. 2024-01-19 17:54:07 -08:00
people.test.js settings: Add two realm settings to restrict direct messages. 2024-07-08 19:34:17 -07:00
pill_typeahead.test.js set_up_stream: Update sorter function. 2024-06-27 15:29:47 -07:00
pm_conversations.test.js pm_conversation: Add new has_conversation helper. 2024-07-02 19:02:41 -07:00
pm_list_data.test.js pm_list: Add search to direct message section. 2024-07-08 13:17:05 -07:00
pm_list.test.js left_sidebar: Remove #direct-messages-sticky-header. 2024-07-08 11:43:02 -07:00
poll_widget.test.js settings: Use page_params.is_spectator field for spectator checks. 2024-06-14 17:11:23 -07:00
popover_menus_data.test.js actions_popover: Rename "View message source". 2024-04-11 15:57:24 -07:00
presence.test.js settings: Use page_params.is_spectator field for spectator checks. 2024-06-14 17:11:23 -07:00
reactions.test.js message_helper: Set clean reactions when processing the raw message. 2024-05-29 16:45:36 -07:00
realm_playground.test.js pygments_data: Move data to typescript. 2024-01-24 17:06:03 -08:00
recent_senders.test.js message_util: Convert module to typescript. 2024-01-05 10:47:12 -08:00
recent_view.test.js recent_view: Let browser handle tab hotkey. 2024-06-25 14:12:19 -07:00
reload_state.test.js
reload.test.js node tests: Use noop helper function pattern in test files. 2023-12-14 14:51:33 -08:00
rendered_markdown.test.js markdown_timestamp: Remove incorrect space. 2024-06-20 16:04:30 -07:00
resolved_topic.test.js
rtl.test.js
scheduled_messages.test.js compose_send_menu_popover: Rename module to reflect broader uses. 2024-04-20 13:27:25 -07:00
scroll_util.test.js refactor: Move simplebar helper functions from ui to scroll_util. 2023-04-26 12:59:08 -07:00
search_suggestion.test.js search pills: Don't show invalid terms in search suggestions. 2024-07-09 17:08:45 -07:00
search.test.js search pills: Keep search terms as free text instead of pills. 2024-07-09 17:08:45 -07:00
server_events.test.js echo: Use newly created MessageWithBooleans in insert_local_message. 2024-06-03 12:25:08 -07:00
settings_bots.test.js web: Replace realm_uri with realm_url in frontend files. 2024-06-03 10:07:10 -07:00
settings_config.test.js web-stream-settings: Update strings for stream rename channel. 2024-04-24 14:35:04 -07:00
settings_data.test.js theme: Rename day->light and night->dark in the frontend code. 2024-06-27 16:24:49 -07:00
settings_emoji.test.js
settings_muted_users.test.js node tests: Use noop helper function pattern in test files. 2023-12-14 14:51:33 -08:00
settings_org.test.js settings: Update save discard buttons when live-updating. 2024-07-01 15:30:21 -07:00
settings_profile_fields.test.js settings_profile_fields: Convert Module to TypeScript. 2024-05-20 11:17:58 -07:00
settings_realm_domains.test.js settings_realm_domains: Fix implicit use of any. 2024-05-03 15:39:55 -07:00
settings_user_topics.test.js settings_user_topics: Fix implicit use of any. 2024-05-03 15:39:55 -07:00
spoilers.test.js rendered_markdown: Convert module to typescript. 2024-01-19 17:54:07 -08:00
starred_messages.test.js js: Rename top_left_corner.js to left_sidebar_navigation_area.js. 2023-07-24 13:02:28 -07:00
stream_create_subscribers_data.test.js stream_create: Soft remove users on clicking the remove button. 2024-06-28 15:35:56 -07:00
stream_data.test.js invite: Replace stream checkboxes list with stream pills. 2024-06-22 20:04:28 -07:00
stream_edit.test.js
stream_events.test.js channel: Don't show "You subscribed to" bookend on channel creation. 2024-07-11 09:51:55 -07:00
stream_list_sort.test.js left_sidebar: Add colon : to the list of stream word separators. 2024-05-03 09:20:53 -07:00
stream_list.test.js eslint: Fix no-jquery/no-append-html errors that need test changes. 2024-04-04 10:11:57 -07:00
stream_pill.test.js invite: Replace stream checkboxes list with stream pills. 2024-06-22 20:04:28 -07:00
stream_search.test.js stream_list: Convert module to typescript. 2024-02-23 16:18:48 -08:00
stream_settings_ui.test.js stream_settings: Add Not subscribed tab to stream settings. 2024-06-04 09:49:50 -07:00
stream_topic_history.test.js stream_topic_history: Ask server for last msg id for historical topics. 2024-06-30 22:37:46 -07:00
submessage.test.js submessage: Replace bogus test data with valid objects. 2024-03-28 12:59:12 -07:00
support.test.js support: Fix implicit use of any. 2024-05-03 15:39:55 -07:00
templates.test.js hotkeys: Show Level 2 Shift key symbol for Shift key in popovers. 2024-04-11 15:57:24 -07:00
time_zone_util.test.js time_zone_util: Avoid relying on timeZoneName: "longOffset". 2023-11-29 09:57:10 -08:00
timerender.test.js timerender: Fix should_display_profile_incomplete_alert. 2024-07-09 16:42:23 -07:00
topic_generator.test.js topic_generator: Convert module to typescript. 2024-01-28 14:20:45 -08:00
topic_link_util.test.js composebox_typeahead: Avoid generating broken stream-topic links. 2024-06-24 18:14:33 -07:00
topic_list_data.test.js left_sidebar: Open topic menu when clicking on follow topic icon. 2024-07-05 16:36:49 -07:00
transmit.test.js message_list: Don't always cache "Combined feed" view. 2024-04-25 09:20:43 -07:00
typeahead_helper.test.js compose_typeahead: Show emojis in stream description typeahead. 2024-07-05 15:26:36 -07:00
typeahead.test.js typeahead: Rework sort_emojis function. 2024-07-07 11:33:41 -07:00
typing_data.test.js settings: Add option to disable seeing typing notifications. 2024-04-16 11:38:12 -07:00
typing_events.test.js narrow_state: Use message_lists.current to return current filter. 2024-02-24 08:31:18 -08:00
typing_status.test.js typing_status: Use TypeScript unions for 'Recipient' type. 2024-02-07 09:12:49 -08:00
ui_util.test.js notifications: Collapse blockquotes and "user said" paragraphs. 2024-01-30 17:22:20 -08:00
unread.test.js user_topics: Always store stream name in UserTopic. 2024-03-30 16:25:34 -07:00
upload.test.js upload: Fix TypeScript noUncheckedIndexedAccess errors. 2024-05-30 15:54:49 -07:00
user_events.test.js settings_users: Add live-update on deactivation & reactivation. 2024-06-17 17:16:21 -07:00
user_group_pill.test.js settings: Refactor UserGroupPill to improve consistency. 2024-05-17 10:47:22 -07:00
user_groups.test.js group-settings: Handle invalid urls correctly. 2024-02-22 13:09:33 -08:00
user_pill.test.js typeahead: Nest User inside UserPillData, UserOrMention. 2024-06-06 15:24:54 -07:00
user_search.test.js web: Convert .data("search-results-empty") to .attr. 2024-05-03 12:45:46 -07:00
user_status.test.js emoji: Restrict reaction_type for compatibility with typeahead.Emoji. 2024-05-16 14:51:28 -07:00
user_topics.test.js user_topics: Always store stream name in UserTopic. 2024-03-30 16:25:34 -07:00
util.test.js visibility_policy_popover: Hide popover only when request is successful. 2024-06-04 15:56:44 -07:00
vdom.test.js eslint: Fix no-jquery/no-append-html errors that need test changes. 2024-04-04 10:11:57 -07:00
watchdog.test.js watchdog: Handle exception in callback. 2023-11-19 15:04:58 -08:00
widgetize.test.js widgets: Cache event handler instead of entire jquery for each widget. 2024-05-08 16:47:07 -07:00
zblueslip.test.js
zjquery.test.js