mirror of
https://github.com/zulip/zulip.git
synced 2026-07-09 21:21:47 +08:00
7258a2caaf
The save-discard was not being hidden properly in the below case- - The "Default language for code blocks" setting was disabled initially (i.e. the "Disable" option was selected in the dropdown), meaning there was not default language set. - The setting is then udpated to "javascript" and the save-discard widget is shown as expected. - The setting is then again change to "Disable" option. The save-discard widget should have been hidden after the last step, but it does not. This was because while comparing the old and new value, the new value (obtained using get_dropdown_list_widget_setting_value) was computed as "null" while the old value (obtained from page_params) was an empty string "". This commit fixes the bug by changing get_dropdown_list_widget_setting_value to return empty string "", instead of null, when the "Disable" option is selected in the dropdown. The "get_dropdown_list_widget_setting_value" function was returning null previously, as we supported both null and empty string "" to represent the state of no language selected, with null being the initial value and empty string being used if user changed the setting to some language and then disabled it again. This was changed in #26275 and the state of not setting any default language for code blocks is now represented using empty string in all cases. |
||
|---|---|---|
| .. | ||
| e2e-tests | ||
| generated | ||
| html | ||
| images | ||
| shared | ||
| src | ||
| styles | ||
| templates | ||
| tests | ||
| third | ||
| .browserslistrc | ||
| .gitignore | ||
| babel.config.js | ||
| debug-require-webpack-plugin.ts | ||
| debug-require.js | ||
| postcss.config.js | ||
| webpack.assets.json | ||
| webpack.config.ts | ||
| webpack.dev-assets.json | ||