mirror of
https://github.com/zulip/zulip.git
synced 2026-06-12 21:00:58 +08:00
6c1a8185aa
`setup_path()` previously only checked that some `zulip-py3-venv` was the `sys.prefix`, not that it was the one associated with this deployment. When `uwsgi` is started, it is started from `bin/uwsgi` within a `zulip-py3-venv` virtualenv, and as such sets `sys.executable` to that, resulting in uwsgi workers picking up the library path of that virtualenv. On first start, `sys.path` thus already matches the expected virtualenv, and the `setup_path` in `zproject.wsgi` does nothing. If a rolling restart was later done into a deployment with a different virtualenv, the `zproject.wsgi` call to `setup_path()` did not change `sys.path` to the new virtualenv, since it was already running within _a_ virtualenv. This led to dependency version mismatches, and potentially even more disastrous consequences if the old (but still erroneously in use) virtualenv was later garbage-collected. PR #26771 was a previous attempt to resolve this, but failed due to not thinking of the uwsgi binary itself as possibly providing a virtualenv path. We leave the `chdir` hooks from that in-place, since it cannot hurt for the "master" uwsgi process to be chdir'd to `/`, and the `hook-post-fork` `chdir` is reasonable as well. Resolve the virtualenv in `setup_path()`, and activate it if it differs from the one that is currently active. To be sure that no other old virtualenvs are used, we also filter out any paths which appear to be from other Zulip virtualenvs. |
||
|---|---|---|
| .. | ||
| __init__.py | ||
| build-groonga | ||
| build-pgroonga | ||
| check_rabbitmq_queue.py | ||
| check-database-compatibility | ||
| clean_emoji_cache.py | ||
| clean_node_cache.py | ||
| clean_unused_caches.py | ||
| clean_venv_cache.py | ||
| create-production-venv | ||
| email-mirror-postfix | ||
| fix-standalone-certbot | ||
| hash_reqs.py | ||
| install | ||
| install-node | ||
| node_cache.py | ||
| puppet_cache.py | ||
| pythonrc.py | ||
| queue_workers.py | ||
| run_hooks.py | ||
| setup_path.py | ||
| setup_venv.py | ||
| setup-apt-repo | ||
| setup-yum-repo | ||
| sharding.py | ||
| supervisor.py | ||
| supported-os | ||
| unpack-zulip | ||
| update-git-upstream | ||
| upgrade-zulip | ||
| upgrade-zulip-from-git | ||
| upgrade-zulip-stage-2 | ||
| upgrade-zulip-stage-3 | ||
| warn-rabbitmq-nodename-change | ||
| zulip_tools.py | ||