mirror of
https://github.com/zulip/zulip.git
synced 2026-07-06 21:18:58 +08:00
03897c42e1
On visiting 'https://chat.zulip.org/?show_try_zulip_modal', a 'try zulip' modal is displayed to spectators. Previously, the modal flashed briefly and disappeared. Reason: Earlier, in 'ui_init.js' we called 'show_try_zulip_modal' followed by a network call - which on success called 'initialize_everything'. 'hashchange.initialize' (in 'initialize_everything') closes any active modal. So, the race between 'show_try_zulip_modal' & 'hashchange.initialize' was resulting in this flash. Fix: We call 'show_try_zulip_modal' only after 'initialize_everything' completes - there's no point to try to display modal when the loading screen is still visible to users. |
||
|---|---|---|
| .. | ||
| e2e-tests | ||
| generated | ||
| html | ||
| images | ||
| server | ||
| shared | ||
| src | ||
| styles | ||
| templates | ||
| tests | ||
| third | ||
| .browserslistrc | ||
| .gitignore | ||
| babel.config.js | ||
| debug-require-webpack-plugin.ts | ||
| debug-require.cjs | ||
| postcss.config.js | ||
| webpack.assets.json | ||
| webpack.config.ts | ||
| webpack.dev-assets.json | ||