mirror of
https://github.com/zulip/zulip.git
synced 2026-06-03 21:01:43 +08:00
Drop the universal h1, h2, h3, h4 selectors carried over from Bootstrap 2.3.2. Earlier commits in this series made every scoped heading rule that depended on these resets self-sufficient, so this deletion is purely a no-op for visible behavior. Removed properties were: * margin: 10px 0 (now set explicitly on .overlay-messages-header h1, .settings-header h1, .settings-section h3, .drafts-list h2 / .message-edit-history-list h2, .empty-feed-notice-title, .poll-question-header / .todo-task-list-title-header, and .group-assigned-permissions .group-permissions-section > h3) * line-height: 20px / var(--header-line-height) (now set explicitly on the same rules where it was load-bearing — overlay headers, user-profile modal h3s, folder-channels-list-header, etc.) * font-size: 38.5px/31.5px/24.5px/17.5px (overridden in every place the app actually rendered these headings; only one bare instance per overlay needed an explicit replacement, captured above) * font-weight: bold (matches the user-agent default for h1-h6 — no replacement needed; .light's 'font-weight: 300' override now competes only with the UA default, preserving its current effect) * color: inherit, font-family: inherit, text-rendering: optimizelegibility (no-ops vs. UA defaults; no replacement needed) The .alert h4 rules at the bottom of the file are part of the alert component, not the heading reset, and remain in place. The --header-line-height variable in app_variables.css is still used by modal.css (height: calc(100% - var(--header-line-height))) and by several of the explicit replacements above, so it stays. Verified with a Puppeteer-based computed-style sweep: settings overlay (Account, Notifications, Preferences, Org permissions, Org profile), drafts and scheduled-messages overlay headers, and the empty-feed notice all render identical font-size, line-height, margin, font-weight, and bounding-box dimensions before and after this series. |
||
|---|---|---|
| .. | ||
| bootstrap/css | ||
| marked | ||