CodeCow/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2026-07-06 21:18:58 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity
53,285 Commits 32 Branches 166 Tags 782 MiB
fd01ebdc5d
Commit Graph

1702 Commits

Author SHA1 Message Date
Karl Stolley
fd01ebdc5d vdots: Simplify colors in streamlined selectors on left sidebar. 
This expresses the colors for vdots icons in just three variations,
all as CSS variables. The colors are all derived from the existing
design, and the dots colors in the streams/topics area was used as
as reference. The only visual change here, then, is to the global
filters area, whose vdots were the outliers prior to this change.

The three variations are:

1. hint: for touchscreens where a :hover state is not available
2. visible: for all screens when a parent element is highlighted
3. hover: for when the vdots themselves are hovered

The selectors have been streamlined to use the .sidebar-menu-icon
utility class, and the hover-within-a-hover color on vdots is
expressed more directly, eliminating the need for
selector-specificity busting via !important.

Fixes: #20600
 2023-09-18 09:06:33 -07:00
Karl Stolley
5a476d06c3 sidebars: Add sidebar-menu-icon util class. 2023-09-18 09:06:33 -07:00
Karl Stolley
a764c15bcb icons: Express global filter icons as colors. 2023-09-18 09:06:33 -07:00
Aman Agrawal
b845ef5091 recent_view: Show empty text after rerenders too. 
Fixes #26746

There was a bug which caused empty text to not appear after
rerender since tbody didn't have the `required-text` class on
rerenders as it was not part of the handlebars template.
 2023-09-18 08:01:58 -07:00
Aman Agrawal
19056db88b inbox: Show text if inbox is empty. 2023-09-18 08:01:58 -07:00
Aman Agrawal
4791e9f2fa inbox: Remove unused variable. 2023-09-18 08:01:58 -07:00
Aman Agrawal
05e133156e inbox: Make borders span full height. 2023-09-18 08:01:58 -07:00
Anders Kaseorg
88e9320fa5 list_widget: Rename unsafe modifier parameter to modifier_html. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2023-09-15 18:11:50 -07:00
Anders Kaseorg
500e6bfdef user_card_popover: Add missing $ prefix for jQuery object variable. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2023-09-15 14:14:50 -07:00
Anders Kaseorg
c6b60f6490 dependencies: Upgrade JavaScript dependencies. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2023-09-15 14:09:49 -07:00
Daniil Fadeev
91d2b5ed81 user_group_popover: Migrate popover to Tippy. 
Fixes part of #23632.
 2023-09-15 13:40:53 -07:00
Daniil Fadeev
e52188bd41 user_group_popover: Fix blueslip error messages. 2023-09-15 13:40:53 -07:00
Daniil Fadeev
a678aee467 popovers: Apply styles for hr tag not just when nested under .nav. 
We've got `hr` elements not just under `ul.nav`, like in
`user_group_info_popover`, so we need to apply styles there too.
 2023-09-15 13:40:53 -07:00
Prakhar Pratyush
fa063e4afc typeahead: Suggest only the first matching wildcard mention. 
We suggest only the first matching wildcard mention,
irrespective of how many equivalent wildcard mentions match.

This helps to avoid suggesting multiple wildcard mentions at
the same time that do the same thing but have different names.

Fixes #25613.
 2023-09-15 13:22:35 -07:00
Aman Agrawal
fe2d6c07fb recent_view: Reduce width of unread header. 2023-09-15 13:20:45 -07:00
Karl Stolley
c49ab123b2 icons: Remove unused move and source icons. 
These were early candidates in the hover-controls work, but were
superseded by their "alt" counterparts.
 2023-09-15 13:17:22 -07:00
Karl Stolley
3fe6cc18ff icons: Remove last vestiges of ellipsis-v-solid. 
The deleted CSS around the `.zulip-icon-ellipsis-v-solid` class
has no impact on the hover controls, as flexbox and grid are
handling baseline alignment, not this one-off line-height.
 2023-09-15 13:17:22 -07:00
Hardik Dharmani
3c89fe222a refactor: Rename private_message to direct_message. 
This commit renames all uses of `private_message` in `unread.js` to
`direct_message`. Renamed `private_message_count` to
`direct_message_count` and `right_sidebar_private_message_count` to
`right_sidebar_direct_message_count`.
 2023-09-15 12:37:09 -07:00
Hardik Dharmani
b8d84abc47 unread: Fix double counting of mentions in direct messages. 
Created a new set `direct_message_with_mention_count` which stores direct
messages containing mentions. In `new_message_count`, direct messages
with mention were added twice, once by res.mentioned_message_count
and once by res.private_message_count so subtracting intersection of
both `direct_message_with_mention_count` now gives accurate count.

Fixes #25453
 2023-09-15 12:37:09 -07:00
Aman Agrawal
3c05bd94a4 inbox: Don't search if there is no change in text. 2023-09-15 12:34:59 -07:00
Aman Agrawal
a0e3f66dc1 inbox: Center focused element if off screen when using keyboard. 2023-09-15 12:34:59 -07:00
Aman Agrawal
7bce78694e inbox: Move scrolling container to html. 2023-09-15 12:34:59 -07:00
Aman Agrawal
c8f363fd45 inbox: Add additional element around rows to apply border-radius. 2023-09-15 12:34:59 -07:00
Aman Agrawal
55eb0e4e07 inbox: Use blue box to indicate focus. 2023-09-15 12:34:59 -07:00
Aman Agrawal
f16273c488 hotkey: Change inbox hotkey from shift + t to shift + i. 
Also, add that as a tippy tooltip in left sidebar.
 2023-09-15 12:34:59 -07:00
Daniil Fadeev
d96110590b playground_links: Migrate popover to Tippy. 
Fixes part of #23632.
 2023-09-15 12:25:26 -07:00
Daniil Fadeev
79e050b81b playground_links: Fix disappearing reference when popover is active. 2023-09-15 12:25:26 -07:00
Daniil Fadeev
79c6ff91d7 playground_links: Add popover keyboard handling. 2023-09-15 12:25:26 -07:00
Daniil Fadeev
76891ec9ee playground_links: Add is_open function. 2023-09-15 12:25:26 -07:00
Daniil Fadeev
d27448dcec popovers: Rename playground links popover hiding function. 2023-09-15 12:25:24 -07:00
Daniil Fadeev
1782fb6866 popovers: Rename toggle_playground_link_popover function. 2023-09-15 12:25:12 -07:00
Daniil Fadeev
4d41d8bd02 popovers: Extract playground_links_popover into separate module. 2023-09-15 12:25:11 -07:00
Daniil Fadeev
3773f17933 popovers: Remove unused clear_for_testing function. 2023-09-15 12:24:34 -07:00
Daniil Fadeev
f421ea5e0b user_card_popover: Fix comments that describe a block of functions. 2023-09-15 12:24:00 -07:00
Daniil Fadeev
d2bc1f1bcf user_card_popover: Rename focus_user_info_popover_itemfunction. 2023-09-15 12:24:00 -07:00
Daniil Fadeev
e66eeb4444 user_card_popover: Rename item getter functions. 
Renamed functions:
`get_user_info_popover_items` -> `get_user_card_popover_items`
`get_user_info_popover_for_message_items` ->
`get_user_card_popover_for_message_items`
`get_user_info_popover_manage_menu_items` ->
`get_user_card_popover_manage_menu_items`
 2023-09-15 12:24:00 -07:00
Daniil Fadeev
27eb545af2 user_card_popover: Rename hiding functions. 
Renamed functions:
`hide_message_info_popover` -> `hide_message_user_card_popover`
`hide_all_user_info_popovers` -> `hide_all_user_card_popovers`
`hide_user_info_popover` -> `hide_user_card_popover`
`hide_user_info_popover_manage_menu` ->
`hide_user_card_popover_manage_menu`
 2023-09-15 12:24:00 -07:00
Daniil Fadeev
626127451b user_card_popover: Rename toggling and rendering functions. 
Renamed functions:
`toggle_user_info_popover` -> `toggle_user_card_popover`
`toggle_user_info_popover_for_message` ->
`toggle_user_card_popover_for_message`
`toggle_user_info_popover_manage_menu` ->
`toggle_user_card_popover_manage_menu`
`render_user_info_popover` -> `render_user_card_popover`
 2023-09-15 12:24:00 -07:00
Daniil Fadeev
c579e5fffa user_card_popover: Rename popover elements. 
Renamed elements:
`$current_user_info_popover_elem` -> `$current_user_card_popover_elem`
`$current_message_info_popover_elem` ->
`$current_message_user_card_popover_elem`
`$current_user_info_popover_manage_menu` ->
`$current_user_card_popover_manage_menu`
 2023-09-15 12:24:00 -07:00
Daniil Fadeev
7b1abd108b user_card_popover: Rename keyboard handling functions. 
Renamed functions:
`user_info_popover_handle_keyboard` ->
`user_card_popover_handle_keyboard`
`user_info_popover_manage_menu_handle_keyboard` ->
`user_card_popover_manage_menu_handle_keyboard`
`user_info_popover_for_message_handle_keyboard` ->
`user_card_popover_for_message_handle_keyboard`
 2023-09-15 12:24:00 -07:00
Daniil Fadeev
4531386e99 user_card_popover: Rename "*_popped" functions. 
Renamed functions:
`user_info_popped` -> `is_user_card_open`
`message_info_popped` -> `is_message_user_card_open`
`user_info_manage_menu_popped` -> `is_user_card_manage_menu_open`
 2023-09-15 12:24:00 -07:00
Daniil Fadeev
e0a5d8dc49 user_card_popover: Rename user_info_popover_manage_menu class. 2023-09-15 12:24:00 -07:00
Daniil Fadeev
8949ed41b7 user_card_popover_content: Fix template description. 2023-09-15 12:24:00 -07:00
Daniil Fadeev
228a4eb8a2 user_card_popover: Rename user_info_popover class. 2023-09-15 12:24:00 -07:00
Daniil Fadeev
b9e1537ee6 user_card_popover: Rename user_info_status_text class. 2023-09-15 12:24:00 -07:00
Daniil Fadeev
d5f731f0bd user_card_popover: Rename user-info-popover class. 2023-09-15 12:24:00 -07:00
Daniil Fadeev
ff892925ce user_card_popover: Rename info_popover_actions class. 2023-09-15 12:24:00 -07:00
Daniil Fadeev
7c3f79df0d user_card_popover: Rename user_info_popover_manage_menu_btn class. 2023-09-15 12:24:00 -07:00
Daniil Fadeev
a8bce8e178 user_card_popover: Rename user_info_popover_action_buttons class. 2023-09-15 12:24:00 -07:00
Daniil Fadeev
7ce1ee784c user_card_popover: Rename for_user_info_popover template variable. 2023-09-15 12:24:00 -07:00