CodeCow/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2026-07-06 21:18:58 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity
22,108 Commits 32 Branches 166 Tags 782 MiB
cf1a4540ef
Commit Graph

2379 Commits

Author SHA1 Message Date
Tim Abbott
0d1194811f mypy: Remove ignores for a few typeshed bugs fixed upstream. 2017-10-27 17:09:00 -07:00
Tim Abbott
8d00111a27 vagrant: Skip the shell virtualenv warning on provision. 2017-10-27 11:44:47 -07:00
rht
e296841447 tools/documentation_crawler: Use python 3 syntax for typing. 2017-10-26 21:58:22 -07:00
Tim Abbott
8e2cdedf9a lint: Fix lines in Python codebase longer than 120 characters. 2017-10-26 17:47:30 -07:00
Tim Abbott
b936e8c24b lint: Fix lines in Python codebase longer than 125 characters. 2017-10-26 17:36:54 -07:00
Tim Abbott
be619fe881 lint: Wrap many very long lines in the Python codebase. 
This decreases the maximum line length in our Python codebase to 130.
 2017-10-26 17:31:58 -07:00
Greg Price
4a6e867046 lint: Disable a buggy pep8 rule on line breaks and operators. 
I'd much rather see something like

    if (thing_is_permissible(user, thing)
            or (user_possesses_hammer(user)
                and glass_break_requested(thing))):

than

    if (thing_is_permissible(user, thing) or
            (user_possesses_hammer(user) and
                glass_break_requested(thing))):

because the former makes the overall logic much easier to scan.
Similarly for a formula full of arithmetic rather than Boolean
operators.  And the actual PEP 8 agrees (though until 2016 it
unfortunately had the opposite advice.)

The upstream linter still applies the backward rule, so disable that.
 2017-10-26 10:29:17 -07:00
Brock Whittaker
a9a9333b2a portico: Show whether the user is logged in. 
This creates a dropdown in place of the normal register/login links
you get when logged out, with an option to go to the app or log out if
that appears you click on the avatar.

A bit more work is needed to make this look really good, but it's a
great start.
 2017-10-25 14:59:24 -07:00
Aditya Bansal
0ddad98c98 features.html: Cleanup to use 4 space and consistant indentation. 2017-10-25 10:58:57 -07:00
Aditya Bansal
3fb0f7c092 home.html: Cleanup to use 4 space indentation. 
Tweaked by tabbott to also make the translation tags make more sense.
 2017-10-25 10:58:49 -07:00
Tim Abbott
618ace1f5c build-release-tarball: Fix missing CSS-inlined email templates. 
These apparently we're being included.
 2017-10-20 14:08:25 -07:00
Tim Abbott
c9e29b1c54 check-templates: Document status of remaining bad_files items. 2017-10-19 16:56:46 -07:00
Tim Abbott
2fb46df005 check-templates: Remove exclude rules for removed HTML files. 
These webhook integrations were converted to using markdown some time
ago.
 2017-10-19 16:56:46 -07:00
Tim Abbott
fc4b87ed04 templates: Clean some whitespace issues in markdown_help. 
Unfortunately, the rest cannot be easily fixed.
 2017-10-19 16:56:46 -07:00
Tim Abbott
e80fc93e87 templates: Fix search_operators indentation. 2017-10-19 16:56:46 -07:00
Tim Abbott
59344d77df templates: Clean various items off HTML linter bad list. 
Most of these already pass the linter; for the ones that don't, the
fixes are small and don't make the HTML any worse.
 2017-10-19 16:56:00 -07:00
Tim Abbott
540cae19a8 puppet: Remove obsolete sparkle configuration. 
Sparkle was the auto-update system used by the legacy desktop app.  We
haven't been capable of using it for auto-update in years, so there's
no reason to keep around the configuration.

The new Electron app uses a different system anyway.
 2017-10-19 16:35:55 -07:00
Tim Abbott
4ddb812354 check_subdomain: Remove case for user_subdomain being None. 
With REALMS_HAVE_SUBDOMAINS always on, user_subdomain is never None,
so this was just dead code.
 2017-10-18 22:35:07 -07:00
Tim Abbott
1ab2ca5986 subdomains: Extract zerver.lib.subdomains library. 
These never really belonged with the rest of zerver.lib.utils.py, and
having a separate library makes it easier to enforce full test
coverage.
 2017-10-18 22:27:48 -07:00
rht
c8090aafa4 lint: Remove several unused imports. 2017-10-18 10:56:11 -07:00
Tim Abbott
fe3a8084d8 mypy: Fix annotations for linter. 2017-10-18 10:50:25 -07:00
Tim Abbott
2bc14d256f lint: Ban two spaces after comma in JS code. 
We exclude the frontend tests, mostly because the lint rule isn't that
precise, and the test code has some sample user input that's a bit
funny.
 2017-10-18 10:22:18 -07:00
Tim Abbott
8afe9835f6 lint: Ban two spaces after comma in prose. 2017-10-18 10:12:41 -07:00
Tim Abbott
b634d9f38b lint: Ban two spaces after comma in CSS. 2017-10-18 10:11:33 -07:00
derAnfaenger
194e102077 linter: Add rule against multiple whitespaces after comma. 2017-10-18 10:04:23 -07:00
rht
691598a88b py3: Remove "from six.moves import range". 
This is no longer required, since in Python 3, this is what the range
built-in does.
 2017-10-17 23:28:14 -07:00
rht
a603a4f9f5 Remove from __future__ import absolute_import. 
Except in:
- docs/writing-bots-guide.md, because bots are supposed to be Python 2
  compatible
- puppet/zulip_ops/files/zulip-ec2-configure-interfaces, because this
  script is still on python2.7
- tools/lint
- tools/linter_lib
- tools/lister.py

For the latter two, because they might be yanked away to a separate repo
for general use with other FLOSS projects.
 2017-10-17 22:59:42 -07:00
Tim Abbott
bcca964548 test-js-with-node: Fix doing too many imports before sanity_check. 
This wasn't benefitting from the nice error message.
 2017-10-17 22:22:00 -07:00
rht
9c5e0971f4 sanity_check: Check a few packages. 
This just makes our check for whether we're actually in a Zulip
development environment better.
 2017-10-17 22:21:33 -07:00
Tim Abbott
508686bed4 provision: Fix buggy bash_profile management code. 
Apparently, the previous version would just append to .bash_profile
every single time :(.
 2017-10-17 21:22:32 -07:00
Tim Abbott
3fed995a41 provision_version: Move to under UUID_VAR_PATH. 2017-10-17 21:15:58 -07:00
Tim Abbott
3983ebce9a test_fixtures: Move test_db_status state under UUID_VAR_PATH. 
This should mean that maintaining two Zulip development environments
using the same Git checkout no longer has caching problems keeping
track of the migration status.
 2017-10-17 21:15:58 -07:00
Tim Abbott
b7c3b4df0c migration_status: Switch to passing the path in Python. 
This is an important prerequisite to changing these paths used in
provisioning.
 2017-10-17 21:15:58 -07:00
Tim Abbott
a7c639cff7 provision: Use UUID in path to compilemessages hash. 2017-10-17 21:15:58 -07:00
Tim Abbott
2ae2a94444 provision: Stop using shared var/ for caching apt state. 
This didn't work at all when one did a `vagrant destroy` and then
`vagrant up`, because the cache state would be preserved even though
the machine is gone.

Fixes #5981.
 2017-10-17 21:15:58 -07:00
rht
3e258d11e0 Travis: Use travis.yml built-in way to install moreutils. 2017-10-17 09:59:59 -07:00
derAnfaenger
e1660462e1 linter: Add custom shebang rules section. 
Tweaked by tabbott for clarity and to use print_err.
 2017-10-12 11:21:38 -07:00
Tim Abbott
6176d0fbca json: Replace most use of simplejson with json. 
This is progress towards removing simplejson as a dependency.
 2017-10-11 22:55:35 -07:00
Harshit Bansal
f8b103bd98 tools: Add a test for checking locked requirements. 
This commit adds a test to check if the user forgot to run
`tools/update-locked-requirements` after updating dependencies.

Modified by tabbott to disable it by default, since it takes over a
minute to run.

Fixes: #6324.
 2017-10-11 22:55:15 -07:00
Harshit Bansal
0391619f48 tools: Modify update-locked-requirements to take optional arguments. 
This commit modifies the `update-locked-requirements` tool to take
output file path as optional arguments.
 2017-10-11 22:44:54 -07:00
Tim Abbott
bfaf0fb3b2 build-release-tarball: Stop using .gitattributes. 
Unfortunately, GitHub's web UI for generating release tarballs uses
`.gitattributes` to control what files to download, and thus if you
downloaded a source tarball for older Zulip versions using the GitHub
web UI, you'd be missing important files.

We fix this for future releases by moving the blacklist out of
.gitattributes.

Fixes #129.
 2017-10-11 21:51:42 -07:00
Tim Abbott
80e50f4b57 test-backend: Add goal of full coverage on zerver/*.py. 
Like the zerver/lib changes, this should help make the backend
coverage TODO list a bit more explicit.
 2017-10-11 20:17:37 -07:00
Tim Abbott
ce579d5896 test-backend: Make test coverage gaps in zerver/lib more explicit. 
This will make it much less likely that we'll have more regressions of
files losing 100% test coverage like push_notifications.py had
recently.
 2017-10-11 20:17:37 -07:00
Tim Abbott
676a6af8cb push_notifications: Get back to 100% test coverage. 
We didn't have tests for a few new code paths.
 2017-10-11 20:17:27 -07:00
derAnfaenger
f6834bb60e tools: Remove .pl extension from user script. 2017-10-11 12:52:36 -07:00
derAnfaenger
d556f677b2 tools: Consistently use hyphen in user script names. 2017-10-11 12:52:36 -07:00
derAnfaenger
61aebd036f tools: Remove .py extensions from user scripts. 2017-10-11 12:52:36 -07:00
derAnfaenger
df948c7ea5 Remove useless shebang lines. 2017-10-11 12:52:36 -07:00
neiljp (Neil Pilgrim)
c04ff1cc79 mypy: Any->Call in create_single_page() in create-test-api-docs. 2017-10-11 12:16:50 -07:00
Tim Abbott
baee129eda lint: Exclude style= rules for email log. 
This is temporary, because this PR was written before these rules were
put in place.
 2017-10-11 10:41:40 -07:00