The web/src/banners.ts module, was trigger the window resize event for
every banner, which led to unexpected UI bugs and performance issues.
This follow-up commit for 7a96cec774,
restricts the window resize event to only the navbar banners, where
there is a need to recalculate the navbar-fixed-container height and
adjust the UI accordingly.
Resizes are very disruptive, and are not required for most
banners. The one exception is the top-of-window banners, which ideally
would also not require a resize, but do impact the geometry of space
available to other components.
Fixes#33570
When navigating to a narrow based on locally available unread
data with `old_unreads_missing`, we verify the calculated
first unread message id with server and if there is an unread message
prior to the one we calculated locally, we convert the current
narrow into a `near` narrow and show a banner with a button to
allow user to navigate to the correct first unread message.
The bug occurred because clicking on .message-editing-animation was
not triggering the click on .edit-notifications. This commit prevents
this behaviour by setting its property pointer-events to none.
Fixes: #33950
This commit adds a hidden `topic_value_mirror` span element, and uses
that to dynamically set the width of the input field to the width of
the topic text inside it + some cushion.
Fixes#33844.
Add a warning banner when a user mentions a group (non-silent) where none
of the members are subscribed to the current stream. The banner informs
the user that the mention won't notify anyone.
Fixes#33545.
This commit adds a one-time modal to display navigation tour
video to new users.
Includes an `NAVIGATION_TOUR_VIDEO_URL` server-setting to specify
the video's URL. When set to None, the modal is not displayed.
Fixes#29304.
This commit adds support to the DialogWidget to ignore
the clicks on the overlay and NOT close.
This will be helful in navigation-tour-video dialog widget.
This commit updates populate_db to mark all onboarding steps as seen
for existing users to avoid unnecessary popups during development.
Developers should create a new user in development environment
to test the onboarding steps.
Fixes#31315.
We want to parse sender:me with the email when turning it into
a pill, but not before then so that "Sent by me" is still the
search string in the suggestions.
This is a follow-up to commit cd08c628ba,
and adds the missing `pointer-events: auto` property to the blueslip
error overlay. This makes the blueslip error overlay interactable again.
Earlier, we used to show "general chat" as the placeholder.
This commit adds support to show "Enter a topic (skip for general
chat)" as the placeholder when topic is not mandatory in the
inline topic edit input box.
We show "general chat" (as we show in compose topic input box)
when inline topic edit input box is not focused and topic="".
Fixes part of #33846.
When changing font size using controls in personal menu popover
and gear menu popover for spectators, font size of popover is
not change so that buttons do not shift.
Also, arrow shown with the popover is removed once font-size
is changed, as popover will be detached from the element which
was clicked to open it.
Zulip production suite / ${{ matrix.name }} (zulip/ci:bookworm, --test-custom-db, Debian 12 production install with custom db name and user, bookworm) (push) Has been cancelled
Zulip production suite / ${{ matrix.name }} (zulip/ci:jammy, , Ubuntu 22.04 production install and PostgreSQL upgrade with pgroonga, jammy) (push) Has been cancelled
After testing the previous commit a bit more, it appears to me that
the typo fix on `first-baseline` that I made was in error; what looks
good and matches the screenshots in the PR was having that line of CSS
be invalid/deleted.
This commit separates the "resolve topic" permissions from the
topic editing permissions, through the introduction of setting -
"can_resolve_topics_group" which user group whose members
can resolve topics.
Fixes#21811
get_display_name_for_system_group_option function was used
to get the display name for "Nobody" group for DM permissions
setting in the dropdown menu. Now we use pill input for DM
permissions setting, so there is no need for that function.
Previously, save discard buttons were shown even when
changing only the order of pills in the widget.
This commit updates get_group_setting_widget_value to
return member and subgroup IDs in sorted order, as
member and subgroup IDs in original values are also
sorted so the save-discard buttons are not visible
when only order is changed.
For some settings, their value in "realm" object and the
corresponding dropdown or pill widget for them were not
being live updated on receiving the event.
This might be dead CSS, in that most spinners have their styles
overwritten by other CSS. But there are a lot of spinners and
this is hard to look into and know for sure (but it would be good
to as a followup eventually).
If the template_id of the message_control_button
is undefined, we do not render the tooltip at all.
This might happen, for example,
when a message is past its editable period and
the edit button is not displayed.
Add the `is:muted` search operator.
`-is:muted` is an alias for the `in:home` operator.
Co-authored-by: Kenneth <Kenneth012004@outlook.com>
Fixes#16943
Previously, mentions from muted channels were incorrectly excluded when
narrowing down to `-in:home`. Additionally, messages from all muted
topics were missing in the results.
This commit solves the above listed issues.
The relevant legacy logic being removed dates to when we didn't
support unmuting or following topics.
Use both the last_moved_timestamp and last_edit_timestamp to show
edited and moved indicators/tooltips in the message list view of
the web app, instead of parsing the message edit history array.
We still maintain and build the message edit history array as it's
used for calculating the narrow terms when there is a near operator
and a message has been moved to a different channel or topic.
Updates the tooltip for message edit indicators to include both
the moved and edited time if a message has been both moved and
edited.
When we build the message_container for the message list view, we
get a boolean value for showing the edit notice (saving, moved, or
edited) on the message, so we now use that for whether we show the
associated message edit tooltip as well.
Also, if the message is modified, then we either have a last edited
timestamp from the server or from a local edit, so it shouldn't be
undefined.
