Earlier, permission in edit panel of channel settings was not the
same as that of org permission, specifically for public channel
option.
This commit fixes that by updating the privacy option state.
Fixes:zulip#34526.
Work towards #34244
This is the only call to `peer_data.is_subscriber_subset`, so after
this commit all calls to that function work with our new model for
partial subscriber data.
Omit<…, "undefined"> removes the "undefined" key from an object. The
intention was clearly Exclude<…, undefined> which removes undefined
from a union, or NonNullable<…> which removes both undefined and null.
However, it’s simpler here to provide the expected type directly.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
Zulip production suite / ${{ matrix.name }} (zulip/ci:bookworm, --test-custom-db, Debian 12 production install with custom db name and user, bookworm) (push) Has been cancelled
Zulip production suite / ${{ matrix.name }} (zulip/ci:jammy, , Ubuntu 22.04 production install and PostgreSQL upgrade with pgroonga, jammy) (push) Has been cancelled
Changes done here are -
- Previously the pill input, "Add" button and tooltip shown
when user did not have permission were not live updated when
updating can_add_subscribers_group and can_subscribe_group
stream level settings or can_add_subscribers_group realm
level setting. This commit fixes that.
- Also, when the UI was live updated to give user permission
to subscribe others, "Add" button was enabled even when
input was empty. This is also fixed in this commit.
This commit refactors code to live update UI for a couple of
group settings by setting the live update functions for those
settings in realm_settings object.
Work towards #34244.
Note that this doesn't show the right counts when the counts appear, because
yet. We can double check functionality after that change is complete.
We have added an ability to partially load subscribers,
and this function name makes it more clear what it returns,
in contrast to an upcoming `get_full_subscriber_set`.
This was added in b387ca4, before we had
`buddy_list.update_empty_list_placeholders`
Now it's not only duplicating that functionality, but will soon
maybe run at the wrong time once the buddy list `populate` starts
making `void` calls to `async` empty list placeholder code.
This commit
- Replace the blank option with an italicized option that's the current
default language, if there is one selected with "default" label.
- Make the "text" option more informative by adding (no highlighting)
to the label.
- Remove the hint for "text".
- Prioritize as left to right, before start typing:
blank/default language, text, quote, spoiler, math, everything else...
fixes: #33682
Removing `.alert` from the dark theme seems acceptable,
as there is nowhere in the codebase we're setting a
`text-shadow` value that would require `none` here.
Updates the example banner in the devtools banner design page
for the changes to the demo organization banner.
This removes all uses of the banner-link class, but we keep the CSS
rules, since they're part of a component we may use elsewhere.
Updates the navbar alert banner for demo organizations to have
buttons that align with the general bannner design.
All users have a button that opens the help center article about
demo organizations. Demo organization owners have an additional
button that opens the modal to convert a demo organization into
a permanent organization.
Part of #34447.
Updates handle_demo_organization_conversion to only set up the
event listeners for the current convert organization banner in
the organization settings overlay for admins.
Moves code for launching the modal to convert the demo organization
to a permanent organization to do_convert_demo_organization.
Prep for adding a button to the navbar alert banner for demo
organization owners that will also launch the modal to convert
the organization.
Moves the get_demo_organization_deadline_days_remaining helper from
"web/src/navbar_alerts.ts" to "web/src/demo_organizations_ui.ts".
Prep commit for updating the navbar alert for demo organization to
have a button that opens the modal for converting the organization
to a permanent organization.
Instead of using the "tip" formatting for the note suggesting
updating the name for the owner's account before inviting other
users, to be just normal text at the top of the modal.
Part of #34447.
Instead of having two separate "create_without_add_button" and
"create" functions for handling creation and editing UI, this
commit updates code to use only "create" function with a
parameter passed to determine whether we want "Add" button with
the widget or not.
For the DM conversation with the current user, use "Messages with
yourself" for the message header bar and tooltip.
Fixes#33321.
Co-authored-by: Lauryn Menard <lauryn@zulip.com>
For the DM conversation with the current user, show "Messages with
yourself" for the title, which is determined by the filter for the
message list view.
Co-authored-by: Lauryn Menard <lauryn@zulip.com>
Adds "You" and "Drafts from conversations with yourself" as
labels in the drafts overlay for the DM conversation with
the current user.
Co-authored-by: Lauryn Menard <lauryn@zulip.com>
