Commit Graph

4623 Commits

Author SHA1 Message Date
Aman Agrawal
b1eef20fd5 tippy: Use data-view-code to check atttribute.
This make it easy to grep for.
2025-01-02 17:25:20 -08:00
Prakhar Pratyush
469cc53187 export: Add banner if admin's private data export setting is disabled.
This commit introduces a banner on the "Start Export" modal
to notify the admin that their personal setting to export
private data is not toggled ON.

The banner is shown when the 'Export type' is 'Standard' and
admin's personal setting to export private data is not toggled ON.

The banner ensures admins are aware their private data will
not be exported unless they enable the respective setting.
2025-01-02 16:40:33 -08:00
apoorvapendse
ddd58b1a14 user_group: Fix broken edit description functionality.
This commit fixes the currently broken feature of being
able to change the group info using the edit icon that
triggers the dialog_widget to let users edit their
group description.

Fixes #32767.
2025-01-02 12:00:06 -08:00
Lauryn Menard
d6db6e3806 invite-modal: Fix invalid custom input to not show "NaN".
Updates the invite modal so that if the custom input is 0, the
submit button is deactivated, since an email invitation or invite
link that immediately expired would be unusable.

Also, updates the custom input to show 0 if a user navigates away
from and back to the custom input option afer putting in an invalid
value, e.g. "abc" or "-20". Previously, the custom input showed
"NaN" in that case.
2024-12-31 16:51:59 -08:00
Anders Kaseorg
6416355952 unread_ops: Extract and correct message_details_schema.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-12-30 09:42:26 -08:00
Anders Kaseorg
6dfa1b6138 types: Extract update_message_event_schema.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-12-30 09:42:26 -08:00
Anders Kaseorg
2548430af3 types: Extract and correct user_group_update_event_schema.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-12-30 09:42:26 -08:00
Anders Kaseorg
4da6db9af8 user_events: Extract user_update_schema.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-12-30 09:42:26 -08:00
Anders Kaseorg
b1be32b1ee typing_events: Extract typing_user_schema and typing_event_schema.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-12-30 09:42:26 -08:00
Anders Kaseorg
20c3a564a7 stream_events: Extract updatable_stream_properties_schema.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-12-30 09:42:26 -08:00
Anders Kaseorg
05040f3814 stream_types: Extract api_stream_schema.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-12-30 09:42:26 -08:00
Anders Kaseorg
7a784265f5 state_data: Extract realm_domain_schema.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-12-30 09:42:26 -08:00
Anders Kaseorg
6ac10f84d0 settings_preferences: Extract user_settings_property_schema.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-12-30 09:42:26 -08:00
Anders Kaseorg
bd93e109b4 settings_exports: Export export_consent_schema and realm_export_schema.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-12-30 09:42:26 -08:00
Anders Kaseorg
8dd3fffeb0 realm_playground: Extract realm_playground_schema.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-12-30 09:42:26 -08:00
Anders Kaseorg
b4f14b4132 presence: Extract presence_info_from_event_schema.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-12-30 09:42:26 -08:00
Anders Kaseorg
8d52e09f18 linkifiers: Extract realm_linkifier_schema.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-12-30 09:42:26 -08:00
Anders Kaseorg
defe5e0128 bot_types: Add user_id to server_update_bot_schema.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-12-30 09:42:26 -08:00
Anders Kaseorg
9ca13fb0a5 attachments: Extract attachment_schema.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-12-30 09:42:26 -08:00
Anders Kaseorg
b19a556982 stream_types: Remove email_address from ApiStreamSubscription.
Commit 432001656e removed this from the
backend.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-12-30 09:42:26 -08:00
Anders Kaseorg
536938eea6 reactions: Remove local_id from ReactionEvent.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-12-30 09:42:26 -08:00
Sahil Batra
8815e7ac79 user_groups: Remove incorrect comment.
There was a comment mentioning get_all_realm_user_groups
was only used in tests, but we now use it to get potential
subgroups of a group, so that comment is removed.
2024-12-30 09:37:32 -08:00
Sahil Batra
f498201141 group-settings: Allow system groups as subgroups when creating groups.
System groups should be shown in typeahead when adding members
to a group during its creation.
2024-12-30 09:37:32 -08:00
Anders Kaseorg
58822372d5 typos: Fix typos caught by typos and mwic.
Some checks failed
Code scanning / CodeQL (push) Has been cancelled
Zulip production suite / Ubuntu 22.04 production build (push) Has been cancelled
Zulip CI / ${{ matrix.name }} (zulip/ci:bookworm, true, false, Debian 12 (Python 3.11, backend + documentation), bookworm) (push) Has been cancelled
Zulip CI / ${{ matrix.name }} (zulip/ci:jammy, false, true, Ubuntu 22.04 (Python 3.10, backend + frontend), jammy) (push) Has been cancelled
Zulip CI / ${{ matrix.name }} (zulip/ci:noble, false, false, Ubuntu 24.04 (Python 3.12, backend), noble) (push) Has been cancelled
Zulip production suite / ${{ matrix.name }} (zulip/ci:bookworm, --test-custom-db, Debian 12 production install with custom db name and user, bookworm) (push) Has been cancelled
Zulip production suite / ${{ matrix.name }} (zulip/ci:jammy, , Ubuntu 22.04 production install and PostgreSQL upgrade with pgroonga, jammy) (push) Has been cancelled
Zulip production suite / ${{ matrix.name }} (zulip/ci:noble, , Ubuntu 24.04 production install, noble) (push) Has been cancelled
Zulip production suite / ${{ matrix.name }} (zulip/ci:bookworm-7.0, 7.0 Version Upgrade, bookworm) (push) Has been cancelled
Zulip production suite / ${{ matrix.name }} (zulip/ci:bookworm-8.0, 8.0 Version Upgrade, bookworm) (push) Has been cancelled
Zulip production suite / ${{ matrix.name }} (zulip/ci:jammy-6.0, 6.0 Version Upgrade, jammy) (push) Has been cancelled
Zulip production suite / ${{ matrix.name }} (zulip/ci:noble-9.0, 9.0 Version Upgrade, noble) (push) Has been cancelled
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-12-24 19:15:36 -08:00
qnhn22
e97572e30b settings: Improve presentation of auto-follow topics settings.
Fixes #32761
2024-12-19 09:06:16 -08:00
opmkumar
5b0c55fda3 realm: Add option to schedule data deletion while deactivating.
Introduce a feature to schedule realm data deletion time during realm
deactivation. This includes a server-level setting to configure the
minimum and maximum allowed deletion days.

Co-authored-by: Ujjawal Modi <umodi2003@gmail.com>
Co-authored-by: Lauryn Menard <lauryn@zulip.com>

Fixes #24677.
2024-12-18 23:06:12 -08:00
Karl Stolley
42f210ee26 move_modals: Better structure and style stream/topic references. 2024-12-18 17:10:45 -08:00
Karl Stolley
af209822a4 move_modals: Update language in headings.
Now that we're able to wrap these to multiple lines, this feels like
the cleanest way to present what we're doing.
2024-12-18 17:10:45 -08:00
Sayam Samal
7a27e0aadd user_group_popover: Fix misaligned icons in user group member list.
Previously, due the uneven width between the icons and the user
presence indicator, the icons and presence indicator were misaligned
with each other.

This commit uses the grid and subgrid layout systems to fix this
misalignment issue.
2024-12-18 17:08:34 -08:00
Sayam Samal
86c0be1cb4 buttons: Add icon-only button styles.
This commit adds the icon-only button styles to the codebase along with
appending this new button style to the storybook-style page in
`/devtools/buttons` to view and test the icon-only button component.

The redesigned icon button component, uses the `icon-button` class to
follow Zulip's no-abbreviation policy, and to avoid conflicts with the
pre-existing `button` and bootstrap `btn` classes.

A button using this new style, should use the following classes,
  - First, the base `icon-button` class which defines the structure
  and behavior of the button. (Required)
  - Second, a `icon-button-square` class, to be used in conjecture
  with the `icon-button` class which provides the style for the squared
  button style of icon button. (Optional)
  - Third, a modifier class like `icon-button-neutral` which
  defines the colors for the particular icon button type. (Required)
2024-12-18 16:59:43 -08:00
Maneesh Shukla
a01de323a5 compose: Modified compose logic to hide warning banners.
- Modified compose logic to hide warning banners when error banners
(e.g., no post permissions) are visible, removing irrelevant information
during critical errors.

Fixes #25575.

Co-authored-by: joshyhz <joshyap.dev@gmail.com>
2024-12-18 11:40:42 -08:00
Maneesh Shukla
f6053ed15b compose_banner: Return boolean value from append function.
To prepare for changes that introduce the possibility of
an append failing.

Fixes: #25575.

Co-authored-by: joshyhz <joshyap.dev@gmail.com>
2024-12-18 11:40:42 -08:00
Aman Agrawal
238c35f2af message_events_util: Remove unnecessary callback.
All callbacks want to add messages, so we just directly do that.
2024-12-18 10:21:48 -08:00
Aman Agrawal
525ae3aaff message_list: Fix message list missing messages.
Since we allow calling `add_messages` without checking fetch status,
it can lead to non-contiguous message history due to latest message
being added to a message list without previous messages being
fetched.

To fix it, we only allow adding new messages via message_fetch
which properly sets `anchor` to the last message in the list
before fetching and adding messages to the list.
2024-12-18 10:21:48 -08:00
Aman Agrawal
9e519f8c18 message_fetch: Fix incorrectly set fetch status.
We update the fetch status before reaching here, so it was
incorrect to return before adding messages to the message
list data since it is always cached.
2024-12-18 10:21:48 -08:00
Aman Agrawal
a95f419650 message_fetch: Improve check for if message list is cached.
Combined feed is no longer cached by default, so this is the
correct check for if the message list is cached or not.
2024-12-18 10:21:48 -08:00
Shubham Padia
f2a22b498e stream_create: Do not create with pending text in pill widget. 2024-12-17 22:53:49 -08:00
Shubham Padia
f36dcdfe86 user_group_create: Do not create with pending text in pill widget. 2024-12-17 22:53:49 -08:00
Shubham Padia
c0f2697544 add_group_members_pill: Add button should show error on pending text.
This commit only changes the behaviour for edit screen of this setting.
We'll tackle the create screen in further commits.
2024-12-17 22:53:49 -08:00
Shubham Padia
f6bedceab3 add_subscribers_pill: Add button should show error on pending text.
This commit only changes the behaviour for edit screen of this setting.
We'll tackle the create screens in further commits.
2024-12-17 22:53:49 -08:00
Shubham Padia
0ee2543a49 add_subscribers_pill: Show outline on invalid input for pill. 2024-12-17 22:53:49 -08:00
Shubham Padia
388c4ef65c add_group_members: Show outline on invalid input for pill. 2024-12-17 22:53:49 -08:00
Shubham Padia
95ec87355f settings: Rephrase clicking enter to pressing enter. 2024-12-17 22:53:49 -08:00
Sahil Batra
4cb9fb0d5a group-permission-settings: Add function to get list of setting names.
This commit adds a function which returns type checked list of
group permission setting names so that all the type checking
has to be done only once.
2024-12-17 12:36:23 -08:00
Sahil Batra
ab67b87db3 user_group_edit: Fix live update of checkmark in left panel.
This commit adds code to live update the checkmark in left panel
on updating the user's membership even for groups whose membership
is not updated directly but has updated group as its subgroup.
2024-12-17 12:36:23 -08:00
Sahil Batra
a7fe3c822a user_group_edit: Fix live update when removing user from groups.
Previously, on removing a user from a group, the group row was
removed from "Your groups" only if that user could not join the
group again. But removing a user from a group can also remove
users from other groups which used the updated group as their
subgroup and those group rows were not removed from the list
and the empty panel message was shown with some groups present
in the list.

This commit fixes the bug by just redrawing the list so that
the groups that used the updated group as their subgroup are
also removed from the list if needed. This means that we no
longer have the behavior of keeping the group row if user
can join the group again but that is fine.
2024-12-17 12:36:23 -08:00
aditya.chaudhary1558@gmail.com
08c8e40afa drafts: Remove feature for discarding drafts after 30 days.
This commit helps in removal of all the code and documentation
related to 30-day auto removal of draft that are saved.

Fixes #32176.
2024-12-17 11:54:10 -08:00
Tim Abbott
d6520a01a3 buddy_data: Don't require coverage for error logging. 2024-12-17 11:18:45 -08:00
Aman Agrawal
3e93bec936 buddy_data: Check conversation_participants against legacy data.
We expect to remove this check once we've confirmed the logic is
correct.
2024-12-17 11:03:46 -08:00
Aman Agrawal
63584f3076 people: Extract function to check if user is a narrow participant.
To be commonly used in ConversationParticipants.
2024-12-17 11:03:46 -08:00