Commit Graph

8094 Commits

Author SHA1 Message Date
Alexandra Ciobica
ab02fb81c5 css: Remove unused portico css.
This *-page-header CSS all dates from a nearly-original version of the
portico design system, and hasn't been functional in years.
2019-06-12 17:41:50 -07:00
Alexandra Ciobica
13d78e9da7 integrations: Make header of integrations/docs on mobile look good.
Change the display from `block` to `flex` in order to be able to
arrange the elements as wanted. Reset the css of the header elements
only for the description view. Add `font-size: 1.2em` because the font
doesn't need resizing in this case, it needs resizing only when the
title is in the box.

Removed the `padding-bottom` from the `nav` on mobile because it
overlaps the new header and you cannot click the back button from the
integrations.

Fixes: #12365.
2019-06-12 17:33:53 -07:00
Alexandra Ciobica
869c5ce27b integrations: Change integrations content.
We remove the title from `errbot` integration documentation so that
all documentations have the same style.  See
https://github.com/zulip/python-zulip-api/pull/515 for a similar
change to integrations where the docs live elsewhere in version control.

We also remove the `margin: 0` from the instruction tip because where
the tip is followed by a list, there is no space between the two; this
change doesn't mess up the other places where the tip is used.
2019-06-12 17:33:00 -07:00
Vaibhav
f3d0d955c3 css: Use SCSS nesting in lightbox.scss for #lightbox_overlay. 2019-06-12 17:07:41 -07:00
Vaibhav
a7b820ddc3 css: Use SCSS nesting in lightbox.scss for .image-actions. 2019-06-12 17:07:41 -07:00
Vaibhav
7610c5f025 css: Cleanup lightbox.scss for download and open buttons.
* There is only one word inside the buttons and that too was wrapped
  inside `span.text` which was unnecessary. This is removed. All
  corresponding properties (font-size) are moved to `.button`.

* Since the only `a` inside image actions are these buttons, all
  the properties are transfered to `.button`.

* Similarly, properties for `.icon` are moved to `.button` and it is
  also removed from the template.
  * Font size was redundant for `.icon`
  * display property is moved
2019-06-12 17:07:41 -07:00
Vaibhav
b97ba0b026 css: Remove redundant span:nth-of-type(2) rule from lightbox.scss.
Since no such element exists inside `.image-actions`.
2019-06-12 17:07:41 -07:00
Vaibhav
288a0c241c css: Reorder lightbox.scss so that .image-actions are in same place. 2019-06-12 17:07:41 -07:00
Vaibhav
96fecdd7d5 css: Use SCSS nesting in lightbox.scss for .button. 2019-06-12 17:07:41 -07:00
Vaibhav
ede9faef2e css: Remove redundant .download top positioning in lightbox.scss.
* This rule was already invalid since `.download` is used in
  templates as `.button.download` and here it was defined as
  `.button .download`

* Even if the above was to be corrected, `.download` has position
  `static` and hence the top positioning would never have affected
  anything.
2019-06-12 17:07:41 -07:00
Vaibhav
3641855a2c css: Change rule from a.button to .button in lightbox.scss.
This works since the buttons in lightbox overlay are `a`s. Even if
they weren't so, this style can generally be applied to all the
`.button`s.
2019-06-12 17:07:41 -07:00
Vaibhav
351b3e9332 css: Remove redundant .clear-float since already defined in app_components. 2019-06-12 17:07:41 -07:00
Vaibhav
b75b6ce64c css: Use SCSS nesting in lightbox.scss for .center. 2019-06-12 17:07:41 -07:00
Vaibhav
a1f2b2b5ba css: Nest .image-list .image.selected inside .center. 2019-06-12 17:07:41 -07:00
Vaibhav
7b059fe8bf css: Use SCSS nesting in lightbox.scss for .player-container. 2019-06-12 17:07:41 -07:00
Vaibhav
414358e0a0 css: Use SCSS nesting in lightbox.scss for .image-description. 2019-06-12 17:07:41 -07:00
Vaibhav
a64aac4299 css: Reorder lightbox.scss so .image-descriptio are in same place. 2019-06-12 17:07:41 -07:00
Vaibhav
8ab4d38b6e css: Use SCSS nesting in lightbox.scss for .image-preview. 2019-06-12 17:07:41 -07:00
Vaibhav
249416e94a css: Use SCSS nesting in lightbox.scss for media queries. 2019-06-12 17:07:41 -07:00
Rishi Gupta
60bf4c0546 settings: Use fa-question-circle-o instead of (?) in org permissions. 2019-06-12 17:02:04 -07:00
Rishi Gupta
495efada4b help: Rename configure-waiting-period-for-full-members. 2019-06-12 17:02:04 -07:00
Rishi Gupta
799d6b9203 org settings: Standardize strings in Other permissions section.
Also, options are now ordered from most restrictive to least restrictive.
A standard style here will be easier to understand and maintain as we add
more settings here.
2019-06-12 17:02:04 -07:00
Vaibhav
9096affe77 css: Move stylesheets not included in the app to another directory.
This moves all the stylesheets like stats, billing etc. to another
directory called `static/styles/portico/`, matching the directory
structure of our JavaScript.
2019-06-12 16:59:52 -07:00
Yashashvi Dave
ee072da47a static/js/settings_notifications: Deduplicate code. 2019-06-12 16:24:51 -07:00
Yashashvi Dave
8e269b4651 models: Rename notification to enable_stream_audible_notifications.
Rename notification property `enable_stream_sounds` to
`enable_stream_audible_notifications` to match with other
notification property patterns.

Fixes part of #12304
2019-06-12 16:24:51 -07:00
Alexandra Ciobica
8f9fa151a6 css: Center left sidebar Add streams icon.
The `+` from the add streams button was not on the same line as the
`#`s and the text was not aligned with streams name.  These changes
fix that.
2019-06-12 16:22:51 -07:00
Alexandra Ciobica
7544d0eb11 css: Add space below Add streams button.
This ensures the browser's showing the link feature doesn't occlude
this button.

Fixes: #12519.
2019-06-12 16:22:02 -07:00
Seth Nickell
93696729c6 notifications: Disable default permission pop up.
Prior to this commit, we'd put up the green "Enable desktop
notifications" bar on page load AND the first time a desktop
notification worthy message was received, it would attempt to notify,
automatically triggering a browser permission popup (the same one as
clicking the green bar results in).

Now, desktop notifications are not attempted at all until the green
bar is clicked. Additionally Firefox and Webkit browser-specific
checks are made more uniform and done at the same point.

Tested written by YashRE42.

Fixes #11504.
2019-06-12 16:12:13 -07:00
Alexandra Ciobica
161d196759 css: Add nightmode variant for fetching more messages loading indicator
Fixes: #12522.
2019-06-07 10:45:29 -07:00
Yashashvi Dave
ac0d60f577 settings_profile_fields: Extract func set_up_choices_field_edit_form. 2019-06-06 22:36:16 -07:00
Yashashvi Dave
1fef813914 static/js/settings_account: Clean function append_custom_profile_fields. 2019-06-06 22:36:16 -07:00
Rishi Gupta
799a5e73c0 settings: Remove spurious colons after label text. 2019-06-06 22:17:04 -07:00
Rishi Gupta
49f8b9abbe help: Add manage-inactive-streams. 2019-06-06 22:17:03 -07:00
Priyank Patel
b70bd6be30 tests: Add tests for the logic of typing_status.handle_text_input.
This tests was added to make sure we catch subtle bug related to
comparing new_recipient and current_recipient. When we changed the
recipient to use arrays instead of string to use new user IDs based
api we encoured this bug and out testing suite couldn't detect this.
2019-06-06 19:56:24 -07:00
Priyank Patel
b8250fc61e typing: Use user IDs instead of user ids string. 2019-06-06 19:56:24 -07:00
Priyank Patel
5228403eb5 people: Refactor out user id string to array function. 2019-06-06 19:56:24 -07:00
Tim Abbott
3b502fa235 settings: Fix getting API key when using social auth.
Long-term, we want this flow to do a full re-authentication, but this
makes the frontend consistent with the backend and fixes a confusing
bug where submitting the form ended up adding a weird `?password=`
thing to the URL, in addition to not working.

Fixes #12200.
2019-06-06 17:05:34 -07:00
Thomas Ip
5b94e1dfad jQuery: Remove unnecessary :first selectors.
See example here: https://jsbin.com/relewizita/edit?html,js,output
Basically the original statement get the first of each input, button
and select element, and then select the first of these in the next
line. We can simply query the first one in one step. The settings
menu have at most 20 of these input elements so performance should
have no impact.
2019-06-06 15:21:26 -07:00
Thomas Ip
b72f30bd06 jQuery: Replace positional selectors at the end of multiple selectors.
A selector like `$('.elem1 .elem2:first')` selects the first descendant
with class name `.elem2` under `.elem1`. This is the same as saying
`$('.elem1 .elem2').first()`. See example here:
https://jsbin.com/bohehesari/edit?html,js,output
2019-06-06 15:21:26 -07:00
Thomas Ip
6cad1988a9 jQuery: Use positional methods on single selectors.
For selectors like `$('.element:first')`, we can simply write
`$('.element').first()`.
2019-06-06 15:21:26 -07:00
YashRE42
869aaba6a7 overlays: Fix stream edit click-through bug.
Fixes #12369.
2019-06-06 14:57:16 -07:00
Vaibhav
90a67a6b4f css: Use SCSS nesting in alerts.scss for .alert. 2019-06-06 11:41:35 -07:00
Vaibhav
4b315a63cc css: Cleanup alerts.scss combing rules under same selector .alert. 2019-06-06 11:41:35 -07:00
Vaibhav
7c51e59a35 css: Use SCSS nesting in alerts.scss for .alert-box. 2019-06-06 11:41:35 -07:00
Vaibhav
b04e1c918a css: Reorder alerts.scss so .alert-box .alert are in same place. 2019-06-06 11:41:35 -07:00
Vaibhav
9f5b1f19e9 css: Use SCSS nesting in alerts.scss for .alert. 2019-06-06 11:41:35 -07:00
Vaibhav
af5d3769a7 css: Nest .hotspot-popover arrows inside .hotspot.overlay.
No changes were required in night mode since the night-mode css
already includes the same level of nesting.
Tested visually as well.
2019-06-05 17:08:59 -07:00
Vaibhav
4c41bc1324 css: Use SCSS nesting in hotspots.scss for .hotspot-popover. 2019-06-05 17:08:59 -07:00
Vaibhav
d43548c7ca css: Use SCSS nesting in hotspots.scss for .hotspot-popover.arrow-*. 2019-06-05 17:08:59 -07:00
Vaibhav
209b16e667 css: Use SCSS nesting for in hotspots.scss for .hotspot-confirm. 2019-06-05 17:08:59 -07:00