Commit Graph

9280 Commits

Author SHA1 Message Date
Karl Stolley
b7ac8ea5d8 left_sidebar: Suppress home-view dot with zero unreads. 2025-08-13 09:57:33 -07:00
Karl Stolley
0aa2baa9ca left_sidebar: Remove z-index from sidebar-search.
Now that the left-sidebar filter sits atop the area,
it's no longer necessary to set a z-index here.

This also fixes a bug where a hovered unread in the
collapsed views would be clipped by the filter box
above.
2025-08-13 09:57:33 -07:00
Evy Kassirer
14ce2c5a81 stream_list_sort: Don't include unsubscribed streams in sort results.
Fixes bug reported here:
https://chat.zulip.org/#narrow/channel/9-issues/topic/exception.20when.20viewing.20world-public.20channel.20as.20a.20guest/near/2240871
2025-08-13 00:16:52 -07:00
apoorvapendse
68ea286ced links: Fix glitchy underlines in left sidebar.
This fixes the underlines and blue color that are
visible when selecting multiple topics/channels.

Comment: https://github.com/zulip/zulip/pull/34977#issuecomment-3181802391
Signed-off-by: apoorvapendse <apoorvavpendse@gmail.com>
2025-08-13 00:11:57 -07:00
Aman Agrawal
526ba0f7d4 sidebar_ui: Fix broken zoomed in topic list.
The zoomed in topic list search doesn't work if user searches
something and presses `enter` on `Show all topics` after
navigating via keyboard.

Fixed by not triggering `input` event on left sidebar search input
which seems to confuse the zoomed in topic search.
2025-08-13 00:06:12 -07:00
Pratik Chanda
406b1e5a44 tooltip: Add channel folder tooltip for truncated names in left sidebar.
There isn't a way to check the complete name for long truncated channel
folders name in the left sidebar.

This commit adds a tooltip for channel folder only when the folder names
are truncated in the left sidebar.

Fixes: zulip#35582.
2025-08-13 00:03:14 -07:00
Evy Kassirer
ef3a68961d left_sidebar: Show add-stream icon when focused during keyboard navigation. 2025-08-12 19:24:46 -07:00
Evy Kassirer
fd3c1977a9 left_sidebar: Hide mention indicator on expanded folder except on hover. 2025-08-12 19:24:29 -07:00
Evy Kassirer
4e930bf660 ui_util: Toggle classname for unread mentions instead of using hide/show. 2025-08-12 19:24:29 -07:00
Tim Abbott
4e94324b9a overlays: Avoid closing when dragging resizers.
Fixes most of #35663.
2025-08-12 18:09:08 -07:00
apoorvapendse
1001c0d60a left_sidebar: Improve text selection for channel names.
Fixes:
https://chat.zulip.org/#narrow/channel/9-issues/topic/.E2.9C.94.20.F0.9F.8E.AF.20focus.20bug.20with.20.22first.20unread.22.20channel.20click.20policy/near/2222421.
Signed-off-by: apoorvapendse <apoorvavpendse@gmail.com>
2025-08-12 17:40:00 -07:00
apoorvapendse
ab01079f40 message_header: Improve text selection.
Fixes: #34959.
2025-08-12 17:40:00 -07:00
apoorvapendse
14231e9fe2 left_sidebar: Improve text selection in buddy list.
Signed-off-by: apoorvapendse <apoorvavpendse@gmail.com>
2025-08-12 17:40:00 -07:00
apoorvapendse
0bc1bdda86 left_sidebar: Improve text selection for dm box.
Signed-off-by: apoorvapendse <apoorvavpendse@gmail.com>
2025-08-12 17:40:00 -07:00
apoorvapendse
4288734030 left_sidebar: Improve text selection for topic text.
Fixes: #34959.

Signed-off-by: apoorvapendse <apoorvavpendse@gmail.com>
2025-08-12 17:40:00 -07:00
apoorvapendse
622a125ce4 links: Prevent composebox re-focus when selecting links.
Prep commit to address #34977.
Links are blurred when one selects links in order to
focus the compose box, this commit prevents that from
happening which helps us avoid `e.stopPropogation()`
calls on individual handlers as the event bubbles up
to the main event handler.

Signed-off-by: apoorvapendse <apoorvavpendse@gmail.com>
2025-08-12 17:40:00 -07:00
Tim Abbott
ed97ae3c96 settings: Improve textarea starting heights.
Having the textarea not be super small greatly reduces the temptation
to immediately resize it when working with it.

This helps reduce the impact of #35663.
2025-08-12 17:09:01 -07:00
Tim Abbott
b13019bc7b invite: Fix resizing of custom message textarea.
Horizontal resizing could overflow the region, which looked busted, or
shrink it, which is useless.

Fixes part of #35663.
2025-08-12 17:09:01 -07:00
Saubhagya Patel
6548257b3a org_settings: Preserve unsaved Welcome Bot custom message.
Previously, closing the settings overlay without saving the
Welcome Bot custom message would discard the changes, causing
users to lose their work.
The unsaved message is now stored in a variable and restored
with the save/discard widget when the settings overlay is reopened.

Fixes #35664.
2025-08-12 17:09:01 -07:00
Tim Abbott
bf434ac2ef settings_org: Simplify links to access welcome bot messages.
Removing the dependency on message_store fixes a race issue where the
new Message object might not have reached us at the time that this
handler was run, if the HTTP request to trigger the welcome bot
message wins the race with the events system.
2025-08-12 16:35:33 -07:00
Tim Abbott
0eaa764474 search_suggestion: Fix merge conflict resolution error. 2025-08-12 15:40:43 -07:00
Pratik Chanda
5c16549b8a search_suggestion: Don't show operator suggestion if its incompatible.
Earlier, we would show operator suggestion even if it is incompatible
with current search terms. Selecting this wouldn't show further
suggestions for the operator since we don't allow narrow to incompatible
search terms.

This commit fixes this by hiding new suggestions if it is not
compatible with current search terms in the search box.
2025-08-12 15:31:36 -07:00
Pratik Chanda
35bfc8bace search_suggestion: Refactor incompatible_patterns to a global map.
Earlier, each functions handling any suggestions would define their
own incompatible_patterns inside it to use for checking validity.

This commit refactors all incompatible_patterns to a global map
with operators or search_string as its key.
2025-08-12 15:31:34 -07:00
Pratik Chanda
74a16acb81 filter: Change channel: suggestion description string.
This commit changes the string for `channel:` operator suggestion
string in the typeahead list.
2025-08-12 15:31:06 -07:00
Pratik Chanda
40ff1220ef filter: Implement web public channels filter for suggestions.
We already had web-public support in narrow by_channels.

This commit implements the web-public support for actual user
search.
2025-08-12 15:30:11 -07:00
opmkumar
aa9aa2160b help: Clean up search by location documentation. 2025-08-12 15:26:12 -07:00
Pratik Chanda
76e0acd027 search_suggestion: Show channel: operator suggestion on empty query.
This commit shows `channel:` operator suggestion when search query
is empty.
2025-08-12 15:18:11 -07:00
Pratik Chanda
9dbd13d5a6 search_suggestion: Show operator autocomplete suggestion at top.
Earlier, operator autocomplete suggestion was showed at bottom after
operator with operand value suggestions.

This commit brings operator autocomplete suggestion to higher priority
in the suggestion list.
2025-08-12 15:18:11 -07:00
Pratik Chanda
b0eefb8a31 stream_data: Track web public streams in current org.
This commit tracks all available web-public stream_ids in org.
2025-08-12 15:18:11 -07:00
Pratik Chanda
ec82c543fe search_suggestion: Fix public channels suggestion string.
Earlier, public channels suggestion string was wrongly concatenated
in channels filter.

This commit fixes the description html for channels:public filter.
2025-08-12 15:18:11 -07:00
Pratik Chanda
20889b3f78 filter: Enable channels operator for can_apply_locally.
Earlier, validating messages on given narrow skipped for channels
operator.

This commit adds channels operator support for checking if message
corresponds to given search term.
2025-08-12 15:18:11 -07:00
Karl Stolley
39b69ab90a inbox: Move lefthand padding to avoid disturbing grid.
This fixes a subtle alignment issue with unreads in
the DM header row versus the actual DM rows that
follow.
2025-08-12 14:06:37 -07:00
Karl Stolley
39025636b1
dropdown_lists: Scope alignment tweaks to folder selector. 2025-08-12 13:45:48 -07:00
Karl Stolley
1fcf9acd33 dropdown_lists: Tweak alignment for multline text, buttons. 2025-08-12 12:41:31 -07:00
Karl Stolley
f95572e1e6 dropdown_lists: Open folder selector to 75% of input width. 2025-08-12 12:41:31 -07:00
Karl Stolley
fce8b57e27 dropdown_lists: Present gridded list items.
Fixes #35600.

Co-Authored-By: Kunal Sharma <v.shm.kunal@gmail.com>
2025-08-12 12:41:31 -07:00
Karl Stolley
dc87f418f3 dropdown_lists: Provide uniform .dropdown-list-item-name structure. 2025-08-12 12:41:31 -07:00
Karl Stolley
3cb8247d76 dropdown_lists: Conditionally present grouped buttons.
Co-Authored-By: Kunal Sharma <v.shm.kunal@gmail.com>
2025-08-12 12:41:31 -07:00
Karl Stolley
1b62a7579e dropdown_lists: Structure all name text with a span. 2025-08-12 12:41:31 -07:00
Karl Stolley
4c129e73b7 dropdown_lists: Simplify selected item-text class. 2025-08-12 12:41:31 -07:00
whilstsomebody
d0207a4297 inbox_ui: Clarify inbox state when all sections are collapsed.
It was reported that the UI is pretty confusing when there is
just a collapsed folder in inbox view.

To address this issue, we now show a note below the folders in
following two situations:
  - All folders collapsed.
  - If all folders are not collapsed, all visible channels
    are collapsed.

Fixes: #35555
2025-08-12 12:04:23 -07:00
Sahil Batra
21c1c24908 inbox_ui: Sort channel folders by order field. 2025-08-12 11:17:17 -07:00
Sahil Batra
1bd089ae99 folders: Live update UI on reordering channel folders.
This commit adds code to live update "Channel folders" panel
and left sidebar on reordering of channel folders.
2025-08-12 11:17:17 -07:00
Sahil Batra
7b4840da41 folders: Update folders data on successful request.
Instead of waiting for event from the server, we update the data
objects in channel_folders.ts when editing and archiving the
folder so that the dropdown list is updated immediately and
user sees the updated list in cases where event is delayed.
2025-08-12 10:32:11 -07:00
Sahil Batra
597ead9732 stream-settings: Fix live update of selected option in folder dropdown.
This commit adds code to fix the live update of folder name selected in
dropdown but not saved using "Save changes" button. And this also
includes code for updating the name for folder selected in stream
creation form.
2025-08-12 10:31:42 -07:00
Sahil Batra
f4cc746ae9 stream-settings: Move update_channel_folder_name.
This commit moves update_channel_folder_name function from
stream_ui_updates.ts to stream_settings_ui.ts to avoid
import cycle in further commits.
2025-08-12 10:31:42 -07:00
Sahil Batra
de5fd3c474 stream_create: Add a new function to set folder dropdown value.
This commit adds a new function to set folder dropdown value
in stream creation form, that will be used in further commits
to make live update work correctly.
2025-08-12 10:31:42 -07:00
Tim Abbott
cdc3647b91 folders: Fix search_term function name typo. 2025-08-12 10:30:52 -07:00
Pratik Chanda
8711730e6b left_sidebar: Add menu to change channel folder setting in left sidebar.
Earlier, you could change setting to show/hide channel folders in
left sidebar from setting overlay.

This commit adds an menu option to toggle channel folders setting in
the left sidebar. The menu is hidden if there are no subscribed
channels with channel folder.

Fixes #35574.
2025-08-12 10:29:44 -07:00
Pratik Chanda
35896244d7 channel_folders: Add help function to check if user has sub in folder.
This commit adds a function that returns true if user is subscribed
to a channel which is in a channel folder.
2025-08-12 10:29:19 -07:00