Commit Graph

2480 Commits

Author SHA1 Message Date
Karl Stolley
42e1b104e2 action_buttons: Remove bottom margin from Bootstrap. 2025-03-14 13:00:54 -07:00
Karl Stolley
4dfa0c1b45 action_buttons: Display only a focus-visible ring. 2025-03-14 13:00:54 -07:00
Karl Stolley
56e5a6237e action_buttons: Match height, width to Vlad's specifications. 2025-03-14 13:00:54 -07:00
Anushrut pandit
3d9cbd5bd7 message_row: Fix focus ring cutoff near date rows.
In direct messages, the blue message focus ring could, at certain zoom
levels, be clipped near date rows.

The cause was a redundant background-color on .date_row interacting
badly with zoom. We previously debugged this problem more broadly and
fixed it in #25806, but missed this redundant declaration.

Fixes #33571.
2025-03-14 12:48:50 -07:00
Karl Stolley
bb09222662 alerts: Improve styles, behavior between app and portico. 2025-03-14 11:52:18 -07:00
Aman Agrawal
3cfbf130a5 typeahead: Fix alignment of user group icon.
2px right margin was incorrectly added as -2px left margin needs
to be taken into account as well.
2025-03-14 11:07:33 -07:00
Aman Agrawal
a393d9d495 user_group: Use double user icon instead of tripe user icon. 2025-03-14 11:07:33 -07:00
Aman Agrawal
dde861e959 recent_view: Remove not required height and width values.
We don't need specific width / height here and it is okay for
this element to take child's size here which is scaled based
on font size.
2025-03-14 11:07:33 -07:00
Aman Agrawal
f53fc1b507 user_group_settings: Use icon with 2 users for editing group info. 2025-03-14 11:07:33 -07:00
Aman Agrawal
4029d80c01 compose: Use standard primary button colors for compose send button. 2025-03-14 10:07:05 -07:00
harshbansal8705
f1e6371bf8 message_editing: Fix unclickable area in bouncing "...".
The bug occurred because clicking on .message-editing-animation was
not triggering the click on .edit-notifications. This commit prevents
this behaviour by setting its property pointer-events to none.

Fixes: #33950
2025-03-13 17:06:47 -07:00
Sayam Samal
955ddc011f inline_topic_edit: Make inline topic edit input field width dynamic.
This commit adds a hidden `topic_value_mirror` span element, and uses
that to dynamically set the width of the input field to the width of
the topic text inside it + some cushion.

Fixes #33844.
2025-03-13 15:58:26 -07:00
Karl Stolley
4454811191 message_view: Better tolerate different opening Markdown elements. 2025-03-13 14:42:14 -07:00
Aman Agrawal
959981d2c9 navigation_tour: Set color of "Let's go" as per standard action btn. 2025-03-13 14:38:16 -07:00
Aman Agrawal
d1704deb52 onboarding_steps: Dim background of navigation tour video. 2025-03-13 14:38:16 -07:00
Prakhar Pratyush
5f3896710f onboarding_steps: Add 'navigation_tour_video' for new users.
This commit adds a one-time modal to display navigation tour
video to new users.

Includes an `NAVIGATION_TOUR_VIDEO_URL` server-setting to specify
the video's URL. When set to None, the modal is not displayed.

Fixes #29304.
2025-03-13 14:38:16 -07:00
Sayam Samal
44db268fce alerts: Fix blueslip error overlay not interactable.
This is a follow-up to commit cd08c628ba,
and adds the missing `pointer-events: auto` property to the blueslip
error overlay. This makes the blueslip error overlay interactable again.
2025-03-13 13:14:18 -07:00
Prakhar Pratyush
280fd40892 inline_topic_edit: Improve placeholder when topic is not mandatory.
Earlier, we used to show "general chat" as the placeholder.

This commit adds support to show "Enter a topic (skip for general
chat)" as the placeholder when topic is not mandatory in the
inline topic edit input box.

We show "general chat" (as we show in compose topic input box)
when inline topic edit input box is not focused and topic="".

Fixes part of #33846.
2025-03-13 11:30:58 -07:00
Vector73
b31024be47 saved_snippets: Add support for editing saved snippets.
Fixes #33708.
2025-03-13 10:58:36 -07:00
Tim Abbott
2c31de0a86 compose: Remove baseline override for recipient picker.
Some checks failed
Code scanning / CodeQL (push) Has been cancelled
Zulip production suite / Ubuntu 22.04 production build (push) Has been cancelled
Zulip CI / ${{ matrix.name }} (zulip/ci:bookworm, true, false, Debian 12 (Python 3.11, backend + documentation), bookworm) (push) Has been cancelled
Zulip CI / ${{ matrix.name }} (zulip/ci:jammy, false, true, Ubuntu 22.04 (Python 3.10, backend + frontend), jammy) (push) Has been cancelled
Zulip CI / ${{ matrix.name }} (zulip/ci:noble, false, false, Ubuntu 24.04 (Python 3.12, backend), noble) (push) Has been cancelled
Zulip production suite / ${{ matrix.name }} (zulip/ci:bookworm, --test-custom-db, Debian 12 production install with custom db name and user, bookworm) (push) Has been cancelled
Zulip production suite / ${{ matrix.name }} (zulip/ci:jammy, , Ubuntu 22.04 production install and PostgreSQL upgrade with pgroonga, jammy) (push) Has been cancelled
Zulip production suite / ${{ matrix.name }} (zulip/ci:noble, , Ubuntu 24.04 production install, noble) (push) Has been cancelled
Zulip production suite / ${{ matrix.name }} (zulip/ci:bookworm-7.0, 7.0 Version Upgrade, bookworm) (push) Has been cancelled
Zulip production suite / ${{ matrix.name }} (zulip/ci:bookworm-8.0, 8.0 Version Upgrade, bookworm) (push) Has been cancelled
Zulip production suite / ${{ matrix.name }} (zulip/ci:jammy-6.0, 6.0 Version Upgrade, jammy) (push) Has been cancelled
Zulip production suite / ${{ matrix.name }} (zulip/ci:noble-9.0, 9.0 Version Upgrade, noble) (push) Has been cancelled
After testing the previous commit a bit more, it appears to me that
the typo fix on `first-baseline` that I made was in error; what looks
good and matches the screenshots in the PR was having that line of CSS
be invalid/deleted.
2025-03-12 23:22:06 -07:00
Karl Stolley
e713bcb1db compose: Better align widget icons for long channel names. 2025-03-12 23:15:50 -07:00
Karl Stolley
57ebcc67bc compose: Isolate flex-align to recipient widget. 2025-03-12 23:13:24 -07:00
evykassirer
fbee7db9f1 settings: Scale loading spinner with font-size.
This might be dead CSS, in that most spinners have their styles
overwritten by other CSS. But there are a lot of spinners and
this is hard to look into and know for sure (but it would be good
to as a followup eventually).
2025-03-12 16:32:15 -07:00
evykassirer
de6f15a565 settings: Move save check width to stylesheet and scale with font size. 2025-03-12 16:32:15 -07:00
evykassirer
82ee8ca7cc stream_settings: Center loading spinner, scale padding with font-size. 2025-03-12 16:32:15 -07:00
evykassirer
72a0779663 search: Increase line height for user pills.
Users' names were being cut off on the bottom if they
had descenders.

We're keeping the line height for reasons explained in
2025-03-12 16:31:17 -07:00
Karl Stolley
a2892e713c rendered_markdown: Scale code-span padding with font size. 2025-03-12 10:21:15 -07:00
Karl Stolley
c688c2742e compose: Refine the space occupied by the channel. 2025-03-11 13:51:25 -07:00
Karl Stolley
5bf38e30e7 message_edit: Match button height to compose Send button. 2025-03-11 12:30:48 -07:00
Karl Stolley
0e34a753cd video_thumbnails: Precisely size, place play button. 2025-03-11 12:23:55 -07:00
Karl Stolley
a813b37694 recent_view: Hold unread header to a minimum width. 2025-03-11 12:22:49 -07:00
Maneesh Shukla
acabface1a domains_modal: Fix width of modal_text_input. 2025-03-11 12:20:36 -07:00
whilstsomebody
865d847492 dropdown_widget: Fix dropdown highlighting in inbox/conversations menu.
Previously, the dropdown had a bug where the first item
was highlighted regardless of the selected option.

This commit fixes the bug, ensuring that the
selected option is now correctly highlighted.

Fixes: #33066
2025-03-11 12:11:50 -07:00
Harsh
48e8250e28 invite: Fix alignment of copy-invite-link button in invitation modal.
This commit makes width of multiuse_invite_link to full so
that it can take all the remaining space and copy invite link
button can be aligned properly.
- this also does changes copy_invite_link to render_copy_invite_link
to follow the naming conventions.
2025-03-11 10:15:01 -07:00
Apoorva Pendse
54fd02b173 compose_tooltip: Remove delay for invalid messages.
Does what 714def080f
was trying to do without the side effects.
Fixes: 714def080f
2025-03-11 09:41:22 -07:00
evykassirer
0e152a128f message_edit: Scale resolve topic spinner with font size.
This commit also changes the width of the spinner so that the
resolve icon and spinner take up the same width.
2025-03-10 16:43:45 -07:00
Sahil Batra
c8b1de6076 gear_menu: Allow spectators to change font size and line height. 2025-03-10 16:07:37 -07:00
Sahil Batra
c6e840531f settings: Update UI for information density settings.
This commit adds new UI for controlling font size and
line height settings in settings panel.

Fixes #33186.
2025-03-10 16:07:37 -07:00
Sahil Batra
6f6059da73 personal_menu: Support changing information density settings.
This commit adds UI in personal popover menu for user to change
font-size and line-height.

Fixes part of #33186.
2025-03-10 16:07:37 -07:00
Sahil Batra
63ef84d9a3 popovers: Decrease width of theme switcher in spectators menu.
Matches the width of other items in the menu.
2025-03-10 16:07:37 -07:00
Karl Stolley
54b0ba0248 compose: Hold DM picker, topic marker to top recipient line. 2025-03-10 13:39:47 -07:00
Harsh
b7a943b8cb left_sidebar: Hide menu option for home view if all messages are read.
This commit hides sidebar menu option button instead of showing
it with "Mark all messages as read" option, for home view when
there are no unread messages.
2025-03-10 13:08:39 -07:00
apoorvapendse
be6cc5e56e user_groups: Show group name for smaller widths.
https://chat.zulip.org/#narrow/channel/9-issues/topic/.F0.9F.8E.AFdeactivated.20group.20indicator.20disappears/near/2113197
2025-03-10 12:45:49 -07:00
apoorvapendse
27ac91a8c8 user_groups: Add deactivated icon on top title.
https://chat.zulip.org/#narrow/channel/9-issues/topic/.F0.9F.8E.AFdeactivated.20group.20indicator.20disappears/near/2112723
2025-03-10 12:45:49 -07:00
Harsh
eb013580a5 user_groups: Add banner for settings for a deactivated group.
This commit adds a banner at the top of the group settings panel, to
make it super clear when a group is deactivated.

Fixes: #33803.
2025-03-10 12:42:44 -07:00
Sayam Samal
6043063d21 alerts: Fix alert popup not closing in portico.
The alerts in portico were not being closed since the class responsible
for hiding them — `home-error-bar` was defined in `web/styles/zulip.css`
which isn't being shared with portico. This commit moves this class to
`web/styles/alerts.css` which is shared with portico, and fixes the bug.
2025-03-10 11:21:11 -07:00
Sayam Samal
80a352dc02 buttons: Add loading indicator to buttons. 2025-03-10 11:21:11 -07:00
Sayam Samal
3275fcc96e popup_banners: Redesign connection banner to use new banner component.
This commit serves as the base commit for redesigning the alert banners
by migrating them to use the new banner component. We use a new name
to refer to these banners — "Popup banners", which is more descriptive
about their behavior.

The Popup banners are appended to the container in a stacking order,
i.e., the most recent popup banner appears on the top and the oldest one
is sent to the bottom of the stack. These banners also inherit the
animations from the alert banners for visual appeal.

This commit also fixes the bug where clicking on the "Try now" button
in the popup banner resulting from an error in the `/json/messages`
endpoint resulted in call to restart_get_events in server_events.js
instead of load_messages in message_fetch.ts.

Fixes #31282.
2025-03-10 11:21:11 -07:00
Sayam Samal
cd08c628ba alerts: Modify alert-box container to use flex layout.
This is prep commit for the alert banner redesign, which adds flex
layout to the alert-box container and modifies the animations logic to
work with the new layout.
2025-03-10 11:21:11 -07:00
evykassirer
602d0f4914 right_sidebar: Remove invite users icon at bottom of buddy list.
Discussion here:
https://chat.zulip.org/#narrow/channel/101-design/topic/right.20sidebar.20design.20tweaks.20.20.2332976/near/2115335
2025-03-10 09:47:00 -07:00