Previously, deactivating a bot from the bots tab without loading
the users tab caused a blueslip error because update_view_on_deactivate
tried to render uninitialized role dropdowns from a realm_user event.
This commit fixes this by passing is_bot to update_view functions
and only rendering dropdowns for non-bots if they’re initialized.
If the organization has limited message history to moves only,
we display "MESSAGE MOVE HISTORY" for the overlay header, instead
of "MESSAGE EDIT HISTORY".
If the organization only allows viewing message move history, in
the message edit history overlay for the initial message, we display
the original topic and channel of the message instead of the original
message content.
This way the overlay content is consistent with the organization
setting for viewing message edit history, and if the message content
has been edited, that original content is not viewable to other
users.
Previously, users could send messages before uploads finished,
resulting in incomplete messages with "Uploading..." text.
This commit blocks sending until uploads complete.
Fixes: #33986.
In direct messages, the blue message focus ring could, at certain zoom
levels, be clipped near date rows.
The cause was a redundant background-color on .date_row interacting
badly with zoom. We previously debugged this problem more broadly and
fixed it in #25806, but missed this redundant declaration.
Fixes#33571.
Previously on subscribing, channels used to appear in the left panel
regardless of the filter. Now, channels that don't match the
filter are hidden from the left panel.
Variable for storing the dropdown widget is now
declared in stream_settings_components and this
commit also adds some helper functions to get
and set the filter value.
This is a preparatory commit to avoid import
cycles in further commits for fixing live
update when channels are archived.
There is no need to store the archived status filter value in a
variable, instead value can just be derived by calling "value"
function on DropdownWidget.
This is a preparatory refactor for further commits which will fix
live-update behavior when archiving channels.
The web/src/banners.ts module, was trigger the window resize event for
every banner, which led to unexpected UI bugs and performance issues.
This follow-up commit for 7a96cec774,
restricts the window resize event to only the navbar banners, where
there is a need to recalculate the navbar-fixed-container height and
adjust the UI accordingly.
Resizes are very disruptive, and are not required for most
banners. The one exception is the top-of-window banners, which ideally
would also not require a resize, but do impact the geometry of space
available to other components.
Fixes#33570
When navigating to a narrow based on locally available unread
data with `old_unreads_missing`, we verify the calculated
first unread message id with server and if there is an unread message
prior to the one we calculated locally, we convert the current
narrow into a `near` narrow and show a banner with a button to
allow user to navigate to the correct first unread message.
The bug occurred because clicking on .message-editing-animation was
not triggering the click on .edit-notifications. This commit prevents
this behaviour by setting its property pointer-events to none.
Fixes: #33950
This commit adds a hidden `topic_value_mirror` span element, and uses
that to dynamically set the width of the input field to the width of
the topic text inside it + some cushion.
Fixes#33844.
Add a warning banner when a user mentions a group (non-silent) where none
of the members are subscribed to the current stream. The banner informs
the user that the mention won't notify anyone.
Fixes#33545.
This commit adds a one-time modal to display navigation tour
video to new users.
Includes an `NAVIGATION_TOUR_VIDEO_URL` server-setting to specify
the video's URL. When set to None, the modal is not displayed.
Fixes#29304.
This commit adds support to the DialogWidget to ignore
the clicks on the overlay and NOT close.
This will be helful in navigation-tour-video dialog widget.
This commit updates populate_db to mark all onboarding steps as seen
for existing users to avoid unnecessary popups during development.
Developers should create a new user in development environment
to test the onboarding steps.
Fixes#31315.
We want to parse sender:me with the email when turning it into
a pill, but not before then so that "Sent by me" is still the
search string in the suggestions.
This is a follow-up to commit cd08c628ba,
and adds the missing `pointer-events: auto` property to the blueslip
error overlay. This makes the blueslip error overlay interactable again.
Earlier, we used to show "general chat" as the placeholder.
This commit adds support to show "Enter a topic (skip for general
chat)" as the placeholder when topic is not mandatory in the
inline topic edit input box.
We show "general chat" (as we show in compose topic input box)
when inline topic edit input box is not focused and topic="".
Fixes part of #33846.
When changing font size using controls in personal menu popover
and gear menu popover for spectators, font size of popover is
not change so that buttons do not shift.
Also, arrow shown with the popover is removed once font-size
is changed, as popover will be detached from the element which
was clicked to open it.
Zulip production suite / ${{ matrix.name }} (zulip/ci:bookworm, --test-custom-db, Debian 12 production install with custom db name and user, bookworm) (push) Has been cancelled
Zulip production suite / ${{ matrix.name }} (zulip/ci:jammy, , Ubuntu 22.04 production install and PostgreSQL upgrade with pgroonga, jammy) (push) Has been cancelled
After testing the previous commit a bit more, it appears to me that
the typo fix on `first-baseline` that I made was in error; what looks
good and matches the screenshots in the PR was having that line of CSS
be invalid/deleted.
