The margin doesn't scale with font size, so it looks
extra weird at small font sizes, and also the text
is already being centered with flex so we don't need
margin.
In a future commit in (#34125) we'll add a classname for the
subheader and use that to scope these rules.
This commit has no changes in CSS rules. It only moves them around.
We need this height to be flexible based on if the subheader has
overflowed into two rows or not, and our method of doing this
(with existing examples in the buddy list and stream list) is to
calculate what the height should be when a window is loaded or
resized.
We also added `flex-grow: 1` to the add group members and add stream
subscribers input. Without that, the typeahead won't open on click,
since there was no space occupied by the input to click on.
This commit makes the following changes to improve the display of long
stream titles in the stream creation and user group settings UI:
- Uses `display: -webkit-box` and `line-clamp` properties to show the
title upto two lines, and end with `...` if it exceeds.
- Updates icon `font-size` to align with text size.
- Updates `margin` and `line-height` to make it visually better.
Since the input-group covered all the available space, tooltip looked
like it is separated from the checkbox label. This commit fixes the
width of input-group to be just wide enough to contain the content
when the setting is disabled so that tooltip is positioned correctly.
Previously we collapsed buttons when the two-panel view was narrow enough
that the buttons started wrapping, but this case for one-panel view with
wrapping buttons was missed.
This simplifies some @container queries and also ensures there's enough
space at larger font-sizes for the save/discard buttons to appear
beside setting section headings without overflowing onto the next line.
Now the left pane is always 40% and the right pane is always 60%.
One effect of this is that the top left buttons in the stream settings
overlay are now always in two rows at 16px (like they already always
were at 20px).
There are no other CSS rules with this id name and also no grep
results for "subscriptions" that have it as an html id, so it seems
pretty safe to say this id is no longer being used.
Fixes#32877.
Co-authored-by: Sanchit Sharma <[email protected]>
Thanks to @sanchi-t, I've yanked a lot of code and approach
from his concurrent PR in 32475, especially the method of
toggling parent css class to hide/show relevant children.
This will help with keeping the icon centered when we update
it to change size with font-size settings.
This CSS technically also applies to user groups but I don't
think there are any icons used there.
