CodeCow/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2026-06-24 21:08:25 +08:00
Code Issues Actions 6 Packages Projects Releases Wiki Activity
9,152 Commits 32 Branches 165 Tags 781 MiB
7fce920522
Commit Graph

1395 Commits

Author SHA1 Message Date
Steve Howell
7fce920522 Move favicon-related functions to favicon.js 
util.reset_favicon -> favicon.reset
util.set_favicon -> favicon.set

(imported from commit 250848ec5dc7ac58649197c8cc4b7b4e7b19f25c)
 2014-03-14 20:48:55 -04:00
Steve Howell
d52e5e551d Remove {show,destroy}_first_run_message. 
We essentially inlined the methods in the three places they
were called.

(imported from commit 622ee718d6dd226187f1e37ff754ee2fa635e6f2)
 2014-03-14 20:48:54 -04:00
Steve Howell
b12b44579c Set up $.fn.expectOne in setup.js 
(imported from commit 77922cf8f506d4eb811498d418215eabf74b76ae)
 2014-03-14 20:48:53 -04:00
Steve Howell
3889edd824 Move xhr_error_message() into channel.js 
(imported from commit c68c2d475b5673a3dd5f68c75624dfcfe56728ca)
 2014-03-14 20:48:53 -04:00
Steve Howell
0e129614cf Remove unused util.recipient_key() function. 
(imported from commit cee6a58344971ee1439e6b66ec301f1bd0f80502)
 2014-03-14 20:48:53 -04:00
Steve Howell
50bc5401a4 Moved loading_indicator functions to loading.js. 
util.make_loading_indicator -> loading.make_indicator
util.destroy_loading_indicator -> loading.destroy_indicator

(imported from commit 8a171622a6096476dd040912d3f1460d53159f20)
 2014-03-14 20:48:52 -04:00
Waseem Daher
a1538b4bab Eliminate gap at bottom of portico pages. 
(imported from commit 0e1d9bde16267f9b6533f256c28374ed98566578)
 2014-03-14 20:48:52 -04:00
Waseem Daher
c09b6914ba Use new background image for /hello. 
(imported from commit 06174760ee28a4c6b323f5c7e66cb20a50709d2a)
 2014-03-14 20:48:52 -04:00
Waseem Daher
86ff8cdd8c Add San Francisco image to repository. 
This is a public domain work.
Source: http://www.flickr.com/photos/allenr/13127238845/in/photostream/

(imported from commit 90f7e79131302a9da2323125ca27f78d5ac79a78)
 2014-03-14 20:48:52 -04:00
Waseem Daher
9cefe46a1f Change /features icon color to match header. 
(imported from commit d9cabd13acd8981a5bef93011ae4ea0c45cb451b)
 2014-03-14 20:48:51 -04:00
Waseem Daher
202ac0fe10 Restyle /hello to be more consistent with current app style. 
(imported from commit 7e1df8cb885908f40569692283e98ac851ca3d2e)
 2014-03-14 20:48:51 -04:00
Waseem Daher
4eded59dbe Revert "signup: point to /register at the top too." 
This reverts commit 517df29d10182c05780017c15225c9f95b844225.

(imported from commit 7820bb2dad7010579342450040d0f5c72ad2c627)
 2014-03-14 20:48:51 -04:00
Leo Franchi
c832543168 Remove very confusing dom_id message attribute 
(imported from commit c7e3e50bf8827f6f087d7df28ec7b7c173a3c041)
 2014-03-14 20:48:51 -04:00
Leo Franchi
ef81999f3f Make sure to store raw DOM elements, not jQuery objects, in _rows 
(imported from commit ccf85bfd514b5b143c1021d4a186f1448abc700d)
 2014-03-14 20:48:50 -04:00
Allen Rabinovich
163d93c15b Move timestamp up when sender is included 
(imported from commit a347b397a41028f3ca9642ad1edd704e3255245a)
 2014-03-14 20:48:50 -04:00
Leo Franchi
6d2c6f269d Make sure to use the proper dom_id in the proper places 
(imported from commit c4852f972d4fe8b2732c87dcc499f91f837e912c)
 2014-03-14 20:48:50 -04:00
Leo Franchi
8f7542f34d Use elem.html() instead of elem.replaceWith() when swapping in new rendered messages 
(imported from commit 82664bf2eb20faa8e98b7912b4c26174046d2dd6)
 2014-03-14 20:48:50 -04:00
Leo Franchi
8b1f0223fe Update the dom_id of message objects when their id changes 
(imported from commit e766eff7d966d95616ac192c8cb0cb328bd96b1b)
 2014-03-14 20:48:50 -04:00
Leo Franchi
7f3ea34dc5 Make sure to re-select selected after re-ordering 
(imported from commit 50878874372d1304014f5285b488db6ab896abbd)
 2014-03-14 20:48:49 -04:00
Leo Franchi
26690adc47 Save the correct-from-dom rerendered message in _rows when rerendering 
(imported from commit c021beef3106148a6d085ca16f34a1c4bb4fc7af)
 2014-03-14 20:48:49 -04:00
Leo Franchi
e7c8c322c0 Handle case where _lower_bound returns size of input list 
(imported from commit bd91512615b11935eafd5809ca414eeb0cf189c4)
 2014-03-14 20:48:49 -04:00
Steve Howell
6ec72a290d Simplify condition for aborting people.reify(). 
Since it's basically impossible to add a person with an
undefined full_name--even "skeleton" people--there is no
need to check the full_name field to short circuit reify(),
because it will always be defined.

(imported from commit 3a30cfd583a040f7460739abea1604594c450ffe)
 2014-03-14 20:48:47 -04:00
Leo Franchi
065fcf1a1b Handle out-of-order local ids in message_list 
(imported from commit e805837d7d2790be90490cc9ec9415882ff9b549)
 2014-03-14 20:48:47 -04:00
Leo Franchi
7cd814d92c Keep track of local ids in our message list 
(imported from commit d96eaa14bf9f4b315d6893e6cd6c8d3c069c1d14)
 2014-03-14 20:48:46 -04:00
Leo Franchi
86d310a984 Pass index of element to util.lower_bound matching function 
(imported from commit eb8ba76b4855355bc23d6419cbb0f3a4aad8b6de)
 2014-03-14 20:48:46 -04:00
Steve Howell
0d0c427f2b Remove unused bot_data.get_all() 
(imported from commit 70ec624667dacede72c00f1bb207d8d18dfdd4c1)
 2014-03-14 20:48:45 -04:00
Allen Rabinovich
080f7229fc Make status messages larger 
(imported from commit 0545d9d074b828c54fbb9156cd8e647c896e2b17)
 2014-03-14 20:48:45 -04:00
Allen Rabinovich
f1db96143a Stick 'Edited' tag to the top and darken timestamp further 
(imported from commit 682b72001cd317b2236cab23e9392c9e4452784d)
 2014-03-14 20:48:45 -04:00
Steve Howell
9a5289b96c Change compose box only for going-forward topic changes. 
(imported from commit 69de10fd9866acab2d12f15489c67eb9daab8d3d)
 2014-03-12 21:15:22 -04:00
Steve Howell
b8de1dd13f Change narrows automatically on topic changes. 
(imported from commit 7a8e606cc6fe0f2e4b5a164e1396e302ad969102)
 2014-03-12 21:15:22 -04:00
Steve Howell
45002aa03f Close message edit before doing topic-related changes. 
Closing the edit box earlier will make future changes less brittle,
when we, for example, re-narrow based on topic edits.

(imported from commit 36219c5129153beebfefe443932825fdf74abc43)
 2014-03-12 21:15:22 -04:00
Steve Howell
d4fa917c49 Add has_topic() helper to filter.js 
(imported from commit 8d8d9c2b6638968b18c7603e070c001d6b16cf21)
 2014-03-12 21:15:22 -04:00
Steve Howell
0376d26c79 Add filter_with_new_topic() method. 
(imported from commit 2ed9261ec70edf0a4ee1a25989cabfa9ab7907fd)
 2014-03-12 21:15:22 -04:00
Steve Howell
65e9d0bead Change compose box for topic changes only if streams match. 
(imported from commit 0bd6cd53ea4a8db5a457bb7dd5917f25c7c9434a)
 2014-03-12 21:15:21 -04:00
Steve Howell
63097f32e5 Let arrow keys do the right thing for select widgets. 
This helps the edit form in particular, when you change a
topic and need to select the propagation option.

(imported from commit c9dd1e62cd9e0b2142855685f04baa06eecf7226)
 2014-03-12 21:15:21 -04:00
Steve Howell
ff44fb6fcf For topic changes, set the compose subject outside the loop. 
If we get a topic change, we can change the subject outside the
loop, since we are passed in event.orig_subject.  Doing it inside
the loop was mostly harmless, since after you encountered the first
message with the old topic, the condition to change the subject
evaluated to false, but it was still technically O(N), and it was
kind of confusing.

This commit changes behavior in the edge case that you have the
compose box open for a changing subject, but you are in a narrow
that does not have any of the affected messages.  After this commit,
the topic in the compose box will still change, which I believe
is the correct behavior.

(imported from commit 2363e432ebe7ae8e07379324ee0bfb52051428e6)
 2014-03-12 21:15:20 -04:00
Steve Howell
dfc34eb074 Allow negated has:* searches. 
Before this change, we were incorrectly trying to do local
filtering on negated has searches.

(imported from commit d1a6f1feef6b3cc1c984eb91a73cd16c4e66874e)
 2014-03-12 21:15:20 -04:00
Allen Rabinovich
d6617a991c Remove mobile device indicator from template 
(imported from commit 48a10a75b30c3f51a6dfa5af43ca138e391289d4)
 2014-03-12 21:15:19 -04:00
Allen Rabinovich
fcca1549b0 Darken the timestamps 
(imported from commit c8934a422d8d770634015210fde80eced34aba64)
 2014-03-11 13:26:32 -06:00
Luke Faraone
8b3b33c182 Reword error page; link to Twitter. 
We use this error page for all 5xx errors, so I'm removing the error
number from the text.

(imported from commit c0c4c8829d466dd20c76dbbc920fc57cafbd6e6c)
 2014-03-11 15:16:19 -04:00
Allen Rabinovich
40164f4398 Move mobile indicator to the right and style it properly 
(imported from commit 19f6bd27b30c355c1720d43580f5b6ff6c1c0b4a)
 2014-03-11 13:06:23 -04:00
Luke Faraone
fd7dd0bc2c Use correct presence names for iOS mobile devices 
(imported from commit d75f56c26d272342e2b4d074ea90a6d7fb9cff4e)
 2014-03-11 13:06:23 -04:00
Luke Faraone
bd20a756f9 Show a mobile icon in the presence list when relevant 
We show a user as "on mobile" if:
 * They are only active on mobile
 * They are inactive on all devices and can receive push notifications

(imported from commit 0510b9371727cd19c72f6990df7112921c36ad48)
 2014-03-11 13:06:23 -04:00
Waseem Daher
4397c25976 Wrap 'Receive audible notifications'. 
This resolves Trac #2366.

(imported from commit 0de4b20e0310980181716f7a29a82a4228a16b1b)
 2014-03-11 13:06:23 -04:00
Zev Benjamin
bdee9721ec tests: Delay loading old messages and starting get_updates until phantomjs thinks the page has loaded 
This doesn't affect code when not in testing.  It shaves 7 seconds off of casper
test time on my machine.

(imported from commit 7e27fa781bcf16f36d9c8f058427ba57c41068bd)
 2014-03-11 13:06:22 -04:00
Zev Benjamin
f45f0b1df6 Get message row safely in the presence of local ids 
(imported from commit 4f8c4742206a9fcba4eb19653152aeb4919159bd)
 2014-03-11 13:06:22 -04:00
Zev Benjamin
d3f14ae860 message_flags.js: Add comment 
(imported from commit 6660076a04f765f67ade35664bd09678691d37c3)
 2014-03-11 13:06:21 -04:00
Zev Benjamin
9d04b3d643 Don't tightly recurse when updating flags for local messages 
(imported from commit a4a9f5278c9445fae753311ea16f165be15ff8eb)
 2014-03-11 13:06:21 -04:00
Zev Benjamin
6071a11419 tests: Defer sockjs object creation when in testing 
This speeds up CasperJS tests by 25 seconds per main app page load.

When we switched the SockJS, the casper tests got inexplicably slower.  I
finially figured out what's going on.  The first SockJS XHR request (remember
that we don't get websockets in the test suite) gets considered part of the page
load and therefore the PhantomJS onLoadFinished handler doesn't get called until
the SockJS XHR finishes, which happens at the heartbeat, 25 seconds later.  To
fix this, we simply don't create the SockJS object on page load since it will be
created on demand, anyway.

(imported from commit 845a97526c5102df426cd6fc26182a734e7fcab6)
 2014-03-11 13:06:20 -04:00
Zev Benjamin
1c7918495c socket: Factor out SockJS object creation 
(imported from commit cedb2b3e6ade0b045e8d4982437f6499ae904222)
 2014-03-11 13:06:20 -04:00