This commit moves bot related code from settings_users.ts to
settings_bots.ts as we have different panels for users and bots
and we already have code for multiple tabs in settings_users.ts
and separating bots code makes maintaining the code easy.
This commit includes the following changes:
- Redirects Personal > Bots to Organization Settings > Bots.
- Cleans up bot_settings.hbs, bot_avatar_row.hbs, and CSS related to
these UIs, along with cleanup of settings_bots.ts.
- Reworks the Puppeteer tests to align with the new changes.
Fixes part of #31156.
Co-authored-by: Sujal Shah <sujalshah28092004@gmail.com>
This commit adds code to allow downloading bot config for
all outgoing webhooks bot owned by the user from "Your bots"
tabs in the "Bots" settings panel.
Fixes part of #31156.
Co-authored-by: Sujal Shah <sujalshah28092004@gmail.com>
Previously, there was only one bot section tab. Now it has
been split into two subsections: "All Bots" and "Your Bots."
Also, the action column is now visible for non-admins users also
so that they can manage their own bots.
Fixes part of #31156.
Co-authored-by: Sujal Shah <sujalshah28092004@gmail.com>
This commit renames variables, functions and element IDs used
for bots table such that the name make it clear that they
are being used for "All bots" table. This commit is a prep
commit for further commits which would add tabbed view in
bots panel with "All bots" and "Your bots" tabs.
This adds a new field in the "Organization settings" menu for the
moderation request channel. It only includes private channels as the
dropdown options.
Fixes#20047.
Co-authored-by: Adam Sah <140002+asah@users.noreply.github.com>
Co-authored-by: Alya Abbott <alya@zulip.com>
Since `compose_validate.validate` sets the error messages
for posting policy, it is important that it is called before
we check for posting policy errors.
To fix it, we remove independent calls to
check_posting_policy_for_compose_box and call it after validation.
This also fixes a bug where compose posting policy error is
not displayed when a user is trying to DM a recipient with no
previous message history and the user is not allowed to start
a new DM conversation.
Co-authored-by: Lauryn Menard <lauryn@zulip.com>
An error was raised where we tried to live update the folder name
in folder dropdown even when there was no dropdown visible
to the non-admin user in settings page. This was because
"There are no channel folders configured in this organization."
text was shown even when a folder was recently created in the
realm as we did not live update the visibility of dropdown on
creating or archiving a folder.
This commit fixes the bug by live-updating the visibility
of folder dropdown when creating or archiving a folder.
This commit adds live-update code to reset the dropdown when user
is changing the folder for a channel or setting the folder for a
new channel and the selected folder is archived.
Zulip production suite / ${{ matrix.name }} (zulip/ci:bookworm, --test-custom-db, Debian 12 production install with custom db name and user, bookworm) (push) Has been cancelled
Zulip production suite / ${{ matrix.name }} (zulip/ci:jammy, , Ubuntu 22.04 production install and PostgreSQL upgrade with pgroonga, jammy) (push) Has been cancelled
This commit adds code to use
`web_left_sidebar_unreads_count_summary` from personal
settings in web app.
Co-authored-by: Akarsh Jain <akarsh.jain.790@gmail.com>
Fixes part of #28759.
Changes done here are -
- Previously the pill input, "Add" button and tooltip shown
when user did not have permission were not live updated when
updating can_add_subscribers_group and can_subscribe_group
stream level settings or can_add_subscribers_group realm
level setting. This commit fixes that.
- Also, when the UI was live updated to give user permission
to subscribe others, "Add" button was enabled even when
input was empty. This is also fixed in this commit.
Earlier, when `realm_mandatory_topics` setting was getting toggled,
the topic input box in composebox was not being live-updated to
align with the correspondning setting's UX.
This commit fixes that bug by making sure that placeholder and
other UI elements are updated accordingly.
This commit separates the "resolve topic" permissions from the
topic editing permissions, through the introduction of setting -
"can_resolve_topics_group" which user group whose members
can resolve topics.
Fixes#21811
This commit adds typing indicators for message editing in stream
as well as in dm, if the send typing notification
for corresponding is enabled.
Based on earlier work in #28585.
Co-authored-by: Rohan Gudimetla <rohan.gudimetla07@gmail.com>
Fixes#25719.
Added `can_create_bots_group` setting which controls who can
create any type of bots in the organization.
Added `can_create_write_only_bots_group` setting which controls
who can create incoming webhooks in the organization in additon
to those who are in `can_create_bots_group`.
We now pass group in functions called while handling group update
events, instead of fetching the groups in those function as we
will need the old setting value in future commits.
Tests for testing user group events does not stub "user_groups"
module anymore as it is mainly used to handle data and it is
easy to test the events without stubbing them.
