Alex Vandiver
52ba675a26
Revert "compose: Track when the recipient box has recently had focus."
...
API Documentation Update Check / check-feature-level-updated (push) Has been cancelled
Code scanning / CodeQL (push) Has been cancelled
Zulip production suite / Ubuntu 22.04 production build (push) Has been cancelled
Zulip CI / ${{ matrix.name }} (zulip/ci:bookworm, true, false, Debian 12 (Python 3.11, backend + documentation), bookworm) (push) Has been cancelled
Zulip CI / ${{ matrix.name }} (zulip/ci:jammy, false, true, Ubuntu 22.04 (Python 3.10, backend + frontend), jammy) (push) Has been cancelled
Zulip CI / ${{ matrix.name }} (zulip/ci:noble, false, false, Ubuntu 24.04 (Python 3.12, backend), noble) (push) Has been cancelled
Zulip CI / ${{ matrix.name }} (zulip/ci:trixie, false, false, Debian 13 (Python 3.13, backend), trixie) (push) Has been cancelled
API Documentation Update Check / notify-if-api-docs-changed (push) Has been cancelled
Zulip production suite / ${{ matrix.name }} (zulip/ci:bookworm, --test-custom-db, Debian 12 production install with custom db name and user, bookworm) (push) Has been cancelled
Zulip production suite / ${{ matrix.name }} (zulip/ci:jammy, , Ubuntu 22.04 production install and PostgreSQL upgrade with pgroonga, jammy) (push) Has been cancelled
Zulip production suite / ${{ matrix.name }} (zulip/ci:noble, , Ubuntu 24.04 production install, noble) (push) Has been cancelled
Zulip production suite / ${{ matrix.name }} (zulip/ci:trixie, , Debian 13 production install, trixie) (push) Has been cancelled
Zulip production suite / ${{ matrix.name }} (zulip/ci:bookworm-7.0, 7.0 Version Upgrade, bookworm) (push) Has been cancelled
Zulip production suite / ${{ matrix.name }} (zulip/ci:bookworm-8.0, 8.0 Version Upgrade, bookworm) (push) Has been cancelled
Zulip production suite / ${{ matrix.name }} (zulip/ci:jammy-6.0, 6.0 Version Upgrade, jammy) (push) Has been cancelled
Zulip production suite / ${{ matrix.name }} (zulip/ci:noble-10.0, 10.0 Version Upgrade, noble) (push) Has been cancelled
Zulip production suite / ${{ matrix.name }} (zulip/ci:noble-9.0, 9.0 Version Upgrade, noble) (push) Has been cancelled
Zulip production suite / ${{ matrix.name }} (zulip/ci:trixie-11.0, 11.0 Version Upgrade, trixie) (push) Has been cancelled
This reverts commits 5ce956c9bb and
14c51bd0ec , which broke the compose box
in channels with "only general chat" set.
2025-10-16 19:02:15 +00:00
Shubham Padia
7bce6361b3
css: Do not use non-color values inside light-dark().
...
Non-color values are not permitted inside light-dark(). This commit
fixes that for --color-invalid-input-box-shadow.
2025-10-08 15:04:41 -07:00
Shubham Padia
f6d972048b
css: Remove redundant border related css for .preview_message_area.
...
We removed the border declaration in #29953 . We do not need the
border-radius anymore, nor the border-color declaration in
dark_theme.css.
2025-10-06 17:44:11 -07:00
Karl Stolley
14c51bd0ec
compose: Track when the recipient box has recently had focus.
...
This helps to prevent an edge case where clicking the
new-topic button, `[+]`, in the left sidebar when the
topic box was already empty caused an unexpected flash
of the *general chat* topic.
2025-09-16 11:53:46 -07:00
Karl Stolley
a4657a5bd7
compose: Correct for undesired outline flash on pills.
2025-09-16 11:53:46 -07:00
Karl Stolley
75714bb44f
compose: Remove competing transitions.
...
The transitions here do not work correctly across all
states, and directly interfere or look goofy with the
transitions in the recipient-row area.
Particularly with the removal from #message-content-container,
that had the annoying effect of just delaying the
appearance of the focus border, regardless of whether
focus was established via keyboard or mouse.
2025-09-16 11:53:46 -07:00
Karl Stolley
de7419a528
compose: Only transition when low-attention row hovered.
...
Previously, if the mouse cursor were in the vicinity of
the compose box, we'd see transitions even on keyboard
interactions, which should not have been happening.
This also allows instantaneous highlighting for keyboard
users, as well as avoiding any transitions when a
mouse user clicks into a recipient-row element (at
which point the hover transitions will have already
run).
2025-09-16 11:53:46 -07:00
Karl Stolley
2fce6fa317
compose: Offset low-attention pill outlines.
2025-09-16 11:53:46 -07:00
Karl Stolley
165c47cb14
compose: Ensure textarea is hidden in compose preview.
...
This corrects a subtle bug where being zoomed in in
a narrow window causes textarea bleedthrough behind
elements like the audio player.
2025-08-28 15:20:11 -07:00
Karl Stolley
fce8b57e27
dropdown_lists: Present gridded list items.
...
Fixes #35600 .
Co-Authored-By: Kunal Sharma <[email protected] >
2025-08-12 12:41:31 -07:00
Karl Stolley
4c129e73b7
dropdown_lists: Simplify selected item-text class.
2025-08-12 12:41:31 -07:00
Karl Stolley
7a2116ab5d
compose: Suppress low-attention styles with keyboard focus.
2025-08-11 14:37:56 -07:00
Vector73
4e93607fde
tooltip: Show only empty topic allowed tooltip on the topic text.
...
This commit shows "Only general chat allowed in this channel" tooltip
close to the topic text instead of in the center of topic input by updating
the topic input box "max-width" to "fit-content".
2025-07-15 10:10:02 -07:00
Karl Stolley
ac0cc78327
compose: Size and place formatting icons to spec.
...
Note that this establishes a 30px by 30px box at
Vlad's original font-size, 15px. His spec called for
a 30px by 28px box, but does not reflect the height of
the Send button, which is 30px tall. So to maintain
that height and perfectly center the icons, we create
a 30px square for the button.
2025-07-10 08:29:48 -07:00
Karl Stolley
02528992a2
compose: Remove dead flex directive.
...
The grouping element in the DOM, .compose_control_button_container,
is not a flexbox, so this directive is ignored by browsers.
2025-07-10 08:29:48 -07:00
Vector73
a77fc6aa79
stream_settings: Add new disable_topics option to topics_policy.
...
Adds new configuration option `disable_topics` in `topics_policy`
channel setting to support disabling topics in the channel.
Fixes #34553 .
2025-07-09 14:25:53 -07:00
Karl Stolley
9dec5481eb
compose: Set grid-area for iconless channel label.
2025-06-24 10:13:16 -07:00
Karl Stolley
062b83bfec
compose: Rename classes, CSS vars to reflect attention level.
2025-06-20 15:54:59 -07:00
Karl Stolley
e0860a7635
compose: Experiment with adjusted privacy icon colors.
2025-06-19 17:21:20 -07:00
Karl Stolley
0c7e445649
compose: Highlight topic box on new-topic hover.
2025-06-19 17:21:20 -07:00
Karl Stolley
0d357d3ecc
compse: Reduce transition timing, delay.
2025-06-19 17:21:20 -07:00
Karl Stolley
f1cde90a87
compose: Allow DMs to take muted-recipient logic.
2025-06-19 17:21:20 -07:00
Karl Stolley
d772623d04
compose: Add muted, hover styles for recipient row.
2025-06-19 17:21:20 -07:00
Karl Stolley
1ed8f577ed
compose: Add temporary hover color on recipient borders.
2025-06-19 17:21:20 -07:00
Karl Stolley
f5a661a462
compose: Rewrite picker as grid and adjust presentation.
2025-06-19 17:21:20 -07:00
Karl Stolley
5ca0c39125
compose: Reduce negative space in compose box.
2025-06-19 17:21:20 -07:00
Karl Stolley
11de082def
compose: Reduce recipient-row height to 32px at 16px/1em.
2025-06-19 17:21:20 -07:00
Karl Stolley
00a2e13e07
compose: Suppress chevron on channel/DM picker.
2025-06-19 17:21:20 -07:00
Karl Stolley
75ed0c9383
compose: Preserve decorated-stream layout in picker.
...
In addition to preserving the space between the icon and
stream name, this also moves the ellipsis to the DOM node
for the channel name itself.
2025-04-22 11:26:12 -07:00
Karl Stolley
3671a6a39c
decorated_channels: Rename privacy-icon class.
2025-04-22 11:26:12 -07:00
Karl Stolley
33522543c6
dark_theme: Clean up moving bar on main-view banner.
2025-04-07 15:07:14 -07:00
Karl Stolley
2e8c1407ae
dark_theme: Clean up action link on main-view banner.
2025-04-07 15:07:14 -07:00
Karl Stolley
4ccea351f4
dark_theme: Clean up info-style main-view banner.
2025-04-07 15:07:14 -07:00
Karl Stolley
8f465c9836
dark_theme: Clean up error-style main-view banner.
2025-04-07 15:07:14 -07:00
Karl Stolley
78de5c05a1
dark_theme: Clean up warning-style main-view banner.
2025-04-07 15:07:14 -07:00
Karl Stolley
c2b1c2ca5a
dark_theme: Clean up success-style main-view banner.
2025-04-07 15:07:14 -07:00
Karl Stolley
65e3d487bf
dark_theme: Set color variables for compose-content border.
...
Note that the dark-theme color comes from the stack of selectors
that included `#compose-content`.
2025-04-04 14:04:52 -07:00
Karl Stolley
8b9942c015
dark_theme: Remove unused colorblock selectors.
...
None of these selectors appear in any template or JavaScript.
2025-04-04 14:04:52 -07:00
Karl Stolley
815dccdb7f
snippets: Better distinguish snippet content in dropdown.
2025-04-03 16:44:36 -07:00
Karl Stolley
ca1e56d91b
compose: Prevent picker from collapsing.
2025-04-01 11:22:14 -07:00
ubaidrmn
382a828eec
message_edit: Fix stale syntax upon cancelling upload in preview.
...
Previously, canceling an upload in preview mode &
returning to editing left the syntax unchanged
(e.g., still showing "Uploading"). This happened
because the `replaceFieldText` function does not
work when the text area's display is none.
To fix this, instead of hiding the textarea in
preview mode, we use a grid to overlap it with
the preview container. This is the same thing we
are doing in the compose box. We have also added
css to ensure the textarea remains hidden behind
the transparent preview container
in preview mode.
2025-03-25 11:31:45 -07:00
Prakhar Pratyush
a54bd3cdfa
compose_recipient: Avoid using .css() for visibility toggling.
...
This commit replaces direct `.css("visibility", "...")` calls
with `.addClass("visible")` and `.removeClass("visible")` to
manage the `$topic_not_mandatory_placeholder` visibility.
This improves maintainability by keeping styling in CSS.
2025-03-20 10:32:31 -07:00
Tim Abbott
bccc283554
Revert "compose: Fix buttons spilling from compose box."
...
This reverts commit 9243fa3d52 .
This commit appears to have caused the same issue with the compose box
borders at other size/zoom configurations that may be more common.
We'll figure out a better fix and apply that.
2025-03-20 09:28:05 -07:00
harshbansal8705
9243fa3d52
compose: Fix buttons spilling from compose box.
2025-03-19 11:32:51 -07:00
Aman Agrawal
8858f03847
compose: Revert send button color to that in 9.x.
...
This reverts commits 9501082e99 and
a8cfd2fb04 .
2025-03-19 09:00:49 -07:00
Karl Stolley
0f17d6e7ef
compose: Remove browser-default outline on Send button.
2025-03-18 09:10:54 -07:00
Karl Stolley
9b33a81351
compose: Remove focus-visible color from Send button.
2025-03-18 09:10:54 -07:00
Aman Agrawal
49a9197c52
compose: Use info colors for send button.
2025-03-17 10:23:48 -07:00
Aman Agrawal
4029d80c01
compose: Use standard primary button colors for compose send button.
2025-03-14 10:07:05 -07:00
Vector73
b31024be47
saved_snippets: Add support for editing saved snippets.
...
Fixes #33708 .
2025-03-13 10:58:36 -07:00