Drop the universal h1, h2, h3, h4 selectors carried over from
Bootstrap 2.3.2. Earlier commits in this series made every scoped
heading rule that depended on these resets self-sufficient, so this
deletion is purely a no-op for visible behavior.
Removed properties were:
* margin: 10px 0 (now set explicitly on .overlay-messages-header h1,
.settings-header h1, .settings-section h3,
.drafts-list h2 / .message-edit-history-list h2,
.empty-feed-notice-title, .poll-question-header /
.todo-task-list-title-header, and
.group-assigned-permissions .group-permissions-section > h3)
* line-height: 20px / var(--header-line-height) (now set explicitly
on the same rules where it was load-bearing — overlay headers,
user-profile modal h3s, folder-channels-list-header, etc.)
* font-size: 38.5px/31.5px/24.5px/17.5px (overridden in every place
the app actually rendered these headings; only one bare instance
per overlay needed an explicit replacement, captured above)
* font-weight: bold (matches the user-agent default for h1-h6 — no
replacement needed; .light's 'font-weight: 300' override now
competes only with the UA default, preserving its current effect)
* color: inherit, font-family: inherit, text-rendering:
optimizelegibility (no-ops vs. UA defaults; no replacement needed)
The .alert h4 rules at the bottom of the file are part of the alert
component, not the heading reset, and remain in place.
The --header-line-height variable in app_variables.css is still used
by modal.css (height: calc(100% - var(--header-line-height))) and by
several of the explicit replacements above, so it stays.
Verified with a Puppeteer-based computed-style sweep: settings
overlay (Account, Notifications, Preferences, Org permissions, Org
profile), drafts and scheduled-messages overlay headers, and the
empty-feed notice all render identical font-size, line-height,
margin, font-weight, and bounding-box dimensions before and after
this series.
This commit is a follow-up to 18b2427937,
which removed the `alert-error` class from the Bootstrap CSS, while the
`web/src/ui_report.ts` module still used this styling for the error
banners.
This commit adds the `alert-error` class back to the Bootstrap CSS,
as a temporary solution until these alerts are migrated to the new
banner component system.
Removing `.alert` from the dark theme seems acceptable,
as there is nowhere in the codebase we're setting a
`text-shadow` value that would require `none` here.
This commit removes the `button-secondary`, `button-group` and
`bootstrap-btn-group` classes which don't have any corresponding styles
attached to them or are no longer in use in the codebase.
This commit removes the final vestiges of `bootstrap-btn-default` class
from the codebase, by moving the relevant styles from the
`bootstrap-btn` and `bootstrap-btn-default` classes to the
`button-recent-filters` class.
This commit is a part of the efforts to rename btn-related classes
and variables to align with Zulip's no-abbreviations policy and
streamline the search results.
This commit is a part of the efforts to rename btn-related classes
and variables to align with Zulip's no-abbreviations policy and
streamline the search results.
This commit is a part of the efforts to rename btn-related classes
and variables to align with Zulip's no-abbreviations policy and
streamline the search results.
With the redesign of all popovers completed, we have transitioned away
from the legacy Bootstrap-based popover system. As a result, the
Bootstrap `nav nav-list` classes are now obsolete and no longer used
in the codebase.
This commit, a part of the efforts to clean up the legacy Bootstrap CSS,
removes these unused classes and any related CSS workarounds.
Fixes#26990.
* `.container` class is only used in `/activity/support` and
`/activity/remote/support` pages. It is also used in emails but
it has its own CSS.
* Since the CSS applied is localized and looks good, we just
move the CSS relevant to us to `activity.css` which is used
by both of these pages.
* Searched `"container"`, ` container `, `"container ` and
` container"` to look for the uses of this class.
Happily, every last CSS property in these styles is already
described for the places <pre> appears in the Zulip UI:
1. In rendered message markdown
2. In the compose preview
3. In the information overlay (Message formatting)
The `line-height` value is set to `inherit` in zulip.css, rendering
this line moot. `inherit` will always force list items to take
their line height from the nearest ancestor that sets one.
* `font-size: 100%` is unnecessary, as `font-size: 16px` is set on
the `body` selector.
* `text-size-adjust` is unnecessary, as supporting browsers appear
to use `100%` as a default value anyway.
