CodeCow/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2026-07-18 21:04:19 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Don't pass UserProfile object to client_put().

Browse Source 
This was in AdminCreateUserTest.test_create_user_backend().
For end to end tests we are logged in, and we need to verify
that our decorators add UserProfile to the parameters of
the view on our behalf, so that we don't get false positives.

In an upcoming commit, we will want to be able to serialize
the parameters for client_put to produce url coverage reports,
so that is another reason not to pass in the UserProfile
object.  (That was how this was discovered.)
This commit is contained in:
Steve Howell 2016-07-28 07:48:35 -07:00 committed by Tim Abbott
parent c0e1e23941
commit ffe364c719
1 changed files with 0 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
zerver/tests/tests.py
View File

@ -254,14 +254,12 @@ class AdminCreateUserTest(AuthedTestCase):
self.assert_json_error(result, "Missing 'email' argument")
result = self.client_put("/json/users", dict(
user_profile=admin,
email='romeo@not-zulip.com',
)
)
self.assert_json_error(result, "Missing 'password' argument")
result = self.client_put("/json/users", dict(
user_profile=admin,
email='romeo@not-zulip.com',
password='xxxx',
)
@ -269,7 +267,6 @@ class AdminCreateUserTest(AuthedTestCase):
self.assert_json_error(result, "Missing 'full_name' argument")
result = self.client_put("/json/users", dict(
user_profile=admin,
email='romeo@not-zulip.com',
password='xxxx',
full_name='Romeo Montague',
@ -278,7 +275,6 @@ class AdminCreateUserTest(AuthedTestCase):
self.assert_json_error(result, "Missing 'short_name' argument")
result = self.client_put("/json/users", dict(
user_profile=admin,
email='broken',
password='xxxx',
full_name='Romeo Montague',
@ -288,7 +284,6 @@ class AdminCreateUserTest(AuthedTestCase):
self.assert_json_error(result, "Bad name or username")
result = self.client_put("/json/users", dict(
user_profile=admin,
email='romeo@not-zulip.com',
password='xxxx',
full_name='Romeo Montague',
@ -300,7 +295,6 @@ class AdminCreateUserTest(AuthedTestCase):
# HAPPY PATH STARTS HERE
valid_params = dict(
user_profile=admin,
email='romeo@zulip.com',
password='xxxx',
full_name='Romeo Montague',